summaryrefslogtreecommitdiff
path: root/target-sparc
diff options
context:
space:
mode:
authorThomas Huth <thuth@redhat.com>2016-06-16 19:33:38 +0200
committerMichael Tokarev <mjt@gandalf>2016-09-13 18:12:34 +0300
commita337f295defad7eb977da4d6317cf70f7f2fa4b4 (patch)
tree33f32e3efdc0b5d443df881e0c2eec9d68b23ee5 /target-sparc
parentbc82585a8fd5d38e7c2402999a7ccc9a97d762c9 (diff)
downloadqemu-a337f295defad7eb977da4d6317cf70f7f2fa4b4.tar.gz
sparc: Use g_memdup() instead of g_new0() + memcpy()
There is no need to make sure that the memory is zeroed after the allocation if we also immediatly fill the whole buffer afterwards with memcpy(). Thus g_new0 should be g_new instead. But since we are also doing a memcpy() here, we can also simply replace both with g_memdup() instead. Signed-off-by: Thomas Huth <thuth@redhat.com> Acked-By: Artyom Tarasenko <atar4qemu@gmail.com> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Diffstat (limited to 'target-sparc')
-rw-r--r--target-sparc/cpu.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/target-sparc/cpu.c b/target-sparc/cpu.c
index e4089f2074..800a25aa57 100644
--- a/target-sparc/cpu.c
+++ b/target-sparc/cpu.c
@@ -117,8 +117,7 @@ static int cpu_sparc_register(SPARCCPU *cpu, const char *cpu_model)
return -1;
}
- env->def = g_new0(sparc_def_t, 1);
- memcpy(env->def, def, sizeof(*def));
+ env->def = g_memdup(def, sizeof(*def));
featurestr = strtok(NULL, ",");
sparc_cpu_parse_features(CPU(cpu), featurestr, &err);