diff options
| author | Richard Henderson <rth@twiddle.net> | 2013-09-09 16:49:36 -0700 |
|---|---|---|
| committer | Richard Henderson <rth@twiddle.net> | 2013-09-25 07:46:31 -0700 |
| commit | 5b1c985b7e4d3f430769925c1775c9e8836272df (patch) | |
| tree | 1f3176bc8ac5c0767babe9357bc2a2f7f2b0f5d3 /tcg/ppc | |
| parent | 1d10cf9886429d17d22e233081697ef27465dca3 (diff) | |
| download | qemu-5b1c985b7e4d3f430769925c1775c9e8836272df.tar.gz | |
tcg-ppc: Use conditional branch and link to slow path
Saves one insn per slow path. Note that we can no longer use
a tail call into the store helper.
Signed-off-by: Richard Henderson <rth@twiddle.net>
Diffstat (limited to 'tcg/ppc')
| -rw-r--r-- | tcg/ppc/tcg-target.c | 15 |
1 files changed, 10 insertions, 5 deletions
diff --git a/tcg/ppc/tcg-target.c b/tcg/ppc/tcg-target.c index a5f1f99592..516d28f879 100644 --- a/tcg/ppc/tcg-target.c +++ b/tcg/ppc/tcg-target.c @@ -611,9 +611,14 @@ static void tcg_out_tlb_check (TCGContext *s, int r0, int r1, int r2, tcg_out32 (s, CMP | BF (6) | RA (addr_reg2) | RB (r1)); tcg_out32 (s, CRAND | BT (7, CR_EQ) | BA (6, CR_EQ) | BB (7, CR_EQ)); #endif + + /* Use a conditional branch-and-link so that we load a pointer to + somewhere within the current opcode, for passing on to the helper. + This address cannot be used for a tail call, but it's shorter + than forming an address from scratch. */ *label_ptr = s->code_ptr; retranst = ((uint16_t *) s->code_ptr)[1] & ~3; - tcg_out32 (s, BC | BI (7, CR_EQ) | retranst | BO_COND_FALSE); + tcg_out32(s, BC | BI(7, CR_EQ) | retranst | BO_COND_FALSE | LK); /* r0 now contains &env->tlb_table[mem_index][index].addr_x */ tcg_out32 (s, (LWZ @@ -853,7 +858,7 @@ static void tcg_out_qemu_ld_slow_path(TCGContext *s, TCGLabelQemuLdst *l) tcg_out_mov(s, TCG_TYPE_I32, ir++, l->addrlo_reg); } tcg_out_movi(s, TCG_TYPE_I32, ir++, l->mem_index); - tcg_out_movi(s, TCG_TYPE_PTR, ir, (uintptr_t)l->raddr); + tcg_out32(s, MFSPR | RT(ir++) | LR); tcg_out_b(s, LK, (uintptr_t)ld_trampolines[l->opc & 3]); datalo = l->datalo_reg; @@ -928,9 +933,9 @@ static void tcg_out_qemu_st_slow_path(TCGContext *s, TCGLabelQemuLdst *l) ir++; tcg_out_movi(s, TCG_TYPE_I32, ir++, l->mem_index); - tcg_out_movi(s, TCG_TYPE_PTR, ir, (uintptr_t)l->raddr); - tcg_out32(s, MTSPR | RS(ir) | LR); - tcg_out_b(s, 0, (uintptr_t)st_trampolines[l->opc]); + tcg_out32(s, MFSPR | RT(ir++) | LR); + tcg_out_b(s, LK, (uintptr_t)st_trampolines[l->opc]); + tcg_out_b(s, 0, (uintptr_t)l->raddr); } void tcg_out_tb_finalize(TCGContext *s) |