summaryrefslogtreecommitdiff
path: root/tests/hd-geo-test.c
diff options
context:
space:
mode:
authorKevin Wolf <kwolf@redhat.com>2015-11-13 14:45:42 +0100
committerKevin Wolf <kwolf@redhat.com>2015-12-18 14:34:43 +0100
commit39c4ae941ed992a3bb5647fe7fafdd66d9278f43 (patch)
treeaf43e40152f7132491e4ac521dd5479a1ff9d2c4 /tests/hd-geo-test.c
parent145f598e4a96f6bb78664852bd589e4ea326be94 (diff)
downloadqemu-39c4ae941ed992a3bb5647fe7fafdd66d9278f43.tar.gz
blockdev: Set 'format' indicates non-empty drive
Creating an empty drive while specifying 'format' doesn't make sense. The specified format driver would simply be ignored. Make a set 'format' option an indication that a non-empty drive should be created. This makes 'format' consistent with 'driver' and allows using it with a block driver that doesn't need any other options (like null-co/null-aio). Signed-off-by: Kevin Wolf <kwolf@redhat.com> Reviewed-by: Max Reitz <mreitz@redhat.com>
Diffstat (limited to 'tests/hd-geo-test.c')
-rw-r--r--tests/hd-geo-test.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/tests/hd-geo-test.c b/tests/hd-geo-test.c
index 00afc209e6..13b763d6a7 100644
--- a/tests/hd-geo-test.c
+++ b/tests/hd-geo-test.c
@@ -206,13 +206,13 @@ static int setup_ide(int argc, char *argv[], int argv_sz,
{
char *s1, *s2, *s3;
- s1 = g_strdup_printf("-drive id=drive%d,if=%s,format=raw",
+ s1 = g_strdup_printf("-drive id=drive%d,if=%s",
ide_idx, dev ? "none" : "ide");
s2 = dev ? g_strdup("") : g_strdup_printf(",index=%d", ide_idx);
if (img_secs[img_idx] >= 0) {
setup_mbr(img_idx, mbr);
- s3 = g_strdup_printf(",file=%s", img_file_name[img_idx]);
+ s3 = g_strdup_printf(",format=raw,file=%s", img_file_name[img_idx]);
} else {
s3 = g_strdup(",media=cdrom");
}