diff options
| author | Michael S. Tsirkin <mst@redhat.com> | 2017-03-30 18:30:59 +0300 |
|---|---|---|
| committer | Michael S. Tsirkin <mst@redhat.com> | 2017-03-30 19:12:44 +0300 |
| commit | 0d876080a394993a8dea494ebf2d806dc0983107 (patch) | |
| tree | eb7c67ce8894aaec18232fdbc78664fb1436e246 /tests | |
| parent | 375f74f473cfcb0c73a64088a6a5880829c155da (diff) | |
| download | qemu-0d876080a394993a8dea494ebf2d806dc0983107.tar.gz | |
tests/acpi: don't pack a structure
There's no reason to pack structures where we don't care about size or
padding, this applies to AcpiStdTable in tests/acpi-utils.h.
OTOH bios-tables-test happens to be passing the address of a field in
this struct to a function that expects a pointer to normally aligned
data which results in a SIGBUS on architectures like SPARC that have
strict alignment requirements.
Fixes: 9e8458c02 ("acpi unit-test: compare DSDT and SSDT tables against expected values")
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Tested-by: Peter Maydell <peter.maydell@linaro.org>
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/acpi-utils.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/acpi-utils.h b/tests/acpi-utils.h index 9f9a2d532c..348e4d7931 100644 --- a/tests/acpi-utils.h +++ b/tests/acpi-utils.h @@ -26,7 +26,7 @@ typedef struct { gsize asl_len; gchar *asl_file; bool tmp_files_retain; /* do not delete the temp asl/aml */ -} QEMU_PACKED AcpiSdtTable; +} AcpiSdtTable; #define ACPI_READ_FIELD(field, addr) \ do { \ |