From 4a2594ddd35de7ae7c8cd9c6828cfe72245e6dc5 Mon Sep 17 00:00:00 2001 From: Markus Armbruster Date: Fri, 29 Jan 2010 19:48:56 +0100 Subject: qemu-option: Make qemu_opts_foreach() accumulate return values Return the bitwise inclusive or of all return values instead of the last call's value. This lets you find out whether any of the calls returned a non-zero value. No functional change, as existing users either don't care for the value, or pass non-zero abort_on_failure, which breaks the loop on the first non-zero return value. Signed-off-by: Markus Armbruster Signed-off-by: Anthony Liguori --- qemu-option.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-option.c b/qemu-option.c index 24392fcb4c..a52a4c4a08 100644 --- a/qemu-option.c +++ b/qemu-option.c @@ -814,7 +814,7 @@ int qemu_opts_foreach(QemuOptsList *list, qemu_opts_loopfunc func, void *opaque, int rc = 0; QTAILQ_FOREACH(opts, &list->head, next) { - rc = func(opts, opaque); + rc |= func(opts, opaque); if (abort_on_failure && rc != 0) break; } -- cgit v1.2.1