From 4bf2c138ddefc6ff17f6c4b947320c60aa0c38a0 Mon Sep 17 00:00:00 2001 From: Hani Benhabiles Date: Thu, 9 Jan 2014 19:34:27 +0100 Subject: net: Use g_strdup_printf instead of snprintf. assign_name() in net/net.c is using snprintf + g_strdup to get the same result as g_strdup_printf. Signed-off-by: Hani Benhabiles Signed-off-by: Stefan Hajnoczi --- net/net.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/net/net.c b/net/net.c index f8db85f30b..2c3af202a6 100644 --- a/net/net.c +++ b/net/net.c @@ -164,7 +164,6 @@ void qemu_macaddr_default_if_unset(MACAddr *macaddr) static char *assign_name(NetClientState *nc1, const char *model) { NetClientState *nc; - char buf[256]; int id = 0; QTAILQ_FOREACH(nc, &net_clients, next) { @@ -176,9 +175,7 @@ static char *assign_name(NetClientState *nc1, const char *model) } } - snprintf(buf, sizeof(buf), "%s.%d", model, id); - - return g_strdup(buf); + return g_strdup_printf("%s.%d", model, id); } static void qemu_net_client_destructor(NetClientState *nc) -- cgit v1.2.1