From 8926817219d18403e04625afddd29e6ad25c3162 Mon Sep 17 00:00:00 2001 From: Luiz Capitulino Date: Tue, 8 May 2012 14:24:46 -0300 Subject: qemu-ga: guest-shutdown: don't emit a success response Today, qemu-ga may not be able to emit a success response when guest-shutdown completes. This happens because the VM may vanish before qemu-ga is able to emit a response. This semantic is a bit confusing, as it's not clear for clients if they should wait for a response or how they should check for success. This commit solves that problem by changing guest-shutdown to never emit a success response and suggests in the documentation what clients could do to check for success. Signed-off-by: Luiz Capitulino Signed-off-by: Michael Roth --- qapi-schema-guest.json | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/qapi-schema-guest.json b/qapi-schema-guest.json index 692b570675..1dd3454555 100644 --- a/qapi-schema-guest.json +++ b/qapi-schema-guest.json @@ -131,11 +131,15 @@ # # @mode: #optional "halt", "powerdown" (default), or "reboot" # -# Returns: Nothing on success +# This command does NOT return a response on success. Success condition +# is indicated by the VM exiting with a zero exit status or, when +# running with --no-shutdown, by issuing the query-status QMP command +# to confirm the VM status is "shutdown". # # Since: 0.15.0 ## -{ 'command': 'guest-shutdown', 'data': { '*mode': 'str' } } +{ 'command': 'guest-shutdown', 'data': { '*mode': 'str' }, + 'success-response': 'no' } ## # @guest-file-open: -- cgit v1.2.1