From ca1d6ac657ff1cebd689b5d93784402e7ceb52c3 Mon Sep 17 00:00:00 2001 From: Joel Schopp Date: Wed, 21 Jul 2010 15:05:16 -0500 Subject: fix variable type in qemu-io.c The variable len can get a negative return value from cvtnum, which we check for, but which is impossible with the current unsigned variable type. Currently the if(len < 0) check is pointless. This patch fixes that. Signed-off-by: Joel Schopp Signed-off-by: Aurelien Jarno --- qemu-io.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-io.c b/qemu-io.c index 7c6120b6ac..2dbe20f33e 100644 --- a/qemu-io.c +++ b/qemu-io.c @@ -135,7 +135,7 @@ create_iovec(QEMUIOVector *qiov, char **argv, int nr_iov, int pattern) for (i = 0; i < nr_iov; i++) { char *arg = argv[i]; - uint64_t len; + int64_t len; len = cvtnum(arg); if (len < 0) { @@ -144,7 +144,7 @@ create_iovec(QEMUIOVector *qiov, char **argv, int nr_iov, int pattern) } /* should be SIZE_T_MAX, but that doesn't exist */ - if (len > UINT_MAX) { + if (len > INT_MAX) { printf("too large length argument -- %s\n", arg); goto fail; } -- cgit v1.2.1