From d3c5b2e6703869bb86639b29102df82380cc2d63 Mon Sep 17 00:00:00 2001 From: Jes Sorensen Date: Mon, 30 Aug 2010 12:31:33 +0200 Subject: hw/ivshmem.c don't check for negative values on unsigned data types There is no need to check for dest < 0 or vector >= 0 as both are uint16_t. This should fix problems with broken build with aggressive compiler flags. Reported by Xudong Hao Signed-off-by: Jes Sorensen Acked-by: Cam Macdonell Signed-off-by: Blue Swirl (cherry picked from commit 1b27d7a1e8609b2eeb6238f2c629eb82217523f6) --- hw/ivshmem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ivshmem.c b/hw/ivshmem.c index bbb5cbaa16..afebbc3657 100644 --- a/hw/ivshmem.c +++ b/hw/ivshmem.c @@ -199,13 +199,13 @@ static void ivshmem_io_writel(void *opaque, target_phys_addr_t addr, case DOORBELL: /* check that dest VM ID is reasonable */ - if ((dest < 0) || (dest > s->max_peer)) { + if (dest > s->max_peer) { IVSHMEM_DPRINTF("Invalid destination VM ID (%d)\n", dest); break; } /* check doorbell range */ - if ((vector >= 0) && (vector < s->peers[dest].nb_eventfds)) { + if (vector < s->peers[dest].nb_eventfds) { IVSHMEM_DPRINTF("Writing %" PRId64 " to VM %d on vector %d\n", write_one, dest, vector); if (write(s->peers[dest].eventfds[vector], -- cgit v1.2.1