From 23c88b24721ee907639705bf9de03dcd6b1e66ad Mon Sep 17 00:00:00 2001 From: Kevin Wolf Date: Wed, 16 Dec 2015 16:05:21 +0100 Subject: block: Fix error path in bdrv_invalidate_cache() We can only clear BDRV_O_INCOMING if the caches were actually invalidated. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake --- block.c | 2 ++ 1 file changed, 2 insertions(+) (limited to 'block.c') diff --git a/block.c b/block.c index 1a137167d9..6ac3191e08 100644 --- a/block.c +++ b/block.c @@ -3272,12 +3272,14 @@ void bdrv_invalidate_cache(BlockDriverState *bs, Error **errp) bdrv_invalidate_cache(bs->file->bs, &local_err); } if (local_err) { + bs->open_flags |= BDRV_O_INCOMING; error_propagate(errp, local_err); return; } ret = refresh_total_sectors(bs, bs->total_sectors); if (ret < 0) { + bs->open_flags |= BDRV_O_INCOMING; error_setg_errno(errp, -ret, "Could not refresh total sector count"); return; } -- cgit v1.2.1