From 8d20abe87afa735cd0ae6688bd105c7a27390343 Mon Sep 17 00:00:00 2001 From: Peter Lieven Date: Wed, 1 Feb 2017 10:53:48 +0100 Subject: block/nfs: fix NULL pointer dereference in URI parsing parse_uint_full wants to put the parsed value into the variable passed via its second argument which is NULL. Fixes: 94d6a7a76e9df9919629428f6c598e2b97d9426c Cc: qemu-stable@nongnu.org Signed-off-by: Peter Lieven Reviewed-by: Eric Blake Message-id: 1485942829-10756-2-git-send-email-pl@kamp.de Signed-off-by: Max Reitz --- block/nfs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'block/nfs.c') diff --git a/block/nfs.c b/block/nfs.c index a564340d15..baaecff3fd 100644 --- a/block/nfs.c +++ b/block/nfs.c @@ -108,12 +108,13 @@ static int nfs_parse_uri(const char *filename, QDict *options, Error **errp) qdict_put(options, "path", qstring_from_str(uri->path)); for (i = 0; i < qp->n; i++) { + unsigned long long val; if (!qp->p[i].value) { error_setg(errp, "Value for NFS parameter expected: %s", qp->p[i].name); goto out; } - if (parse_uint_full(qp->p[i].value, NULL, 0)) { + if (parse_uint_full(qp->p[i].value, &val, 0)) { error_setg(errp, "Illegal value for NFS parameter: %s", qp->p[i].name); goto out; -- cgit v1.2.1