From 5eda622768a2162993e50275b325125d4485757d Mon Sep 17 00:00:00 2001 From: Peter Xu Date: Wed, 9 Mar 2016 13:56:37 +0800 Subject: block/qapi: fix unbounded stack for dump_qdict Using heap instead of stack for better safety. Signed-off-by: Peter Xu Reviewed-by: Eric Blake Reviewed-by: Markus Armbruster Signed-off-by: Kevin Wolf --- block/qapi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'block/qapi.c') diff --git a/block/qapi.c b/block/qapi.c index e0e6e96ad2..1961cdf707 100644 --- a/block/qapi.c +++ b/block/qapi.c @@ -669,7 +669,7 @@ static void dump_qdict(fprintf_function func_fprintf, void *f, int indentation, for (entry = qdict_first(dict); entry; entry = qdict_next(dict, entry)) { QType type = qobject_type(entry->value); bool composite = (type == QTYPE_QDICT || type == QTYPE_QLIST); - char key[strlen(entry->key) + 1]; + char *key = g_malloc(strlen(entry->key) + 1); int i; /* replace dashes with spaces in key (variable) names */ @@ -683,6 +683,7 @@ static void dump_qdict(fprintf_function func_fprintf, void *f, int indentation, if (!composite) { func_fprintf(f, "\n"); } + g_free(key); } } -- cgit v1.2.1