From b412f49407e81dd6cdd9aaf5310895e579ed21d6 Mon Sep 17 00:00:00 2001 From: Kevin Wolf Date: Tue, 20 Mar 2018 18:09:15 +0100 Subject: vhdx: Require power-of-two block size on create Images with a non-power-of-two block size are invalid and cannot be opened. Reject such block sizes when creating an image. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Reviewed-by: Jeff Cody --- block/vhdx.c | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'block') diff --git a/block/vhdx.c b/block/vhdx.c index d2c54b7891..6a5e48eb69 100644 --- a/block/vhdx.c +++ b/block/vhdx.c @@ -1877,6 +1877,10 @@ static int coroutine_fn vhdx_co_create(BlockdevCreateOptions *opts, error_setg_errno(errp, EINVAL, "Block size must be a multiple of 1 MB"); return -EINVAL; } + if (!is_power_of_2(block_size)) { + error_setg(errp, "Block size must be a power of two"); + return -EINVAL; + } if (block_size > VHDX_BLOCK_SIZE_MAX) { error_setg_errno(errp, EINVAL, "Block size must not exceed %d", VHDX_BLOCK_SIZE_MAX); -- cgit v1.2.1