From e644473445177671ec408dfdec705cf931657998 Mon Sep 17 00:00:00 2001 From: Paolo Bonzini Date: Sun, 4 Nov 2012 12:43:37 +0100 Subject: nbd: force read-only export for read-only devices This is the desired behavior for HMP, but it is a better choice for QMP as well. Signed-off-by: Paolo Bonzini --- blockdev-nbd.c | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'blockdev-nbd.c') diff --git a/blockdev-nbd.c b/blockdev-nbd.c index 274fba6e46..e362572279 100644 --- a/blockdev-nbd.c +++ b/blockdev-nbd.c @@ -93,6 +93,13 @@ void qmp_nbd_server_add(const char *device, bool has_writable, bool writable, return; } + if (!has_writable) { + writable = true; + } + if (bdrv_is_read_only(bs)) { + writable = false; + } + exp = nbd_export_new(bs, 0, -1, writable ? 0 : NBD_FLAG_READ_ONLY, nbd_server_put_ref); -- cgit v1.2.1