From 847a6473206607bc6c84f6c537a0fe603ff7aaa6 Mon Sep 17 00:00:00 2001 From: Max Filippov Date: Thu, 18 Jan 2018 10:08:49 -0800 Subject: target/xtensa: disas/xtensa: fix coverity warnings Coverity warnings CID 1385146, 1385148 1385149 and 1385150 point that xtensa_opcode_num_operands and xtensa_format_num_slots may return -1 even when xtensa_opcode_decode and xtensa_format_decode succeed. In that case unsigned counters used to iterate through operands/slots will not do the right thing. Make counters and loop bounds signed to fix the warnings. Signed-off-by: Max Filippov --- disas/xtensa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'disas') diff --git a/disas/xtensa.c b/disas/xtensa.c index 114326a4fc..5e3870b9ad 100644 --- a/disas/xtensa.c +++ b/disas/xtensa.c @@ -37,7 +37,7 @@ int print_insn_xtensa(bfd_vma memaddr, struct disassemble_info *info) bfd_byte *buffer = g_malloc(1); int status = info->read_memory_func(memaddr, buffer, 1, info); xtensa_format fmt; - unsigned slot, slots; + int slot, slots; unsigned len; if (status) { @@ -79,7 +79,7 @@ int print_insn_xtensa(bfd_vma memaddr, struct disassemble_info *info) for (slot = 0; slot < slots; ++slot) { xtensa_opcode opc; - unsigned opnd, vopnd, opnds; + int opnd, vopnd, opnds; if (slot) { info->fprintf_func(info->stream, "; "); -- cgit v1.2.1