From adb2a9b5d4d5170f0b58b9f92f816048f6b8932b Mon Sep 17 00:00:00 2001 From: Tyler Hall Date: Wed, 25 Jul 2012 18:45:03 -0400 Subject: exec.c: Fix off-by-one error in register_subpage subpage_register() expects "end" to be the last byte in the mapping. Registering a non-page-aligned memory region that extends up to or beyond a page boundary causes subpage_register() to silently fail through the (end >= PAGE_SIZE) check. This bug does not cause noticeable problems for mappings that do not extend to a page boundary, though they do register an extra byte. Signed-off-by: Tyler Hall Reviewed-by: Peter Maydell Reviewed-by: Avi Kivity Signed-off-by: Stefan Hajnoczi --- exec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'exec.c') diff --git a/exec.c b/exec.c index feb4795525..27b100cb23 100644 --- a/exec.c +++ b/exec.c @@ -2271,7 +2271,7 @@ static void register_subpage(MemoryRegionSection *section) subpage = container_of(existing->mr, subpage_t, iomem); } start = section->offset_within_address_space & ~TARGET_PAGE_MASK; - end = start + section->size; + end = start + section->size - 1; subpage_register(subpage, start, end, phys_section_add(section)); } -- cgit v1.2.1