From 337283dffbb5ad5860ed00408a5fd0665c21be07 Mon Sep 17 00:00:00 2001 From: Eric Blake Date: Fri, 29 Jan 2016 06:48:57 -0700 Subject: qapi: Drop unused 'kind' for struct/enum visit MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit visit_start_struct() and visit_type_enum() had a 'kind' argument that was usually set to either the stringized version of the corresponding qapi type name, or to NULL (although some clients didn't even get that right). But nothing ever used the argument. It's even hard to argue that it would be useful in a debugger, as a stack backtrace also tells which type is being visited. Therefore, drop the 'kind' argument as dead. Signed-off-by: Eric Blake Reviewed-by: Marc-André Lureau Message-Id: <1454075341-13658-22-git-send-email-eblake@redhat.com> [Harmless rebase mistake cleaned up] Signed-off-by: Markus Armbruster --- hmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'hmp.c') diff --git a/hmp.c b/hmp.c index 27d6867664..3e2a9891c4 100644 --- a/hmp.c +++ b/hmp.c @@ -1670,7 +1670,7 @@ void hmp_object_add(Monitor *mon, const QDict *qdict) pdict = qdict_clone_shallow(qdict); v = opts_get_visitor(ov); - visit_start_struct(v, NULL, NULL, NULL, 0, &err); + visit_start_struct(v, NULL, NULL, 0, &err); if (err) { goto out_clean; } -- cgit v1.2.1