From b10fec9bfac17e932f630d341180d04be97074bc Mon Sep 17 00:00:00 2001 From: Stefan Weil Date: Thu, 19 Nov 2009 19:44:55 +0100 Subject: e1000: Fix warning from code review A code review run by Steve Grubb complained about code in e1000.c: In hw/e1000.c at line 89, vlan is declared to be 4 bytes. At line 382 is an attempt to do a memmove over it with a size of 12. This was fixed by splitting the memmove in two calls and adding a comment to the declaration of vlan and data. Signed-off-by: Stefan Weil Signed-off-by: Anthony Liguori --- hw/e1000.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'hw/e1000.c') diff --git a/hw/e1000.c b/hw/e1000.c index b65a74fe9e..8566fe3276 100644 --- a/hw/e1000.c +++ b/hw/e1000.c @@ -89,6 +89,7 @@ typedef struct E1000State_st { struct e1000_tx { unsigned char header[256]; unsigned char vlan_header[4]; + /* Fields vlan and data must not be reordered or separated. */ unsigned char vlan[4]; unsigned char data[0x10000]; uint16_t size; @@ -383,7 +384,8 @@ xmit_seg(E1000State *s) if (tp->sum_needed & E1000_TXD_POPTS_IXSM) putsum(tp->data, tp->size, tp->ipcso, tp->ipcss, tp->ipcse); if (tp->vlan_needed) { - memmove(tp->vlan, tp->data, 12); + memmove(tp->vlan, tp->data, 4); + memmove(tp->data, tp->data + 4, 8); memcpy(tp->data + 8, tp->vlan_header, 4); qemu_send_packet(&s->nic->nc, tp->vlan, tp->size + 4); } else -- cgit v1.2.1