From 81a322d4a1b68d47908a6630bf22897a289722aa Mon Sep 17 00:00:00 2001 From: Gerd Hoffmann Date: Fri, 14 Aug 2009 10:36:05 +0200 Subject: qdev: add return value to init() callbacks. Sorry folks, but it has to be. One more of these invasive qdev patches. We have a serious design bug in the qdev interface: device init callbacks can't signal failure because the init() callback has no return value. This patch fixes it. We have already one case in-tree where this is needed: Try -device virtio-blk-pci (without drive= specified) and watch qemu segfault. This patch fixes it. With usb+scsi being converted to qdev we'll get more devices where the init callback can fail for various reasons. Signed-off-by: Gerd Hoffmann Signed-off-by: Anthony Liguori --- hw/ssi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'hw/ssi.h') diff --git a/hw/ssi.h b/hw/ssi.h index 6ff71e9d35..24610a80cb 100644 --- a/hw/ssi.h +++ b/hw/ssi.h @@ -18,7 +18,7 @@ typedef struct SSISlave SSISlave; /* Slave devices. */ typedef struct { DeviceInfo qdev; - void (*init)(SSISlave *dev); + int (*init)(SSISlave *dev); uint32_t (*transfer)(SSISlave *dev, uint32_t val); } SSISlaveInfo; -- cgit v1.2.1