From 43d6464d410136f1c083a6df263bb71319eb2244 Mon Sep 17 00:00:00 2001 From: Peter Wu Date: Sat, 15 Mar 2014 17:34:06 +0100 Subject: usbdump: fail early if dump file is not available This allows for less less checking by the consumer and avoids unnecessary work if the capture cannot be written anyway. Signed-off-by: Peter Wu --- hw/usb/dev-unifying.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) (limited to 'hw/usb/dev-unifying.c') diff --git a/hw/usb/dev-unifying.c b/hw/usb/dev-unifying.c index 48479a07f4..68e2928b60 100644 --- a/hw/usb/dev-unifying.c +++ b/hw/usb/dev-unifying.c @@ -363,9 +363,7 @@ static void usb_ltunify_handle_control(USBDevice *dev, USBPacket *p, int desc_len = 0; const uint8_t *desc = NULL; - if (s->usb_dump_state) { - usb_dump_submit(s->usb_dump_state, p); - } + usb_dump_submit(s->usb_dump_state, p); /* handle basic requests such as DeviceRequest | USB_REQ_GET_DESCRIPTOR */ ret = usb_desc_handle_control(dev, p, request, value, index, length, data); @@ -409,9 +407,7 @@ static void usb_ltunify_handle_control(USBDevice *dev, USBPacket *p, } data_ready: - if (s->usb_dump_state) { - usb_dump_complete(s->usb_dump_state, p); - } + usb_dump_complete(s->usb_dump_state, p); } /* handle interrupt transfers (this device does not have a bulk/iso endpoint */ -- cgit v1.2.1