From d44bb8604e87ecd3823f12f0c92d5e56d613de0d Mon Sep 17 00:00:00 2001 From: Amos Kong Date: Thu, 21 Nov 2013 18:53:23 +0800 Subject: virtio-rng: add check of period If period is assigned to 0, limit timer will expire immediately. It causes a qemu warning: "main-loop: WARNING: I/O thread spun for 1000 iterations" This limit is meaningless. This patch forbids to assign 0 to period. Reviewed-by: Amit Shah Signed-off-by: Amos Kong Message-id: 1385031203-23790-1-git-send-email-akong@redhat.com Signed-off-by: Anthony Liguori --- hw/virtio/virtio-rng.c | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'hw/virtio') diff --git a/hw/virtio/virtio-rng.c b/hw/virtio/virtio-rng.c index 314e393520..b22ccf1008 100644 --- a/hw/virtio/virtio-rng.c +++ b/hw/virtio/virtio-rng.c @@ -139,6 +139,12 @@ static int virtio_rng_device_init(VirtIODevice *vdev) VirtIORNG *vrng = VIRTIO_RNG(vdev); Error *local_err = NULL; + if (!vrng->conf.period_ms > 0) { + qerror_report(QERR_INVALID_PARAMETER_VALUE, "period", + "a positive number"); + return -1; + } + if (vrng->conf.rng == NULL) { vrng->conf.default_backend = RNG_RANDOM(object_new(TYPE_RNG_RANDOM)); -- cgit v1.2.1