From c3cb8e77804313e1be99b5f28a34a346736707a5 Mon Sep 17 00:00:00 2001 From: Anthony Liguori Date: Fri, 12 Jul 2013 14:37:47 -0500 Subject: ioport: remove LITTLE_ENDIAN mark for portio MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Setting it to LE forces a byte swap when host != guest endian but this makes no sense at all. Herve made the suggestion upon observing that word writes/reads were broken into byte writes/reads in such a way as to assume devices are interpret registers as LE. However, even if this were a problem, marking the region as LE is not useful because what's essentially happening here is that LE is open coded. So by marking it LE in MemoryRegionOps, we're doing a superflous swap. Now, the portio code is suspicious to begin with. The dispatch layer really has no purpose in splitting I/O requests in the first place... Cc: Hervé Poussineau Cc: Alex Graf Cc: Benjamin Herrenschmidt Signed-off-by: Anthony Liguori --- ioport.c | 1 - 1 file changed, 1 deletion(-) (limited to 'ioport.c') diff --git a/ioport.c b/ioport.c index 79b7f1ae38..89b17d69f4 100644 --- a/ioport.c +++ b/ioport.c @@ -183,7 +183,6 @@ static void portio_write(void *opaque, hwaddr addr, uint64_t data, static const MemoryRegionOps portio_ops = { .read = portio_read, .write = portio_write, - .endianness = DEVICE_LITTLE_ENDIAN, .valid.unaligned = true, .impl.unaligned = true, }; -- cgit v1.2.1