From 5bbebf622897a59db5da4c468e737bfec4d71280 Mon Sep 17 00:00:00 2001 From: zhanghailiang Date: Fri, 14 Nov 2014 10:18:08 +0800 Subject: libcacard: fix resource leak In function connect_to_qemu(), getaddrinfo() will allocate memory that is stored into server, it should be freed by using freeaddrinfo() before connect_to_qemu() return. Cc: qemu-stable@nongnu.org Reviewed-by: Markus Armbruster Signed-off-by: zhanghailiang Signed-off-by: Paolo Bonzini --- libcacard/vscclient.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) (limited to 'libcacard') diff --git a/libcacard/vscclient.c b/libcacard/vscclient.c index 80111df00c..fa6041de99 100644 --- a/libcacard/vscclient.c +++ b/libcacard/vscclient.c @@ -597,7 +597,7 @@ connect_to_qemu( const char *port ) { struct addrinfo hints; - struct addrinfo *server; + struct addrinfo *server = NULL; int ret, sock; sock = socket(AF_INET, SOCK_STREAM, 0); @@ -629,9 +629,14 @@ connect_to_qemu( if (verbose) { printf("Connected (sizeof Header=%zd)!\n", sizeof(VSCMsgHeader)); } + + freeaddrinfo(server); return sock; cleanup_socket: + if (server) { + freeaddrinfo(server); + } closesocket(sock); return -1; } -- cgit v1.2.1