From 2c4681f512822b4aa35371683e164d4818f21dce Mon Sep 17 00:00:00 2001 From: Jason Wang Date: Mon, 2 Feb 2015 15:06:38 +0800 Subject: monitor: more accurate completion for host_net_remove() Current completion for host_net_remove will show hub ports and clients that were not peered with hub ports. Fix this. Cc: Luiz Capitulino Signed-off-by: Jason Wang Message-id: 1422860798-17495-4-git-send-email-jasowang@redhat.com Signed-off-by: Stefan Hajnoczi --- monitor.c | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'monitor.c') diff --git a/monitor.c b/monitor.c index 7e4f605e6d..e6dc50aa33 100644 --- a/monitor.c +++ b/monitor.c @@ -4597,8 +4597,13 @@ void host_net_remove_completion(ReadLineState *rs, int nb_args, const char *str) count = qemu_find_net_clients_except(NULL, ncs, NET_CLIENT_OPTIONS_KIND_NIC, 255); for (i = 0; i < count; i++) { + int id; const char *name; + if (ncs[i]->info->type == NET_CLIENT_OPTIONS_KIND_HUBPORT || + net_hub_id_for_client(ncs[i], &id)) { + continue; + } name = ncs[i]->name; if (!strncmp(str, name, len)) { readline_add_completion(rs, name); -- cgit v1.2.1