From 36af599417dde11747a27dc8550ff2281657a8ff Mon Sep 17 00:00:00 2001 From: Hani Benhabiles Date: Tue, 13 May 2014 00:35:15 +0100 Subject: nbd: Close socket on negotiation failure. Otherwise, the nbd client may hang waiting for the server response. Signed-off-by: Hani Benhabiles Acked-by: Paolo Bonzini Signed-off-by: Michael Tokarev --- qemu-nbd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'qemu-nbd.c') diff --git a/qemu-nbd.c b/qemu-nbd.c index eed79fa15e..f70e4b0dfc 100644 --- a/qemu-nbd.c +++ b/qemu-nbd.c @@ -369,8 +369,10 @@ static void nbd_accept(void *opaque) return; } - if (fd >= 0 && nbd_client_new(exp, fd, nbd_client_closed)) { + if (nbd_client_new(exp, fd, nbd_client_closed)) { nb_fds++; + } else { + close(fd); } } -- cgit v1.2.1