From ce0bd027df9c62766a5417521d0f08f27359d43f Mon Sep 17 00:00:00 2001 From: Ed Swierk Date: Thu, 20 Aug 2009 19:00:25 -0700 Subject: slirp: Remove our_addr code Three problems with our_addr: - It's determined only once when qemu starts, but the address can change (just like the DNS configuration can). - It's supposed to be the IP address of a host network interface, but there's no guarantee that gethostbyname(gethostname()) actually does that: the host might be a laptop that has only a loopback interface up, or the hostname might be localhost.localdomain, etc. - It's useless at best: get_dns_addr() calls it, there's no reason to send DNS requests to a different IP address if you're running a DNS server on the host and resolv.conf points to 127.0.0.1. These problems are easily solved by removing the code. Signed-off-by: Ed Swierk Signed-off-by: Anthony Liguori --- slirp/main.h | 1 - 1 file changed, 1 deletion(-) (limited to 'slirp/main.h') diff --git a/slirp/main.h b/slirp/main.h index 28d92d8866..9f22fe1b0a 100644 --- a/slirp/main.h +++ b/slirp/main.h @@ -30,7 +30,6 @@ extern char *slirp_tty; extern char *exec_shell; extern u_int curtime; extern fd_set *global_readfds, *global_writefds, *global_xfds; -extern struct in_addr our_addr; extern struct in_addr loopback_addr; extern struct in_addr dns_addr; extern char *username; -- cgit v1.2.1