From 055130107683c3b199c1848a25e5e2c568230cbf Mon Sep 17 00:00:00 2001 From: Richard Henderson Date: Mon, 21 Sep 2015 17:27:11 -0700 Subject: target-tilegx: Tidy simd_helper.c Using the V1 macro when we want to replicate a byte across the 8 elements of the word. Using deposit and extract for manipulating specific elements. Signed-off-by: Richard Henderson --- target-tilegx/simd_helper.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) (limited to 'target-tilegx') diff --git a/target-tilegx/simd_helper.c b/target-tilegx/simd_helper.c index b9319292f3..f573f9b51a 100644 --- a/target-tilegx/simd_helper.c +++ b/target-tilegx/simd_helper.c @@ -23,12 +23,16 @@ #include "exec/helper-proto.h" +/* Broadcast a value to all elements of a vector. */ +#define V1(X) (((X) & 0xff) * 0x0101010101010101ull) + + uint64_t helper_v1shl(uint64_t a, uint64_t b) { uint64_t m; b &= 7; - m = 0x0101010101010101ULL * (0xff >> b); + m = V1(0xff >> b); return (a & m) << b; } @@ -37,7 +41,7 @@ uint64_t helper_v1shru(uint64_t a, uint64_t b) uint64_t m; b &= 7; - m = 0x0101010101010101ULL * ((0xff << b) & 0xff); + m = V1(0xff << b); return (a & m) >> b; } @@ -48,8 +52,7 @@ uint64_t helper_v1shrs(uint64_t a, uint64_t b) b &= 7; for (i = 0; i < 64; i += 8) { - int64_t ae = (int8_t)(a >> i); - r |= ((ae >> b) & 0xff) << i; + r = deposit64(r, i, 8, sextract64(a, i + b, 8 - b)); } return r; } -- cgit v1.2.1