From 3bbe8aad0d68d924630129bdbe3ed0b70ee95b9a Mon Sep 17 00:00:00 2001 From: Peter Wu Date: Sun, 18 Apr 2021 17:25:32 +0200 Subject: ssh-tcpdump: do not use sudo if already run as root sudo might be unavailable on the target, do not bother when root. --- extcap/ssh-tcpdump | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/extcap/ssh-tcpdump b/extcap/ssh-tcpdump index 02fcca6..d04b5e0 100755 --- a/extcap/ssh-tcpdump +++ b/extcap/ssh-tcpdump @@ -22,6 +22,7 @@ parser.add_argument('--extcap-interfaces', action='store_true') parser.add_argument('--extcap-dlts', action='store_true') parser.add_argument('--extcap-config', action='store_true') parser.add_argument('--capture', action='store_true') +parser.add_argument('--extcap-version') parser.add_argument('--extcap-interface', metavar='IFACE') @@ -72,13 +73,14 @@ def extcap_capture(iface, cfilter, outfile): else: ssh_user = os.getenv('USER') tcpdump_args = [ - "sudo", "tcpdump", "-i", iface, "-p", "-U", "-w", "-", ] + if ssh_user != 'root': + tcpdump_args = ["sudo"] + tcpdump_args # Change to a less-privileged user if ssh_user: tcpdump_args += ["-Z", ssh_user] -- cgit v1.2.1