diff options
| author | Anders Broman <anders.broman@ericsson.com> | 2012-10-09 15:00:39 +0000 |
|---|---|---|
| committer | Anders Broman <anders.broman@ericsson.com> | 2012-10-09 15:00:39 +0000 |
| commit | cba1bb82788541b981879a40237619dfb6f34f5d (patch) | |
| tree | 030976d8c1eabf07c08d3c51f54168a4a644cfae | |
| parent | f0472792e29eaf47947e3b4b4a9b89f573fc8dad (diff) | |
| download | wireshark-cba1bb82788541b981879a40237619dfb6f34f5d.tar.gz | |
As ths SDP dissector adds /SDP to the protocol column I think that
col_append_str(pinfo->cinfo, COL_INFO, ", with session description"); is redundant if some one has a different opinion fel free to revert.
svn path=/trunk/; revision=45428
| -rw-r--r-- | epan/dissectors/packet-sdp.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/epan/dissectors/packet-sdp.c b/epan/dissectors/packet-sdp.c index c08c803b13..ca3b739f8f 100644 --- a/epan/dissectors/packet-sdp.c +++ b/epan/dissectors/packet-sdp.c @@ -356,8 +356,12 @@ dissect_sdp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree) */ col_append_str(pinfo->cinfo, COL_PROTOCOL, "/SDP"); - /* XXX: Needs description. */ - col_append_str(pinfo->cinfo, COL_INFO, ", with session description"); + /* XXX: Needs description. + * Putting with session description in info col is redundant when it's in the + * protocol col in my opinion, commenting it out for now 2012-10-09. Remove if no one complains. + * If some one want it consider " ,with SDP" + */ + /*col_append_str(pinfo->cinfo, COL_INFO, ", with session description");*/ ti = proto_tree_add_item(tree, proto_sdp, tvb, offset, -1, ENC_NA); sdp_tree = proto_item_add_subtree(ti, ett_sdp); |