diff options
| author | Anish Bhatt <anish@chelsio.com> | 2015-01-05 22:50:44 -0800 |
|---|---|---|
| committer | Pascal Quantin <pascal.quantin@gmail.com> | 2015-01-07 10:41:06 +0000 |
| commit | 9b54fc9bd23ec8e0a66d7b1e4b09930c2cfbfa7e (patch) | |
| tree | d113b752f655e8caf0c55b87c70167f37fd639a6 | |
| parent | 29e1f73b9421d022395badfd7021d07f3022a607 (diff) | |
| download | wireshark-9b54fc9bd23ec8e0a66d7b1e4b09930c2cfbfa7e.tar.gz | |
[PROFINET] v2: Fix swapped MaintenanceRequired & MaintenanceDemanded bits
Fix the correct code path this time.
Bug: 10753
Change-Id: I7bc2e74c91868986303e8b41b25e43a665be1860
Reviewed-on: https://code.wireshark.org/review/6335
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
(cherry picked from commit 124272ec097852c0c0efa587cb1cb1bf8047ff73)
Reviewed-on: https://code.wireshark.org/review/6362
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
| -rw-r--r-- | plugins/profinet/packet-dcerpc-pn-io.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/plugins/profinet/packet-dcerpc-pn-io.c b/plugins/profinet/packet-dcerpc-pn-io.c index 292c4cd3ba..b802bd0d93 100644 --- a/plugins/profinet/packet-dcerpc-pn-io.c +++ b/plugins/profinet/packet-dcerpc-pn-io.c @@ -2245,10 +2245,13 @@ static const value_string pn_io_channel_properties_accumulative_vals[] = { { 0, NULL } }; +/* We are reading this as a two bit value, but the spec specifies each bit + * separately. Beware endianness when reading spec + */ static const value_string pn_io_channel_properties_maintenance[] = { { 0x0000, "Failure" }, - { 0x0001, "Maintenance demanded" }, - { 0x0002, "Maintenance required" }, + { 0x0001, "Maintenance required" }, + { 0x0002, "Maintenance demanded" }, { 0x0003, "see QualifiedChannelQualifier" }, { 0, NULL } }; |