diff options
| author | dsrsupport <eugene.exarevsky@dsr-company.com> | 2017-01-26 13:09:54 +0300 |
|---|---|---|
| committer | Anders Broman <a.broman58@gmail.com> | 2017-01-26 19:31:56 +0000 |
| commit | ffea2f8a24947a9293e3d4986440edf5e4589685 (patch) | |
| tree | 1a7053627a6fcd51be52520fd23a6289502f5220 | |
| parent | d66ee141af70df7809ef9f48d19f75469f64a0b4 (diff) | |
| download | wireshark-ffea2f8a24947a9293e3d4986440edf5e4589685.tar.gz | |
ZigBee: fix endian for File Version field in OTA
That field parsed as Big Endian, while all data in ZigBee is Little Endian.
Not change to LE.
Change-Id: I782ba5d17ca9f2208dc4e2f08ca2c731f4d683e4
Reviewed-on: https://code.wireshark.org/review/19800
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
| -rw-r--r-- | epan/dissectors/packet-zbee-zcl-general.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/epan/dissectors/packet-zbee-zcl-general.c b/epan/dissectors/packet-zbee-zcl-general.c index 34ba7733c4..ba0d96adc4 100644 --- a/epan/dissectors/packet-zbee-zcl-general.c +++ b/epan/dissectors/packet-zbee-zcl-general.c @@ -9384,7 +9384,12 @@ dissect_zcl_ota_file_version_field(tvbuff_t *tvb, proto_tree *tree, guint *offse }; /* 'File Version' field present, retrieves it */ - proto_tree_add_bitmask(tree, tvb, *offset, hf_zbee_zcl_ota_file_version, ett_zbee_zcl_ota_file_version, file_version, ENC_BIG_ENDIAN); + /* File version is Little endian. as well as all ZigBee data structures: + "The endianness used in each data field shall be little endian in order + to be compliant with general ZigBee messages." + File version A: 0x10053519 represents application release 1.0 build 05 with stack release 3.5 b19 + */ + proto_tree_add_bitmask(tree, tvb, *offset, hf_zbee_zcl_ota_file_version, ett_zbee_zcl_ota_file_version, file_version, ENC_LITTLE_ENDIAN); *offset += 4; } /*dissect_zcl_ota_file_version_field*/ |