diff options
| author | Guy Harris <guy@alum.mit.edu> | 2013-02-20 00:56:44 +0000 |
|---|---|---|
| committer | Guy Harris <guy@alum.mit.edu> | 2013-02-20 00:56:44 +0000 |
| commit | 0aef9fc00d5a4abfb9e2e44e757a9c037f9da2f9 (patch) | |
| tree | a5308bab068c9db6dd2863acf3d290396198e698 /epan | |
| parent | 552e98b7a39043d06ae98631878773bd736a90bd (diff) | |
| download | wireshark-0aef9fc00d5a4abfb9e2e44e757a9c037f9da2f9.tar.gz | |
Improve a comment - what matters is that tvb_new_real_data() can throw
an exception, not how it happens to be implemented currently.
svn path=/trunk/; revision=47755
Diffstat (limited to 'epan')
| -rw-r--r-- | epan/dissectors/packet-giop.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/epan/dissectors/packet-giop.c b/epan/dissectors/packet-giop.c index 554b75250f..3520417ff9 100644 --- a/epan/dissectors/packet-giop.c +++ b/epan/dissectors/packet-giop.c @@ -1525,10 +1525,7 @@ static void read_IOR_strings_from_file(const gchar *name, int max_iorlen) { if(ior_val_len>0) { - /* Combination of tvb_new() and tvb_set_real_data(). - Can throw ReportedBoundsError. - - XXX - can it throw an exception in this case? If so, we + /* XXX - can this throw an exception in this case? If so, we need to catch it and clean up, but we really shouldn't allow it - or "get_CDR_octet()", or "decode_IOR()" - to throw an exception. */ |