changes of the coloring rules sometimes crashed as dissection keeps pointers to the color_filter for later reference -> simply deleting the filters leave the pointers invalid -> crash.

for now, don't delete the filters but keep them floating around in memory (leaking) -> at least better than crashing

svn path=/trunk/; revision=19421

1 files changed, 0 insertions, 10 deletions

diff --git a/file.c b/file.c
index 8007e848f8..4bf10ccb53 100644
--- a/file.c
+++ b/file.c
@@ -3068,16 +3068,6 @@ cf_select_packet(capture_file *cf, int row)
   /* We don't need the columns here. */
   cf->edt = epan_dissect_new(TRUE, TRUE);
 
-  /* colorize packet: coloring rules might be changed (removed) since last run,
-     recalculate now.
-     if packet is marked, use preferences, otherwise try to apply color filters */
-  if (fdata->flags.marked) {
-      fdata->color_filter = NULL;
-      packet_list_set_colors(row, &prefs.gui_marked_fg, &prefs.gui_marked_bg);
-  } else {
-      fdata->color_filter = color_filters_colorize_packet(row, cf->edt);
-  }
-
   epan_dissect_run(cf->edt, &cf->pseudo_header, cf->pd, cf->current_frame,
           NULL);