diff options
author | Peter Wu <peter@lekensteyn.nl> | 2015-11-27 17:57:34 +0100 |
---|---|---|
committer | Alexis La Goutte <alexis.lagoutte@gmail.com> | 2015-11-27 21:15:27 +0000 |
commit | 916ee53557ff9e16e5fad9ff197e711a26d53e6f (patch) | |
tree | f91da30392012db6aeb341d177cd68b52c64fc15 /file.h | |
parent | 7d6373ee22ef01c1860a9c1f3fab5c02de53de0e (diff) | |
download | wireshark-916ee53557ff9e16e5fad9ff197e711a26d53e6f.tar.gz |
Fix crash in UDP Multicast Streams dialog
Attempting to open the UDP Multicast Streams dialog in the GTK UI
triggers an instant crash (heap-buffer-overflow).
Déjà vu. This is the same problem that plagued the RTP Streams dialog.
This patch is based on the fix in v1.99.3rc0-33-g2c65b33
(mcaststream_dlg_update confused GList vs. mcaststream_tapinfo_t).
After fixing that, the dialog crashed shortly after setting parameters
(heap-use-after-free). That fix is based on v1.99.10rc0-292-gb02a0ee
(after a retap, the old items were still present in the list).
Just that change was not enough as clearing the list still triggered a
signal, possibly because of the "changed" signal (while the RTP player
uses a selection setter function). Apply the patch based on
v1.99.10rc0-270-g01bd832 (disable selection while clearing).
Change-Id: I152bac6f954d8d1c5c20d6c7d56a196c3e20c681
Reviewed-on: https://code.wireshark.org/review/12227
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
(cherry picked from commit d7f12436709e40d58d7fcdfbcdd08740c039e162)
Reviewed-on: https://code.wireshark.org/review/12231
Diffstat (limited to 'file.h')
0 files changed, 0 insertions, 0 deletions