diff options
| author | Guy Harris <guy@alum.mit.edu> | 2012-07-19 04:16:15 +0000 |
|---|---|---|
| committer | Guy Harris <guy@alum.mit.edu> | 2012-07-19 04:16:15 +0000 |
| commit | 66ed910844d9d2da3b6b46d67c2e27f19322a7dd (patch) | |
| tree | 77e845e29a06a9b9e5620afea1599cb847af3cd6 /tools | |
| parent | defeb589d62455dea877659de9d42294c914d3f7 (diff) | |
| download | wireshark-66ed910844d9d2da3b6b46d67c2e27f19322a7dd.tar.gz | |
Yup, that did it. Make use of ENC_ values in non-item proto_tree_add
calls an error.
Fix one case where we weren't counting an error (unregistered ett
variables).
svn path=/trunk/; revision=43817
Diffstat (limited to 'tools')
| -rwxr-xr-x | tools/checkAPIs.pl | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/tools/checkAPIs.pl b/tools/checkAPIs.pl index 95c53256ce..debf364984 100755 --- a/tools/checkAPIs.pl +++ b/tools/checkAPIs.pl @@ -1431,7 +1431,8 @@ sub check_proto_tree_add_XXX_encoding($$) if ($args =~ /,\s*ENC_/xos) { if (!($func =~ /proto_tree_add_(item|bitmask|bits_item|bits_ret_val)/xos) ) { - print STDERR "Warning: ".$filename." uses $func with ENC_*.\n"; + print STDERR "Error: ".$filename." uses $func with ENC_*.\n"; + $errorCount++; # Print out the function args to make it easier # to find the offending code. But first make @@ -1538,6 +1539,7 @@ sub check_ett_registration($$) if (@unRegisteredEtts) { print STDERR "Error: found these unregistered ett variables in ".$filename.": ".join(',', @unRegisteredEtts)."\n"; + $errorCount++; } } |