summaryrefslogtreecommitdiff
path: root/ui/cli/tap-expert.c
diff options
context:
space:
mode:
authorGerald Combs <gerald@zing.org>2015-08-02 15:33:07 -0700
committerGerald Combs <gerald@wireshark.org>2015-08-03 03:06:00 +0000
commit9557c73f81efad68ce3961a5ec18de2d985c4bb1 (patch)
tree528dab6173e9f59072f3b90d2d5c2fbdaf470023 /ui/cli/tap-expert.c
parent08e80b1653383fcbb42538b97e46e78d152b4893 (diff)
downloadwireshark-9557c73f81efad68ce3961a5ec18de2d985c4bb1.tar.gz
Make sure per-packet tap callbacks return gbooleans.
The tap API changed the return type of per-packet listener callbacks from int to gboolean back in 2009. Update a bunch of functions and some documentation accordingly. Change-Id: I79affe65db975caed3cc296a7e2985b7b9cdf4cc Reviewed-on: https://code.wireshark.org/review/9853 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
Diffstat (limited to 'ui/cli/tap-expert.c')
-rw-r--r--ui/cli/tap-expert.c10
1 files changed, 5 insertions, 5 deletions
diff --git a/ui/cli/tap-expert.c b/ui/cli/tap-expert.c
index b16c3a9b4a..07fdfb5f6c 100644
--- a/ui/cli/tap-expert.c
+++ b/ui/cli/tap-expert.c
@@ -81,7 +81,7 @@ expert_stat_reset(void *tapdata)
}
/* Process stat struct for an expert frame */
-static int
+static gboolean
expert_stat_packet(void *tapdata, packet_info *pinfo _U_, epan_dissect_t *edt _U_,
const void *pointer)
{
@@ -107,12 +107,12 @@ expert_stat_packet(void *tapdata, packet_info *pinfo _U_, epan_dissect_t *edt _U
break;
default:
g_assert_not_reached();
- return 0;
+ return FALSE;
}
/* Don't store details at a lesser severity than we are interested in */
if (severity_level < lowest_report_level) {
- return 1;
+ return TRUE;
}
/* If a duplicate just bump up frequency.
@@ -122,7 +122,7 @@ expert_stat_packet(void *tapdata, packet_info *pinfo _U_, epan_dissect_t *edt _U
if ((strcmp(ei->protocol, entry->protocol) == 0) &&
(strcmp(ei->summary, entry->summary) == 0)) {
entry->frequency++;
- return 1;
+ return TRUE;
}
}
@@ -136,7 +136,7 @@ expert_stat_packet(void *tapdata, packet_info *pinfo _U_, epan_dissect_t *edt _U
/* Store a copy of the expert entry */
g_array_append_val(data->ei_array[severity_level], tmp_entry);
- return 1;
+ return TRUE;
}
/* Output for all of the items of one severity */