diff options
| author | Guy Harris <guy@alum.mit.edu> | 2015-01-13 13:00:59 -0800 |
|---|---|---|
| committer | Guy Harris <guy@alum.mit.edu> | 2015-01-13 21:01:28 +0000 |
| commit | 9f5e4fb7a51741a286ce5bc92a6f335ed58587a2 (patch) | |
| tree | 3e2a2634f036dc891270ee59f488b5a66386d285 /ui/qt/sctp_chunk_statistics_dialog.cpp | |
| parent | 25f010b2696ccccab44545971f43784946b23ba8 (diff) | |
| download | wireshark-9f5e4fb7a51741a286ce5bc92a6f335ed58587a2.tar.gz | |
uat_load() and uat_save() return a success indication; use it.
Instead of always ignoring the return value, always check it, and only
report an error if it returns FALSE.
(Alternative: have it return NULL on success and a pointer to a
g_malloc()ed string on failure.)
Fix a comment while we're at it.
Change-Id: Icb72c9f47775b6552e3eb4fe5ddcc85482bfb5fb
Reviewed-on: https://code.wireshark.org/review/6528
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Diffstat (limited to 'ui/qt/sctp_chunk_statistics_dialog.cpp')
| -rw-r--r-- | ui/qt/sctp_chunk_statistics_dialog.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/ui/qt/sctp_chunk_statistics_dialog.cpp b/ui/qt/sctp_chunk_statistics_dialog.cpp index 216840668e..d5e2422eaf 100644 --- a/ui/qt/sctp_chunk_statistics_dialog.cpp +++ b/ui/qt/sctp_chunk_statistics_dialog.cpp @@ -1,4 +1,4 @@ -/* sctp_chunck_statistics_dialog.cpp +/* sctp_chunk_statistics_dialog.cpp * * Wireshark - Network traffic analyzer * By Gerald Combs <gerald@wireshark.org> @@ -279,8 +279,8 @@ void SCTPChunkStatisticsDialog::on_actionChunkTypePreferences_triggered() uat_t *uat = pref->varp.uat; uat_clear(uat); - uat_load(pref->varp.uat, &err); - if (err) { + if (!uat_load(pref->varp.uat, &err)) { + /* XXX - report this through the GUI */ printf("Error loading table '%s': %s",pref->varp.uat->name,err); g_free(err); } |