summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2014-12-23[column utils] fix warning: unknown command tag name ↵Alexis La Goutte1-1/+1
[-Wdocumentation-unknown-command] Change-Id: I5a14875b4b61ae7635095bdf9f2ab18dd9dbfc09 Reviewed-on: https://code.wireshark.org/review/6012 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-12-23DOCSIS: missing break in switch (CID 280485 & 280486)Alexis La Goutte2-0/+2
Change-Id: I5b756b96ca6c3c48a43948d456bfcb07aab527fd Reviewed-on: https://code.wireshark.org/review/5994 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-12-23Qt (emitAppSignal): Missing break in switch (CID 1159204)Alexis La Goutte1-0/+1
Change-Id: Ia2ba40a4fc284dbf3da8e27edf336a4e27cdb4e3 Reviewed-on: https://code.wireshark.org/review/6000 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-12-23Restore stdlib.h (should not have been deleted - mispelt in script)Martin Mathieson1-0/+1
Change-Id: I43387489ed29beff5a523e78cabcfb9e3ea8a182 Reviewed-on: https://code.wireshark.org/review/6015 Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2014-12-23epan/llcsaps.h was needed, so restore includeMartin Mathieson1-0/+1
Change-Id: I443db244bde04af9397bcb5bfa3a1888b0560bf0 Reviewed-on: https://code.wireshark.org/review/6014 Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2014-12-23Deleting unneccessary #includes from dissectors.Martin Mathieson72-129/+0
Second batch (packet-eth.c -> packet-icmpv6.d). Will look at cleaning up and committing script afterwards. Change-Id: I14295758b81a59115d8c88899f166cc3d5d17594 Reviewed-on: https://code.wireshark.org/review/6013 Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2014-12-23RTPS: Missing break in switch (CID 996922)Alexis La Goutte1-1/+1
Change-Id: I2b8a12d54414a1b2d878285b8c840de9586fcb5e Reviewed-on: https://code.wireshark.org/review/5992 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-12-23NetScaler Trace: Missing break in switch (CID 281457, 727776 & 1021060)Alexis La Goutte1-1/+3
Change-Id: I575114ba364da1b1d63eea8fc7b48c8c0e0bc99d Reviewed-on: https://code.wireshark.org/review/5991 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-12-23NASDAQ ITCH: Missing break in switch (CID 280465)Alexis La Goutte1-0/+1
Change-Id: I0f3ef7a39d9659b14ff472d2d3e59565db43ec3e Reviewed-on: https://code.wireshark.org/review/5990 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-12-23ISNS: Missing break in switch (CID 280460)Alexis La Goutte1-0/+1
Change-Id: Iaaa56e17e49cd42e18e55e316c691a22bbbdf8f1 Reviewed-on: https://code.wireshark.org/review/5989 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-12-23RSVP: RECORD_ROUTE IPv4 Subobject Flags field incorrect decodingAlexis La Goutte1-3/+3
The Flags field within RSVP RECORD_ROUTE IPv4_Subobject is decoded incorrectly. Wireshark thinks that 0x10 bit represents Node-ID, but actually the Node-ID is encoded by bit 0x20 (per RFC 4561) Issue reported by Alexander Okonnikov Bug:10799 Change-Id: I48f6aa35c08945aacf8f2bb871a72b5927511948 Reviewed-on: https://code.wireshark.org/review/5944 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-12-23NDPS: Missing break in switch (CID 281286)Alexis La Goutte1-0/+1
Change-Id: I2363370249d7beb2ed8a29987ac2cb602979d0a3 Reviewed-on: https://code.wireshark.org/review/5988 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-12-23test suite: fix indent (use tabs) and add modelinesAlexis La Goutte3-50/+61
Change-Id: I648d02d41f92c7fd176ce194eee20a2d19643fe0 Reviewed-on: https://code.wireshark.org/review/5985 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-12-23Makefile (epan/dissectors): fix indent (use tabs)Alexis La Goutte1-1/+1
Change-Id: I72d2dbc05f7cfbd7adf05ed66be81946942cef3b Reviewed-on: https://code.wireshark.org/review/5984 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-12-23CMake (epan/CMakeList.txt): fix indent (use tabs)Alexis La Goutte1-72/+72
Change-Id: I40e05f1e4430eadc480134cd62dd01f978353b67 Reviewed-on: https://code.wireshark.org/review/5983 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-12-23UseLemon (CMake): Fix indent (use space)Alexis La Goutte1-1/+1
Change-Id: I619d64d62d2fb96ab904d5ea15e3c37aa0319540 Reviewed-on: https://code.wireshark.org/review/5982 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-12-23kerberos: Re-add needed #include <stdio.h>Bill Meier2-6/+10
Change-Id: I85c0e5f022b5c04df6079e118e376e8d598675aa Reviewed-on: https://code.wireshark.org/review/6011 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-12-23asn1 generated dissectors: cleanup #include usageBill Meier198-1143/+745
Change-Id: I36b2731d67f9345d2fd0c23800bba7d2be94c387 Reviewed-on: https://code.wireshark.org/review/6008 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-12-23asn1/Makefile.nmake: packet-c1222.c not autogenerated using Windows nmakeBill Meier1-4/+5
Change-Id: I21628bdd1a08348629350a373f1c20e02c3618f7 Reviewed-on: https://code.wireshark.org/review/6007 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-12-23Cmake: check for popcount, and build it from wsutil/popcount.c if missing.Guy Harris3-0/+11
Change-Id: Id646a9f0b1fc6acafa99a78725e3f0ec8a48c170 Reviewed-on: https://code.wireshark.org/review/6006 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-12-23Try to fix Windows build for popcount() unresolved external symbolStephen Fisher1-0/+1
Change-Id: Ie154caa1967ce4016dd52eefcf757e2e58d7ac68 Reviewed-on: https://code.wireshark.org/review/6005 Reviewed-by: Stephen Fisher <sfisher@sdf.org>
2014-12-23packet-dtls.c still needs conversation.hStephen Fisher1-0/+1
Change-Id: I1e6a55c41cbab74790880da2b3691cd7d82bc276 Reviewed-on: https://code.wireshark.org/review/6004 Reviewed-by: Stephen Fisher <sfisher@sdf.org>
2014-12-23Move popcount() to an optionally built part of wsutil for systems thatStephen Fisher5-15/+89
provide their own popcount(). Change-Id: Ic26f3b50cf0bd2b4af0d42e9c27488ebbac1ab33 Reviewed-on: https://code.wireshark.org/review/5998 Petri-Dish: Stephen Fisher <sfisher@sdf.org> Reviewed-by: Stephen Fisher <sfisher@sdf.org>
2014-12-22Include <math.h> or <stdlib.h> as necessary to declare functions.Guy Harris1-0/+1
Various floating-point math functions require <math.h>, and abs() requires <stdlib.h>. Change-Id: I6831cfdb17eac3ce129b6800f0fe82fbcfef2d28 Reviewed-on: https://code.wireshark.org/review/6002 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-12-22Include <math.h> or <stdlib.h> as necessary to declare functions.Guy Harris4-1/+4
Various floating-point math functions require <math.h>, and abs() requires <stdlib.h>. Change-Id: Iadba9e0d7168bba6e67d9221e757a85960507742 Reviewed-on: https://code.wireshark.org/review/5999 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-12-22First batch of unincludes. Last attempt...Martin Mathieson112-167/+0
Change-Id: I3681462aeb98ca62ed3ec5eb226b2553317391a9 Reviewed-on: https://code.wireshark.org/review/5997 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2014-12-22Cast a parameter in the kerberos dissector so it compiles withoutStephen Fisher2-2/+2
warnings on NetBSD. Change-Id: Id1ab5020fa53656065b0b2438071342eae4f7adb Reviewed-on: https://code.wireshark.org/review/5987 Petri-Dish: Stephen Fisher <sfisher@sdf.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stephen Fisher <sfisher@sdf.org>
2014-12-22Qt: Add methods to CaptureFile and WiresharkApplication.Gerald Combs11-87/+137
Add isValid, fileTitle, and retapPackets methods to CaptureFile. Add application name and title separator convenience methods to WiresharkApplication. Convert traffic tables, conversations, and endpoints to use CaptureFile directly and to let the user know when the capture file is closed. Set the file dialog titles while we're here. Change-Id: I990392786d3833e1e0b3638aa2d34a5ada39fa13 Reviewed-on: https://code.wireshark.org/review/5957 Petri-Dish: Gerald Combs <gerald@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-12-22Revert "Move packet-kerberos.c to the dirty dissectors because it generates ↵Alexis La Goutte1-1/+1
warnings (at least on NetBSD), presumably due to our use of -Wc++-compat:" This reverts commit d4ff430b4dc5cf0e3efaabd2ef53778070def558. Change-Id: Icb0907e649555237b4a86f9f651ec4df8d79d99b Reviewed-on: https://code.wireshark.org/review/5975 Reviewed-by: Stephen Fisher <sfisher@sdf.org>
2014-12-22packet-couchbase.c: remove field which does not existsSergey Avseyev1-2/+0
Change-Id: Ia4a2a6127edbb6a92becf22cd6ee689e5e2a7966 Reviewed-on: https://code.wireshark.org/review/5981 Reviewed-by: Sergey Avseyev <sergey.avseyev@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-12-22Fix unknown command tag name [-Wdocumentation-unknown-command]Alexis La Goutte11-17/+16
Change-Id: I6c2564a86e13d9321001856ba1f51681a9f20976 Reviewed-on: https://code.wireshark.org/review/5979 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-12-22fix warning: parameter 'list' not found in the function declaration ↵Alexis La Goutte1-1/+0
[-Wdocumentation] Change-Id: Id6d02f5c1383dd8f231707f519ec1b28fb007079 Reviewed-on: https://code.wireshark.org/review/5978 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-12-22ANSI MAP: Remove from Dirty ASN1 listAlexis La Goutte2-2/+2
Change-Id: I192c447919ee9c3f430f058c2e5285501af962bf Reviewed-on: https://code.wireshark.org/review/5977 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-12-22ANSI_MAP: Fix unused function (by add to .OMIT list)Alexis La Goutte2-236/+48
Change-Id: I4e2278d563659db6acc6c02b9e66d58c67939e30 warning: unused function 'dissect_ansi_map_InvokeData' [-Wunused-function] warning: unused function 'dissect_ansi_map_ReturnData' [-Wunused-function] Reviewed-on: https://code.wireshark.org/review/5976 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-12-22PTP: Fix ptp_tree may be used uninitialized in this function ↵Alexis La Goutte1-1/+1
[-Werror=maybe-uninitialized] Change-Id: I0b82782deb568256dafd4c1bf163fd3e74f95545 Reviewed-on: https://code.wireshark.org/review/5974 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-12-22remove unnecessary integer overflow checksMartin Kaiser1-23/+4
... and don't call THROW() from a dissector If we have a guint32 a and interpret 2*a as gint, we'll always end up with a negative value if 2*a overflows. Both tvb_get_string_enc() and proto_tree_add_item() handle this case and throw an exception. Change-Id: Ibb142328837b6a583057531c76d08631fc731848 Reviewed-on: https://code.wireshark.org/review/5948 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-12-22Fix The left operand of '!=' is a garbage value issue found by Clang AnalyzerAlexis La Goutte2-2/+2
Change-Id: Ia555fc8eca2a7288c159983578cbc88dc0bebbc2 Reviewed-on: https://code.wireshark.org/review/5952 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-12-22Fix AARP AppleTalk address parsingDoug Brown1-2/+2
AppleTalk addresses are 3 bytes long and stored in AARP packets as 4 bytes. The high byte should be 0, followed by 2-byte network number, followed by 1-byte node number. The previous code was assuming that the high two bytes were the network number, followed by the 1-byte node number, followed by 0. Change-Id: I467ec6edac353796db0b96fbac65658d5c5491d3 Reviewed-on: https://code.wireshark.org/review/5968 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-12-22Squelch a compiler warning.Guy Harris1-1/+1
("Can't happen", but that requires more dataflow analysis than some compilers do.) Change-Id: I5c6acbff64ea88f9b43d5580522bc144465dc9ac Reviewed-on: https://code.wireshark.org/review/5972 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-12-22plugins: Cleanup #includesBill Meier75-122/+30
Change-Id: Ic839f2995532d68308f8b5908c185acc7acaaa9c Mostly: remove '#include <glib/glib.h>' and certain other #includes already included in packet.h Reviewed-on: https://code.wireshark.org/review/5971 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-12-22stats_tree: g_sprintf()-->g_snprintf(); cleanup #includes.Bill Meier1-6/+5
Change-Id: I862fed818cd1f14584b082f87b1d4d305cf78687 Reviewed-on: https://code.wireshark.org/review/5970 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-12-22print.c: clean up #includesBill Meier1-9/+4
Change-Id: I0ecf618cc79060d35b5480f3d8e7ebf8575761c4 Reviewed-on: https://code.wireshark.org/review/5969 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-12-22Use the messageLength field to indicate the message length.Guy Harris1-4/+42
Check it for sanity (and report errors), and use it to set the length of the PTP packet tvbuff and the PTP top-level protocol item. Bug: 10611 Change-Id: I9af6aad5f07d405ebb14885dc986a73e430d7bdb Reviewed-on: https://code.wireshark.org/review/5967 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-12-22BGP : Update BGP-LS Attribute + Display NEXT_HOPEbben Aries1-4/+9
From IANA page: http://www.iana.org/assignments/bgp-parameters/bgp-parameters.xhtml Change-Id: Ibc85dccee94aa69306c88b48d680e48fede08f2e Reviewed-on: https://code.wireshark.org/review/5965 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-12-22Removing ptp.v2.an.fcs as this erroneously refers to the Ethernet FCS which ↵sfd1-14/+0
is properly handled by the Ethernet dissector. Bug: 10611 Change-Id: I735085edf5c0d2a66c30c940c4b780a2ce8db6d4 Reviewed-on: https://code.wireshark.org/review/5964 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-12-22Qt: Fix status bar signal.Gerald Combs2-2/+2
Change-Id: Ie935269f6cbe9495b95bcc24b45198fbd284fb35 Reviewed-on: https://code.wireshark.org/review/5963 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-12-22Wrong array.Guy Harris1-1/+1
Change-Id: I69ceca8be624b13f910997dee3bc6852b61b0162 Reviewed-on: https://code.wireshark.org/review/5962 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-12-22Improve the message for "this field has an integral type" assertions.Guy Harris2-3/+12
(Along the lines of provious changes.) Change-Id: I22d76f22400d4a93242392ff4688acc753eb0039 Reviewed-on: https://code.wireshark.org/review/5961 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-12-21Register the ORFEntry IP address as an IPv4 address.Guy Harris1-1/+1
We're adding it with proto_tree_add_ipv4(), so that it's displayed as, and can be tested as, an IPv4 address. That means that the field for it must be of type FT_IPv4, *even though it's calculated from an 8-bit prefix value* - you can't make it an FT_UINT8. Change-Id: I7d668fb2a707cdda4ad228afcbdcaf47ee6cba1b Reviewed-on: https://code.wireshark.org/review/5960 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-12-21Improve the message for "this field doesn't have the right type" assertions.Guy Harris2-28/+68
Give the field name in the message. Change-Id: I046c74b451b473c9c87c2980122b025390f82cc8 Reviewed-on: https://code.wireshark.org/review/5959 Reviewed-by: Guy Harris <guy@alum.mit.edu>
generated by cgit v1.2.1 (git 2.18.0) at 2024-07-12 17:23:06 +0000