summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2016-12-14extcap: set help for interfaces.Dario Lombardo1-0/+3
The help statement is in the first sentence, while interfaces are in others. We need to keep state of it. Ping-Bug: 13218 Change-Id: Iad1d403d5e8bc34e2489daaa3b14d469d5ee5b5b Reviewed-on: https://code.wireshark.org/review/19148 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com>
2016-12-14README.extcap: impagination improvement.Dario Lombardo1-32/+40
Change-Id: I1cc0dc6496bea8e42c199dff116530ccec6fb591 Reviewed-on: https://code.wireshark.org/review/19089 Reviewed-by: Roland Knall <rknall@gmail.com>
2016-12-14RTP Stream Analysis: save Audio allows any filename extensionJiri Novak1-4/+8
Format of file selected by user is derived from save dialog format selection, not from filename as before. Bug: 13240 Change-Id: Id6e159d97e4f26c25b3d2d98d43041d8617cc737 Reviewed-on: https://code.wireshark.org/review/19240 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-12-14RTP Stream Analysis dialog: dialog shows when forward/reverse stream startsJiri Novak3-1/+15
Dialog shows time (relative to capture start) and packet number when forward and reverse stream starts. It shows difference in such values on bottom of dialog too. Bug: 13239 Change-Id: If807b8a56723df17ed131b1aac053cf8f985bb7b Reviewed-on: https://code.wireshark.org/review/19239 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-12-14Remove add_item_textMichael Mann2-112/+53
It's a manual attempt at what proto_tree_add_bitmask can do anyway. Change-Id: If551e8afa346a33b8e15dc441aae75ba0752ab46 Reviewed-on: https://code.wireshark.org/review/19257 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-12-14packet-lsc.c: Use proto_tree_add_item instead of manually fetching field values.Michael Mann1-37/+21
Change-Id: I60740615de02bc5047eaca618973064513ac7b56 Reviewed-on: https://code.wireshark.org/review/19256 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-12-14packet-kerberos4.c: Use encodings instead of boolean little vs big endian.Michael Mann1-17/+16
Also use proto_tree_add_item_ret_length for string handling. Change-Id: Id1eae2e51460a3b7f4c3385b9b1fd7f12398a227 Reviewed-on: https://code.wireshark.org/review/19255 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-12-14packet-nbt.c: General cleanupMichael Mann1-146/+54
1. Remove functionality that was replaced by a proto_tree_add_bitmask 2. Remove use of nbdgm_header structure which is just a useless placeholder 3. Remove some if (tree) over single fields. Change-Id: I0879043685686eb5b861cf77ec38bbf25ed6044e Reviewed-on: https://code.wireshark.org/review/19254 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-12-14file-jpeg.c - Pacify pre-commit hooks by removing macroMichael Mann1-55/+53
IMG_JFIF was trying to be a macro for all display and expert info filters. This messed with the pre-commit scripts ability to ensure protocol filter name was being used as the prefix for display and expert info filters. So replaced IMG_JFIF with the proper prefix - "image-jfif" Change-Id: I1fe3dc8797529c9d17f75c511bc279824e7e69b0 Reviewed-on: https://code.wireshark.org/review/19253 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-12-14cmake: add semicolon to file list.Dario Lombardo1-1/+1
The file list contains semicolon-separated list of files to check. When merging the lists we need to separate them properly. Error: No such file: "packet-ncp2222.cpacket-coseventcomm.c" at wireshark/tools/checkAPIs.pl line 2050. Change-Id: I19702ab85408caf69ed922732fce74c3058be640 Reviewed-on: https://code.wireshark.org/review/19237 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-12-13Adjust proto_tree_add_uint_format_value calls to use unit stringMichael Mann70-628/+439
Several calls to proto_tree_add_uint_format_value could be better served using BASE_UNIT_STRING with a "unit string" in hf_ field. There also a few cases where proto_tree_add_uint_format_value could just be proto_tree_add_uint. Added a few more "common" unit string values to unit_strings.[ch] Change-Id: Iaedff82c515269c9c31ab9100dff19f5563c932d Reviewed-on: https://code.wireshark.org/review/19242 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-12-13Adjust proto_tree_add_[float|double]_format_value calls to use unit stringMichael Mann10-49/+61
Several calls to proto_tree_add_[float|double]_xxx could be better served using BASE_UNIT_STRING with a "unit string" in hf_ field. Added a few more "common" unit string values to unit_strings.[ch] Change-Id: Id0da7b579403898d20c2667d6c4abcd59d5a48d4 Reviewed-on: https://code.wireshark.org/review/19241 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-12-13Qt: Optionally restore our selected packet when thawing.Gerald Combs3-7/+31
Stash the current row when we freeze the packet list. Make it possible to restore it when thawing. Do so when the layout changes and when we move a column. Change-Id: I44cfb8bafcd4d49a46e1c89bf47aecf5ac139773 Reviewed-on: https://code.wireshark.org/review/19222 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-12-13win-setup.ps1: add missing zlib-1.2.8-ws folderPascal Quantin1-0/+1
Change-Id: Ie32a231146365c11fe80e9e4f414ef7c464a8249 Reviewed-on: https://code.wireshark.org/review/19247 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-12-13imf: fix no newline at end of file [-Wnewline-eof]Alexis La Goutte1-1/+1
Change-Id: Ibddfbb049fdf8510ffc14fbadba7484300821888 Reviewed-on: https://code.wireshark.org/review/19236 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-12-13rtp_analysis_dialog.cpp: RTP Stream Analysis dialog shows same SSRC for ↵Jiri Novak1-1/+1
forward and reverse stream Same SSRC is shown because of typo in variable name for reverse stream. Bug: 13236 Change-Id: Idcba4d83c7b4358cd8ebf1ee5c5b5bde2fc2e48b Reviewed-on: https://code.wireshark.org/review/19238 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-12-13Add support for adding unit names to hf_ fields.Michael Mann12-77/+381
This was inspired by the https://www.wireshark.org/lists/wireshark-dev/201505/msg00029.html thread. Used TCP and NTP dissectors as the guinea pig with sample use. Documentation updates includes some unrelated cleanup just because it was noticed. Change-Id: I59b26e1ca3b95e3473e4757f1759d7ad82976965 Reviewed-on: https://code.wireshark.org/review/19211 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-12-13[RTP Analysis] calculate BW correctly whem IPv6 is used.AndersBroman1-4/+20
Change-Id: Ia53efa57042d199673a77c59491215c0e99c9e84 Reviewed-on: https://code.wireshark.org/review/19235 Reviewed-by: Anders Broman <a.broman58@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-12-13bthci_acl: Set src/dst addresses before reassembly.Stig Bjørlykke1-8/+7
Set all addresses before we do reassembly because sub-dissectors may set their own addresses, and we don't want to override them again. This fixes "Follow TCP Stream" and shows the correct IP addresses in the Source and Destination columns when transporting IP packets. Allocate the addresses in pinfo pool to avoid possible stack buffer overflow. Bug: 13230 Change-Id: I3b81ccb02b38331add4773d9bb3d5e0f6dcf025e Reviewed-on: https://code.wireshark.org/review/19201 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Reviewed-by: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2016-12-13ssh: add dissection for Elliptic Curve Diffie-Hellman KEXРоман Донченко1-0/+71
The protocol is actually nearly identical to ordinary Diffie-Hellman, but the names are different, and the ephemeral keys are bytestrings rather than integers. Change-Id: I261b6426137dae12fe53686e74517080abd80bb3 Reviewed-on: https://code.wireshark.org/review/19210 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-12-13Add BGP dissector support for draft-ietf-idr-shutdown-01Arjen Zonneveld1-1/+21
Parse the communication bits of a BGP Cease NOTIFICATION: Border Gateway Protocol - NOTIFICATION Message Marker: ffffffffffffffffffffffffffffffff Length: 146 Type: NOTIFICATION Message (3) Major error Code: Cease (6) Minor error Code (Cease): Administratively Shutdown (2) BGP Shutdown Communication Length: 124 Shutdown Communication: NTT will perform maintenance on this router. This is tracked in TICKET-1-24824294. Contact noc@ntt.net for more information. Draft at https://tools.ietf.org/html/draft-ietf-idr-shutdown-01, sample file taken from from http://instituut.net/~job/shutdown.pcap Change-Id: I2ab633883cc69e560ff79cb6239e02fcffd71e10 Reviewed-on: https://code.wireshark.org/review/19144 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-12-13Bluetooth: BTLE: Add new commands parsingJakub Pawlowski2-0/+113
Add "LE Set Extended Advertising Parameters" and "LE Set Extended Advertising Parameters" commands parsing. Change-Id: Ibcc9f145694e54710da3a11ade237f7132674366 Reviewed-on: https://code.wireshark.org/review/19234 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-12-13Build TRANSUM pluginPascal Quantin11-35/+244
Add plugin to autofoo and CMake build systems and fix errors found Add plugin to Windows installer (optional component activated by default) Change-Id: Id1b777bdee04e53076b3291f6fb68d5abad6985d Reviewed-on: https://code.wireshark.org/review/19228 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-12-13Change spaces to tab for recent wka entriesDavid Barrera2-6/+6
Commit 66549a9cacb29abdbb2c6fdaaf8235c4f34f6a13 added 3 new entries to wka.tmpl, but used spaces instead of the default tab separator. This inconsistency causes external tools that expect tabs in the manuf file to behave unexpectedly. The manuf file was re-generated after the fix to wka.tmpl. Change-Id: I79bceac649e0fc29b3502fc2e074dcd513f29ff5 Reviewed-on: https://code.wireshark.org/review/19217 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-12-13Bluetooth: BTLE: Add BT5.0 command and event name parsingJakub Pawlowski2-1/+74
Change-Id: I830551959965896451ddc08f3e843b61f22eed67 Reviewed-on: https://code.wireshark.org/review/19233 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-12-13packet-infiniband: Update conversation src port for exact lookupParav Pandit1-3/+23
Dissectors above infiniband (such as RPC dissector) performs exact lookup on saddr, daddr, sport, dport. They are unaware that underlying transport is infiniband which doesn't have src_qp in packets. Due to which srcport remains uninitialized and exact lookup fails. In order to get them work seemlessly, this fix updates the sport to src_qp (similar to destport to dest_qp). With this upper level dissectors can perform direct lookup similar to TCP. Those which need to access private data of unidirectional CM messages, can still continue to perform unidirectional lookup as before. It also fixes the issue where req_qp and resp_qp were swapped during bidirectional conversation creation. This was caught during testing with packet-rpc.c by Chuck Lever. Tested protocols: 1. nfs-rdma over Infiniband with trace of Bug 13213 2. ICMP packets over Infiniband 3. NVMe fabrics over RDMA Tested with trace of Bug 13201 for Nvme. Bug: 13202 Bug: 13213 Change-Id: Ica1b6aae3ccaa6642dc3b3edfa9a5a4c335cc5da Tested-by: paravpandit@yahoo.com Reviewed-on: https://code.wireshark.org/review/19190 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Chuck Lever <chuck.lever@oracle.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-12-13Update to WinSparkle 0.5.3.Gerald Combs3-7/+23
Update our WinSparkle package to 0.5.3. This fixes a file deletion bug. Note that WinSparkle now supports application shutdown callbacks, which should let us fix bugs 9687 and 12989. Bug: 13217 Change-Id: I4b5f325c6dc251ce167f7bd344bbf3ca5ad3fe14 Reviewed-on: https://code.wireshark.org/review/19230 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-12-12Remove some GtkCList comments and code.Gerald Combs2-46/+2
Remove some comments and hopefully-no-longer-necessary code specific to GtkCList. Change-Id: Ib62387f87e662798afba282cf95cbd215d60075e Reviewed-on: https://code.wireshark.org/review/19227 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-12-12rtp_player_dialog.cpp: fix usage of unsupported method ↵Jiri Novak1-0/+7
QComboBox::setCurrentText with Qt4.x QComboBox::setCurrentText() method is available in Qt5.x. Older versions code won't compile with it. Bug: 13235 Change-Id: Ia2e2713fefe0f2be01a0b77ff1ac39c9162fd0d1 Reviewed-on: https://code.wireshark.org/review/19219 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2016-12-12Move the declaration of packet_list_select_last_row() to ui/gtk/packet_list.h.Guy Harris4-12/+2
It's GTK+-only, so it shouldn't be in ui/ui_util.h. Get rid of the unused Qt packet list implementation of it. Change-Id: Ia9f8fe2209939dff5244e6948c36f29509340f68 Reviewed-on: https://code.wireshark.org/review/19226 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-12-12Get rid of some GTK+-only routines in file.c.Guy Harris3-34/+2
Just directly call the packet_list_select_ routine from the GTK+ code. Change-Id: I9146fb968c407d6186b146a86aa34678765f7352 Reviewed-on: https://code.wireshark.org/review/19225 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-12-12Mark routines GTK+ only.Gerald Combs4-1/+4
Mark packet_list_select_last_row and cf_goto_bottom_frame GTK+ only. Change-Id: I158814c2fa8c5fa8021b7156dded0945535c978a Reviewed-on: https://code.wireshark.org/review/19223 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-12-12Do not set Qt Window focus when highlighting rowsD. Ulis1-2/+0
Bug: 11890 Change-Id: I372f096c1ac0e483bf49cf95831e3df43621a642 Reviewed-on: https://code.wireshark.org/review/19209 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-12-12[RTP] In case no conversation is found, check if we have a dissecor forAndersBroman1-0/+12
the dynamic payload type defined. If so set the dynamic payload_type_string to that dissectors name. This is for RTP analysis to work if there is no setup information in the file. Change-Id: I7ae7b957cfa9eb6013f7d32d50563e2034210af6 Reviewed-on: https://code.wireshark.org/review/19220 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-12-12Rename non-EBCDIC-specific routines.Guy Harris4-11/+11
Those routines can handle any single-byte character set whose characters map to characters in the Basic Multilingual Plane; it could be used for extended ASCII, but we have another routine for that, mapping only characters with code points > 0x7f, so we just say "nonascii" rather than "ebcdic". Change-Id: I3d55b5d58e3e7ab08f3dfbfdb57a0301a30e71d4 Reviewed-on: https://code.wireshark.org/review/19214 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-12-12Update for library changes.Guy Harris2-1/+2
Change-Id: Ibe63e79a2865c53be0aafbf1b53103267a502b7a Reviewed-on: https://code.wireshark.org/review/19213 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-12-12Fix handling of EBCDIC string fields.Guy Harris4-51/+155
Have a routine that takes a 256-element translation table and uses it to map various flavors of EBCDIC to Unicode. Have separate translation tables for "common" EBCDIC (everything that's the same in all EBCDIC code pages that include the original EBCDIC characters) and EBCDIC code page 037. Add ENC_EBCDIC_CP037 for code page 037. Change-Id: Ia882b3c0abef9e30eb54cd47396e6fa0d6342044 Reviewed-on: https://code.wireshark.org/review/19212 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-12-11ssh: correct inaccurate field names/abbrevs/id variable namesРоман Донченко1-30/+30
* kex_first_packet_follows -> first_kex_packet_follows That's the name the spec (RFC 4253) uses. * DH H signature -> H signature, DH host key -> host key Neither the host key nor the H signature have much to do with Diffie-Hellman. They're used in the same way in every key exchange method that I know of, so their names should be more generic. * mpint_[ef] -> dh_[ef], mpint_[pg] -> dh_gex_[pg] This is to make all key exchange method-specific fields follow a consistent pattern with all names/abbrevs being prepended by the method name. Change-Id: Ic887fb92d8cbb6042e9b8e553cb5804db0ba4db8 Reviewed-on: https://code.wireshark.org/review/19199 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-12-11smb/tftp: fix no previous prototype for ‘tftp/smb_eo_cleanup’ ↵Alexis La Goutte2-2/+2
[-Wmissing-prototypes] Change-Id: I22ce7c49eab9232d38ace51a39fee098786f981d Reviewed-on: https://code.wireshark.org/review/19206 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-12-11[Automatic update for 2016-12-11]Gerald Combs13-506/+995
Update manuf, services enterprise-numbers, translations, and other items. Change-Id: Ie1a890ea3d5cfab844bc486806303e0ea4417ec3 Reviewed-on: https://code.wireshark.org/review/19203 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-12-11Cleanup dissection of endpoint addresses.Guy Harris1-17/+17
All the pseudo-headers encode the endpoint as per a bEndpointAddress in sections 9.6.6 "Endpoint" of the USB 2.0 spec and the USB 3.1 spec, with a 4-bit endpoint number at the bottom and a 1-bit direction at the top with 0 = OUT and 1 = IN. Show the FreeBSD endpoint address the same way the other endpoint addresses are shown; the FreeBSD one is shown as a 4-byte little-endian value, but only the low-order (first) byte is used, so just show that byte. Call that field the "endpoint address", with the lower 4 bits being the "endpoint number" and the uppermost bit the "endpoint direction". Change-Id: Ic7358c7fb6b6df2502315b590eb5178cecb321d9 Reviewed-on: https://code.wireshark.org/review/19200 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-12-11ssh: remove uninformative blurbsРоман Донченко1-45/+45
For most of the fields, the blurb is just the name with "SSH" prepended, which is not particularly useful. Replace a few of them with more informative descriptions and remove the rest. Change-Id: I15e95a42e897d09d3b6334022b32dd36f29e86a4 Reviewed-on: https://code.wireshark.org/review/19198 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-12-10Add a preference to control whether string and byte lengths appear in ↵Martin Mathieson1-14/+39
protocol tree Change-Id: I6be13d9adb8871cbbf4604155e8e7175a74ddaa3 Reviewed-on: https://code.wireshark.org/review/19188 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Dmitry Lazurkin <dilaz03@gmail.com> Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2016-12-10gsmtap: Introduce a new packet-gsmtap.h header fileHarald Welte4-133/+174
Move the GSMTAP protocol related #defines to packet-gsmtap.h, as there are other dissectors (like packet-gsm_sim.c and future dissectors) need access to some of those #defines. Change-Id: Ibb3517bd773be63b7e3cd30104a5351427e22ebf Reviewed-on: https://code.wireshark.org/review/19185 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-12-10Initialize fd_head->frame in all cases where we allocate fd_head.Guy Harris1-4/+5
Also, sort the initializations of structure members by the order in the structure, to make it easier to check that we've initialized them all. Bug: 13231 Change-Id: Id2819940d916a5fd5a3f1bf2fc20bd3ee34a75f4 Reviewed-on: https://code.wireshark.org/review/19195 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-12-10Qt: Avoid infinite recursion in ExtcapArgument::loadValuesStig Bjørlykke1-2/+4
If configuring a extcap "value" sentence with {value=} then loadValues() must not run in a infinite recursion trying to find it's children. Change-Id: Ic2577b31d9312e8f6a099c4fe7c0672e801dbc89 Reviewed-on: https://code.wireshark.org/review/19192 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com>
2016-12-10ssh: organize header field IDsРоман Донченко1-174/+190
The header field ID variables are listed in a somewhat chaotic order, making the list hard to comprehend and update. Group them according to the part of the protocol the corresponding fields occur in, and order the groups and the IDs within groups to roughly match the protocol flow and message formats. Change-Id: I915f508fd78ff89819c96d246c79d335de6a172e Reviewed-on: https://code.wireshark.org/review/19154 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-12-10Boost the max CPU time.Guy Harris1-1/+1
See if that lets the big file from bug 13226 pass the test under Valgrind. Change-Id: I76eb0c18809289e3b14ff8071402c31f70d93d42 Ping-Bug: 13226 Reviewed-on: https://code.wireshark.org/review/19189 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-12-09[ICMP] use abs() in detecting timestamp heuristicsMichael Mann1-2/+3
The code was making the assumption that the ICMP data time will always be greater than or equal to the frame time, but not earlier, but that is not always the case and the heuristics can fail. Bug: 13161 Change-Id: I4bc7bd8d22d717d3b1f08afdd651f8a70cb7aef2 Reviewed-on: https://code.wireshark.org/review/19157 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-12-09[RTP] Don't call p_get_proto_data() twiceAndersBroman1-8/+8
Change-Id: Ie13e23232e183818b813e391274d75415b3fee83 Reviewed-on: https://code.wireshark.org/review/19181 Reviewed-by: Anders Broman <a.broman58@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
generated by cgit v1.2.1 (git 2.18.0) at 2024-06-29 06:37:05 +0000