summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2011-09-21Fix ex "modeline" so it works;Bill Meier62-65/+65
See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5748 svn path=/trunk/; revision=39081
2011-09-21Don't pop up an error dialog box for every file that can't be saved. ↵Chris Maynard1-1/+1
Before, this could have potentially meant having to manually close far too many of them. svn path=/trunk/; revision=39080
2011-09-21Fix ex "modeline" so it works;Bill Meier2-189/+189
See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5748 Convert "4 space tabs" to spaces; Use consistent indentation. svn path=/trunk/; revision=39079
2011-09-21Fix ex "modeline" so it works;Bill Meier1-1194/+1194
See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5748 Convert '4 space tabs' to spaces; svn path=/trunk/; revision=39078
2011-09-21Report as expert/malformed if the same SN appears as ACK and NACK in same ↵Martin Mathieson1-0/+7
status PDU. svn path=/trunk/; revision=39077
2011-09-21Fix vi "modeline" so it works;Bill Meier2-4/+4
See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5748 svn path=/trunk/; revision=39076
2011-09-21Convert "4 space tabs" to spaces;Bill Meier1-81/+81
Fix vi edtor modeline so it works. svn path=/trunk/; revision=39075
2011-09-21Fix vi "modeline" so it works;Bill Meier17-17/+17
See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5748 svn path=/trunk/; revision=39074
2011-09-21Explicit #include <epan/value_string.h> not required.Bill Meier1-1/+0
svn path=/trunk/; revision=39073
2011-09-21Fix and suppress some warningsGraeme Lunt3-7/+68
svn path=/trunk/; revision=39072
2011-09-21Remove Makefile.inStig Bjørlykke1-651/+0
Set default svn:ignore targets. svn path=/trunk/; revision=39071
2011-09-21Remove check_col and use ENC_BIG_ENDIAN.Anders Broman2-202/+193
svn path=/trunk/; revision=39070
2011-09-21Add asn/t124/Makefile to configure.in and remove it from the repository.Graeme Lunt2-651/+1
svn path=/trunk/; revision=39069
2011-09-21Fix for unary minus warning on WindowsGraeme Lunt2-5/+15
svn path=/trunk/; revision=39068
2011-09-21Make query_length a gint as the lenght argument to proto_tree_add_text() is ↵Anders Broman1-1/+1
a gint. svn path=/trunk/; revision=39067
2011-09-21Basic RDP dissection, which can dissect the connection sequence. Graeme Lunt21-69/+14100
A work in progress. Can be used with the SSL dissector to decrypt Enhanced RDP Security SSL. With Standard RDP Security (e.g those on Wiki), the PDUs are all encrypted after the SecurityExchange PDU. Wiki to be updated with an example SSL protected capture and associated key material. svn path=/trunk/; revision=39066
2011-09-20From Frank Lahm: Complete dissection of AFP FPSpotlightRPC function.Guy Harris1-154/+320
From me: don't use global variables in FPSpotlightRPC dissection. svn path=/trunk/; revision=39065
2011-09-20Add an ENC_ASCII; right now, it's the same as ENC_UTF_8, but it shouldGuy Harris1-1/+12
eventually cause all bytes with the 8th bit set to be displayed as error indications. svn path=/trunk/; revision=39064
2011-09-20Use ENC_ values in proto_tree_add_item() calls. Use ENC_UTF_8 forGuy Harris1-409/+440
strings, and note that, for older AFP clients and servers, we might need a way to say to use some Mac encoding instead. Use tvb_strsize() rather than tvb_get_ephemeral_stringz() to just get the length of a null-terminated string. Use FT_GUID for UUIDs. The low-order bit in the MessageBitmap in the FPGetSrvrMsg reply does not, at least according to the current AFP spec, specify whether there's a message at all, it specifies whether it's a server message or a login message. The spec *does* now mention the "message is UTF-8" bit; use it. Fix a blurb. svn path=/trunk/; revision=39063
2011-09-20Add DeCount for his contribution in bug 6362.Chris Maynard1-0/+1
svn path=/trunk/; revision=39062
2011-09-20From DeCount via bug 6362: Increase maximum allowable number of duplicate ↵Chris Maynard1-14/+16
filesi from 10 to 1000. I modified his patch to avoid appending anything to the first filename, and other minor changes. Reference: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6362 svn path=/trunk/; revision=39061
2011-09-20From Sylvain Munaut:Anders Broman1-0/+28
Add support for signed types in _proto_tree_add_bits_ret_val https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6363 svn path=/trunk/; revision=39060
2011-09-20From Dirk via bug 6361:Stig Bjørlykke5-18/+15
Use File/Directory Dialog as a field type for UAT preferences. svn path=/trunk/; revision=39059
2011-09-20From Dirk via bug 6361:Stig Bjørlykke3-14/+56
Add a File/Directory Dialog as a field type for UAT preferences. svn path=/trunk/; revision=39058
2011-09-19Since the call to expert_add_info_format() was commented out, 'ti' isn't ↵Chris Maynard1-9/+4
needed, so get rid of it. Fixes Coverity CID's 1260 and 1261. svn path=/trunk/; revision=39057
2011-09-19Don't assign the return value of proto_tree_add_text() if it's not going to ↵Chris Maynard1-1/+1
be used. Fixes Coverity CID 1232. svn path=/trunk/; revision=39056
2011-09-19Since the call to proto_tree_add_text() was #if 0'd out, there's no need to ↵Chris Maynard1-2/+3
assign the return value of tvb_new_subset to wlan_tvb. Actually, there's probably no need to call tvb_new_subset() in the first place, but for now let's just tackle the unused value warning and leave the FIXME for someone who knows more about this. Fixes Coverity CID 864. svn path=/trunk/; revision=39055
2011-09-19Don't assign return value of proto_tree_add_text() to rrsc_item if it's not ↵Chris Maynard1-1/+1
going to be used. Fixes Coverity CID 863. svn path=/trunk/; revision=39054
2011-09-19Move the return out of the for() loop so all values are freed. Fixes ↵Chris Maynard1-6/+2
Coverity CID 1277 (loop increment j++ is unreachable). svn path=/trunk/; revision=39053
2011-09-19The change in r37371 fixed the clv_tree unused assignment and pointless use, ↵Chris Maynard1-1/+5
but caused another unused assignment to 'ti'. Fixed. (Coverity CID 1233) svn path=/trunk/; revision=39052
2011-09-19Don't assign the return value of proto_tree_add_item() if it's not going to ↵Chris Maynard1-11/+9
be used. Fixes Coverity CID's 1278-1280 (UNUSED VALUE). svn path=/trunk/; revision=39051
2011-09-19Delete duplicate line of code. Fixes Coverity CID 1281 (UNUSED VALUE).Chris Maynard1-1/+0
svn path=/trunk/; revision=39050
2011-09-19Close fp before checking if private_key is NULL to avoid memory leak. Fixes ↵Chris Maynard1-5/+5
Coverity 597. svn path=/trunk/; revision=39049
2011-09-19Fix static overrun bug introduced in r37506. Fixes Coverity CID 1216.Chris Maynard1-32/+32
svn path=/trunk/; revision=39048
2011-09-19Various Cleanups...Bill Meier1-111/+113
- Don't use 'l' as a variable name; - Use 'tvb_strsize();proto_tree_add_item();' iso 'tvb_get_ephemeral_stringz(); proto_tree_add_string();' - Use ENC_NA/ENC_BIG_ENDIAN iso FALSE as appropriate for proto_tree_add_item(). svn path=/trunk/; revision=39047
2011-09-19Fix compile error: just link to expert_group_vals[] in expert.c (no need for ↵Bill Meier1-18/+0
a copy in tap-expert.c). svn path=/trunk/; revision=39046
2011-09-19Add expert 'Group' to output.Martin Mathieson1-2/+21
svn path=/trunk/; revision=39045
2011-09-19Use ENC_NA and ENC_BIG_ENDIAN rather than FALSE in proto_tree_add_item()Guy Harris1-129/+128
calls and tvb_get_guid() calls. For strings, add ENC_UTF_8. svn path=/trunk/; revision=39044
2011-09-19Fix a crash when zooming into a TSN plot.Michael Tüxen1-107/+109
Provided by Irene Ruengeler. From me: remove tailing whitespaces. svn path=/trunk/; revision=39043
2011-09-19RFC 4282 says the NAI is UTF-8.Guy Harris1-7/+2
svn path=/trunk/; revision=39042
2011-09-19Use ENC_NA and ENC_LITTLE_ENDIAN rather than TRUE or FALSE inGuy Harris1-79/+79
proto_tree_add_item() calls. For strings, add ENC_UTF_8. (Yes, the byte order is irrelevant for those - but they should arguably be FT_UINT_STRING, as they're counted strings, and the byte order *is* relevant for FT_UINT_STRING.) svn path=/trunk/; revision=39041
2011-09-19Some probably-erroneous TRUEs as the last argument toGuy Harris1-2/+2
proto_tree_add_item(); the items were one byte long, so the byte order is irrelevant. svn path=/trunk/; revision=39040
2011-09-19Use ENC_BIG_ENDIAN instead of FALSE in proto_tree_add_item() calls forGuy Harris1-25/+34
integral values. For the Network Access Identifier, use ENC_UTF_8. svn path=/trunk/; revision=39039
2011-09-19Move stuff inside if(tree)Anders Broman1-51/+48
svn path=/trunk/; revision=39038
2011-09-19From Martin Kaiser:Anders Broman1-17/+71
DVB-CI / CI+ Application MMI version 2 https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6352 svn path=/trunk/; revision=39037
2011-09-19Make it possiblwe to creare a trime string from frame data.Anders Broman3-45/+64
svn path=/trunk/; revision=39036
2011-09-19Remove debug code.Anders Broman1-1/+0
svn path=/trunk/; revision=39035
2011-09-18[Automatic manuf, services and enterprise-numbers update for 2011-09-18]Gerald Combs3-10318/+10558
svn path=/trunk/; revision=39032
2011-09-17Update sub-object types of XRO to match RFC 5521. Fixes ↵Chris Maynard1-11/+9
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3778. svn path=/trunk/; revision=39031
2011-09-16From Pierre-Marie de Rodat: PostgreSQL Startup message not properly ↵Bill Meier1-6/+12
supported by the PostgreSQL dissector. "The PostgreSQL dissector do not fully support the frontend StartupMessage (see "StartupMessage" in http://developer.postgresql.org/pgdocs/postgres/protocol-message-formats.html). The couples parameter name/parameter value in this kind of message are reported as a block of text ("name: value") by the dissector whereas reporting them as parameter name/parameter value would be more appropriate. I've fixed it, so now the username and the database sent by the frontend can be handled in, for instance, the CSV output of TShark. I've also added a "val_count" field to contain the number of values (row descriptions or row data) included in RowDescription/DataRow messages. This information is useful when analyzing the CSV of TShark since in a CSV row, many row descriptions or row data may be packed together." Patch changes from me: - No need to fetch ephemeral string anymore so just use tvb_strsize() to get string length; - Change field-filtername from pgsql.val.count to pgsql.field.count See: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6343 svn path=/trunk/; revision=39030