summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2002-03-09Sigh. Tcpdump cannot handle capture files with a snapshot length of 0,Guy Harris1-2/+14
as BPF filters return either 0 if they fail or the snapshot length if they succeed, and a snapshot length of 0 means success is indistinguishable from failure and the filter expression would reject all packets. Now that a snapshot length of 0, inside Ethereal, means "snapshot length unknown", we have to, when opening a libpcap file for output, make the snapshot length some non-zero value. We make it WTAP_MAX_PACKET_SIZE, in case some program uses the snapshot length as a buffer size. (That doesn't help if there are packets with more than 65535 bytes of data; if there are, we'd need to raise WTAP_MAX_PACKET_SIZE just to make those files readable in Ethereal in any case.) svn path=/trunk/; revision=4905
2002-03-09Fix some "proto_tree_add_uint()" and "proto_tree_add_uint_hidden()"Guy Harris2-8/+9
calls that passed TRUE or FALSE, rather than an integer value, as the last argument. A SOCKS command is one byte, so make the "socks.command" field an FT_UINT8. svn path=/trunk/; revision=4904
2002-03-09Use -1, rather than 0, as the length when creating an item with aGuy Harris1-2/+10
subtree under it, so that if an exception is thrown while we're dissecting the items in the subtree, it runs to the end of the tvbuff (as, if an exception is thrown, it means the item should cover the stuff in the tvbuff *and* stuff beyond it). svn path=/trunk/; revision=4903
2002-03-09From Jouni Malinen: fix bugs in 802.11 authentication frame dissection.Guy Harris3-3/+8
svn path=/trunk/; revision=4902
2002-03-09No need to put ", N byte{s} at offset O" into the Info column twice;Guy Harris1-6/+1
once is enough. svn path=/trunk/; revision=4901
2002-03-07Fix a comment.Guy Harris1-3/+3
svn path=/trunk/; revision=4899
2002-03-07Fix a typo - IFT_ISO88025 is 9, not 8.Guy Harris1-2/+2
svn path=/trunk/; revision=4898
2002-03-07Bug fix from Marc Milgram: occasionally the VMS parser would read offGuy Harris1-2/+2
the end of string, and find some old data that looked useful, but was bogus for the frame. svn path=/trunk/; revision=4897
2002-03-07Updates from Mike Frisch.Guy Harris1-7/+9
svn path=/trunk/; revision=4895
2002-03-06Don't say "without SNMP"; that can confuse people into thinking it meansGuy Harris2-6/+4
Ethereal doesn't dissect SNMP if not linked with an SNMP library (and *did* confuse at least one person into thinking that). Say "without SNMP MIB support", instead, as you only lose the ability to read SNMP MIBs and interpret OIDs and variable bindings according to those MIBs. svn path=/trunk/; revision=4894
2002-03-06tvb_get_nstringz() needs to terminate a string with a NUL if theGilbert Ramirez3-28/+86
end of the tvbuff is reached before the maximum_length passed by the caller is reached and before a terminating NUL is found. In this case, tvb_get_nstringz() returns a -1, but if the string is not artificially terminated with a NUL by tvb_get_nstringz(), the caller has no idea where the string should end because 1) the return value "-1" gives the impression that the string ends at the end of the buffer but 2) the string does not end at the end of the buffer, but somewhere in the middle, due to the packet being shorter than expected. tvb_get_nstringz() and tvb_get_nstringz0() were both modified. The FT_STRINGZ case in proto_tree_add_item() is made simpler. During regression testing, when investigating a regression that I later corrected, I discovered that strings added through proto_tree_add_item (FT_STRING, FT_STRINGZ, and FT_UINT_STRING) leaked memory due to double allocation of the string. The proto_tree_add_string*() functions do not leak memory, since they only copy the string once. The memory leak was fixed by adding another argument to the static function proto_tree_set_string() to let the string ftype code know to g_strdup() the string or not. svn path=/trunk/; revision=4891
2002-03-06Remove incorrect usage of ?: expression in favor or the correct,Gilbert Ramirez1-3/+13
and more readable, "if" statement. svn path=/trunk/; revision=4890
2002-03-06Rename function and variables for dissecting an NT service Account ControlRonnie Sahlberg3-96/+113
bitmap and make the function not static. This bitmap is present in other RPC protocols for NT services as well besides SAMR. svn path=/trunk/; revision=4889
2002-03-06Moved dissector for UNICODE_STRING structure from packet-dcerpc-samr.c to ↵Ronnie Sahlberg3-180/+206
packet-dcerpc-nt.c since this is a structure that is common to all NT services and not only SAMR. svn path=/trunk/; revision=4888
2002-03-06Fixed bug in dissect_ndr_pointer(). Top level Unique and Full pointers areRonnie Sahlberg1-5/+31
not encoded in the same way in the NDR representation. svn path=/trunk/; revision=4887
2002-03-061.3 was committed by mistakeJun-ichiro itojun Hagino1-6/+6
svn path=/trunk/; revision=4886
2002-03-06VRRPv3 (for IPv6) support, by sumikawa@kame.netJun-ichiro itojun Hagino2-17/+41
svn path=/trunk/; revision=4885
2002-03-06Use the gdb "x" (examine memory) command instead of "print" to obtainGilbert Ramirez1-18/+39
the packet data. "print" will only show the first 200 members of an array, whereas "x" doesn't seem to have a limit. svn path=/trunk/; revision=4884
2002-03-06From Mike Frisch: remove debug printf statements.Guy Harris1-7/+1
svn path=/trunk/; revision=4883
2002-03-06Check to make sure SNMP_IPADDR items are 4 bytes long and SNMP_COUNTER64Guy Harris1-3/+38
items are 8 bytes long. svn path=/trunk/; revision=4882
2002-03-06Add ability to pull packet from add_packet_to_packet_list() frame.Gilbert Ramirez1-16/+39
svn path=/trunk/; revision=4881
2002-03-05The length field in the TPKT header contains the length of the packetGuy Harris1-3/+4
*including the length of the TPKT header itself*, not just the length of the payload. svn path=/trunk/; revision=4880
2002-03-05From Joerg Mayer: remove unused variables.Guy Harris6-17/+8
svn path=/trunk/; revision=4879
2002-03-05From Joerg Mayer: use _U_ to flag unused arguments.Guy Harris32-258/+258
svn path=/trunk/; revision=4878
2002-03-05From Adam Sulmicki: fixes to typos in comments.Guy Harris1-3/+3
svn path=/trunk/; revision=4877
2002-03-05Fix another problem found by the PROTOS captures - inGuy Harris1-4/+12
"asn1_string_value_decode()", don't pass "g_malloc()" an argument of 0, as "g_malloc()" will return NULL in that case, and the callers of "asn1_string_value_decode()" aren't necessarily prepared for a null argument. svn path=/trunk/; revision=4876
2002-03-05Make "wtap_seek_read()" return TRUE on success and FALSE on error, likeGuy Harris19-222/+227
"wtap_read()". Add some additional error checks to the Sniffer file reader. svn path=/trunk/; revision=4875
2002-03-05Have "wtap_seek_read()" return 0 on success and -1 on failure, and takeGuy Harris22-155/+282
an "err" argument that points to an "int" into which to put an error code if it fails. Check for errors in one call to it, and note that we should do so in other places. In the "wtap_seek_read()" call in the TCP graphing code, don't overwrite "cfile.pseudo_header", and make the buffer into which we read the data WTAP_MAX_PACKET_SIZE bytes, as it should be. In some of the file readers for text files, check for errors from the "parse the record header" and "parse the hex dump" routines when reading sequentially. In "csids_seek_read()", fix some calls to "file_error()" to check the error on the random stream (that being what we're reading). svn path=/trunk/; revision=4874
2002-03-05There's just a single H.225 dissector, for both Call Signaling andGuy Harris1-9/+11
Registration, Admission, and Status, so just call it "h225", not "h225_cs". svn path=/trunk/; revision=4871
2002-03-05Cut down the vertical spacing in the "Capture Options" dialog box.Guy Harris1-7/+7
svn path=/trunk/; revision=4870
2002-03-05From David Frascone: fix pathname of Diameter directory file.Guy Harris1-3/+2
svn path=/trunk/; revision=4869
2002-03-05From David Frascone: dictionary fixes to NASREQ command codes.Guy Harris2-3/+6
svn path=/trunk/; revision=4868
2002-03-05From Michael Tuexen: SCCP-atop-M3UA support.Guy Harris2-1/+3
svn path=/trunk/; revision=4867
2002-03-04SCCP support, from Jeff Morriss.Guy Harris6-24/+2268
svn path=/trunk/; revision=4866
2002-03-04Add entries for March.Gerald Combs1-0/+23
svn path=/trunk/; revision=4861
2002-03-04Note the update to the SCTP checksum code.Guy Harris1-0/+1
svn path=/trunk/; revision=4860
2002-03-04Update the "README.win32" file to reflect Andrew Feren's changes to useGuy Harris1-12/+12
Python iff PYTHON is defined in "config.nmake". svn path=/trunk/; revision=4859
2002-03-04Fix some items.Guy Harris1-4/+6
svn path=/trunk/; revision=4858
2002-03-04Check for errors in seeks, "tell"s, and "stat()"s/"fstat()"s.Guy Harris17-162/+424
For file types where we allocate private data, add "close" routines where they were missing, to free the private data. Also fix up the code to clean up after some errors by freeing private data where that wasn't being done. Get rid of unused arguments to "wtap_dump_open_finish()". Fix indentation. svn path=/trunk/; revision=4857
2002-03-03Bump the version to 0.9.2. Update NEWS to include everything from February.Gerald Combs4-7/+162
svn path=/trunk/; revision=4856
2002-03-03From Michael Tuexen: report the type of an unrecognized parameter.Guy Harris1-3/+5
svn path=/trunk/; revision=4855
2002-03-03From Heikki Vatiainen: make "get_host_ipaddr()" require dotted-quad IPGuy Harris2-1/+12
addresses to really be quads, i.e. have four numbers. svn path=/trunk/; revision=4854
2002-03-03Report ASN.1 BER parsing errors closer to the point at which they'reGuy Harris1-206/+320
detected, so we do a better job of reporting the item with the problem. svn path=/trunk/; revision=4853
2002-03-02As there's nothing to dissect for LDAP_REQ_UNBIND, set "ret" toGuy Harris1-2/+3
ASN1_ERR_NOERROR, as you can't have a dissection error if you've dissected nothing. When dissecting a Bind reply, set "ret" to the return value of "dissect_ldap_response_bind()", so errors get reported properly. svn path=/trunk/; revision=4851
2002-03-02Don't check the message type if it's not of class ASN1_APL; instead,Guy Harris1-49/+58
just display the message type and body as an error. If the message type isn't a type we dissect, display the "Unknown message type" entry with the right offset and length. svn path=/trunk/; revision=4850
2002-03-02Treat LDAP_REQ_UNBIND as a request with nothing in it, not as an unknownGuy Harris1-4/+7
request type. Put the request types in order in the switch statement. svn path=/trunk/; revision=4849
2002-03-02From Joerg Mayer: get rid of "-Wno-unused" flag in some configureGuy Harris11-29/+35
scripts, and check in changes to add _U_ to some unused arguments (some other should perhaps be used, so we leave the _U_ out so that the warnings serve as a reminder to check those). svn path=/trunk/; revision=4848
2002-03-02From Joerg Mayer: get rid of "-Wno-unused" flag in some configureGuy Harris11-32/+40
scripts, and check in changes to add _U_ to some unused arguments (some other should perhaps be used, so we leave the _U_ out so that the warnings serve as a reminder to check those). svn path=/trunk/; revision=4847
2002-03-02Tell people not to use "ulong" or "ushort".Guy Harris1-3/+7
svn path=/trunk/; revision=4845
2002-03-02From Michael Tuexen: update the CRC32 checksum code to matchGuy Harris1-4/+13
draft-ietf-tsvwg-sctpcsum-03. svn path=/trunk/; revision=4844
generated by cgit v1.2.1 (git 2.18.0) at 2024-07-07 13:08:05 +0000