summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2013-10-16Work around a self-assingment error picked up by Clang 5.0.Gerald Combs1-1/+3
svn path=/trunk/; revision=52642
2013-10-16Fix (what appears to be) a minor bug when dissecting RTMP.Bill Meier1-2/+2
svn path=/trunk/; revision=52641
2013-10-16Upgrade RRLP dissector to V11.0.0Pascal Quantin4-25/+332
svn path=/trunk/; revision=52640
2013-10-16Fix various: whitespace, comments & etc.Bill Meier1-612/+624
Add editor modelines. svn path=/trunk/; revision=52639
2013-10-16Add blank line before 'and by'Bill Meier1-0/+1
svn path=/trunk/; revision=52638
2013-10-16Add Ed Beroset to the list of Wireshark authors.Chris Maynard1-3/+4
svn path=/trunk/; revision=52637
2013-10-16From Ed Beroset: add modelines and fix irregular indenting;Bill Meier6-666/+723
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9273 This patch adds modelines and cleans up the irregular indentation of this dissector's code. The only other change was in asn1/c1222/packet-c1222-template.c to consolidate an #ifdef that had a redundant #endif (line 812) and subsequent reopening #ifdef (line 824). The only thing between them was comments, so the span of the original #ifdef (line 644) was simply extended by eliminating those two lines. The purpose for this patch is to make the file easier to edit and understand in advance of more substantive patches later. This patch is intended to be easy to review by having only non-substantive changes. svn path=/trunk/; revision=52636
2013-10-16Update the list of new protocols supportedPascal Quantin1-0/+17
svn path=/trunk/; revision=52635
2013-10-15As suggested separately by both Jakub and Anders: only read theEvan Huus2-55/+39
WIRESHARK_DEBUG_WMEM_OVERRIDE environment variable once in wmem_init, not every time wmem_allocator_new is called. We currently create a new pinfo pool for every packet we dissect, so this is a small performance win, especially when getenv is slow (which may happen if a large number of environment variables are set, such as when fuzz-testing). svn path=/trunk/; revision=52634
2013-10-15If CODE_SIGN_IDENTITY is set use it to sign the app bundle and theGerald Combs2-0/+18
installer package. Add commented-out code to sign the .dmg as well in case Apple supports that in the future. svn path=/trunk/; revision=52633
2013-10-15Adjust parenthesis to make gcc happy.Gerald Combs1-1/+1
svn path=/trunk/; revision=52632
2013-10-15Don't try heuristic dissectors on second pass if no match was found in the ↵Anders Broman1-5/+40
first one. svn path=/trunk/; revision=52631
2013-10-15Fix ABI check error for libwiresharkBalint Reczey1-0/+6
svn path=/trunk/; revision=52630
2013-10-151.11.0 → 1.11.1.Gerald Combs1-5/+5
svn path=/trunk/; revision=52629
2013-10-15Try building 1.11.0.Gerald Combs1-4/+4
svn path=/trunk/; revision=52628
2013-10-15From Ed Beroset via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9272Chris Maynard4-31/+89
Add tshark -G column-formats report and document the missing ftypes, heuristic-decodes and plugins reports. From me: Sort the reports. Add modelines to epan/column.c. Minor whitespace changes. svn path=/trunk/; revision=52627
2013-10-15g_slist_prepend() should be faster than g_slist_append() use it where the ↵Anders Broman1-4/+4
order shouldn't matter. svn path=/trunk/; revision=52626
2013-10-15Micro-optimize print_columns(): replace g_snprintf() & g_strlcat() with ↵Jakub Zawadzki1-22/+53
memcpy(). svn path=/trunk/; revision=52625
2013-10-15Try to optimize heuristics slightly.Anders Broman3-481/+490
svn path=/trunk/; revision=52624
2013-10-15Reorder all of the bitmask trees according to its endianess from highest to ↵Cal Turney2-167/+163
lowest order bit. These consist of the following bitmask fields: [packet-smb.c] 'Create Flags', 'Access Mask', 'File Attributes', 'Share Access', 'Create Options', 'Security Flags', 'Optional Support'(in TreeConnect AndX responses), and "Quota Flags" [packet-smb2.c] 'Flags', 'Session Flags', 'Security mode', and 'Interface Capabilities'. [packet-smb.c] Made the tfs_file_attribute_xxx true_false_string values less verbose and more compact. [packet-smb2.c] Changed all references to "RMDA" to RDMA". [packet_smb.c] In dissect_qfi_SMB_FILE_NETWORK_OPEN_INFO() (GetInfo response) changed "Unknown Field" to "Reserved" (See capture 'DMtrace2.cap' frame 20023). svn path=/trunk/; revision=52623
2013-10-15Add another cast.Gerald Combs1-1/+1
svn path=/trunk/; revision=52622
2013-10-15Add casts to fix some shortening errors.Gerald Combs1-4/+4
svn path=/trunk/; revision=52621
2013-10-15Add some missing parenthesis. Make sure we set our font in the right place.Gerald Combs3-18/+14
Make the ColorUtils::fromColorT() convenience function a little more convenient. Use it. svn path=/trunk/; revision=52620
2013-10-15limit the values written to phdr.(cap)len to guint32, not to guint16Martin Kaiser1-6/+6
We read a two-byte length field and add a constant number of header bytes to this length, so we could in theory be larger than guint16. svn path=/trunk/; revision=52619
2013-10-15code review of parse_s1_W_stats()Martin Kaiser1-2/+16
range check for array index don't assign the result of pntohs() to a gint16 range check for the values stored in phdr.(cap)len svn path=/trunk/; revision=52618
2013-10-15Don't do canaries in blocks of guint32, it appears to cause alignment issuesEvan Huus1-9/+9
when running tests on Solaris. Revert back to byte-at-a-time, but do fewer bytes to avoid a performance hit. svn path=/trunk/; revision=52617
2013-10-15Check the length *before* accessing the array, and cap theEvan Huus1-1/+7
length-retrieved-from-packet at the size of the array we have. Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9270 svn path=/trunk/; revision=52616
2013-10-15Fix a length check in the OID code, we add an extra byte if is_first, not theEvan Huus1-1/+3
other way around. Also add an assert so it blows up if we get it wrong, rather than leading to uninitialized memory. Fixes the last errors I can find in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9268 svn path=/trunk/; revision=52615
2013-10-15Factor out common parts of ABI checks to UseABICheck.cmakeBalint Reczey4-44/+31
svn path=/trunk/; revision=52614
2013-10-15Fix Coverity CID 1106801: Missing break in switch.Chris Maynard1-0/+1
svn path=/trunk/; revision=52613
2013-10-15Make sure we have a valid capture file pointer in win32_export_file().Gerald Combs1-0/+3
Fixes bug 9271. svn path=/trunk/; revision=52612
2013-10-15Fill in the help links. Make sure they do something when they're clicked.Gerald Combs2-14/+40
Try to make the task list width match its contents. svn path=/trunk/; revision=52611
2013-10-15Remove some commented code.Gerald Combs1-3/+0
svn path=/trunk/; revision=52610
2013-10-15Fix the bitcoin dissector to be able to dissect recent version of the ↵Michael Mann1-30/+68
protocol. Bug 8844 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8844) Changes: - All messages now have a checksum (and not only version and verack). - In the version message: user agent added as a string preceded by a varint length. - Port in an address is in little endian and not big endian. - In the version message the receiving and emitting address where inverted. From Eric Masson svn path=/trunk/; revision=52609
2013-10-14Reverting as requested by Jakub, eventhoug I don't think this prticular ↵Anders Broman1-3/+0
entry is useful as it's duplicated in the tree and almost certanly never vissible. svn path=/trunk/; revision=52608
2013-10-14Let Qt lay out and size elements in FollowStreamDialog. Make itGerald Combs4-78/+157
resizable. Get rid of the group box -- the OS X and Windows HIGs discourage its use and I'm not sure if it fits the GNOME HIG in this case either. Make the stream contents monospace. Set the cursor to the beginning of the text when we follow a stream. Continue the War On Unnecessary Dialogs. Move "Find"ing from a pop-up window to the main Follow dialog. Wrap back to the beginning as needed. Add a "Cancel" button. Make sure it and the escape key work as expected. svn path=/trunk/; revision=52607
2013-10-14Replace XXX with explanation based on discussion with Jakub on -dev.Evan Huus1-2/+3
svn path=/trunk/; revision=52606
2013-10-14Slightly clarify the wmem release note entry.Evan Huus1-1/+2
svn path=/trunk/; revision=52605
2013-10-14 Adding to col info is probably useless as next dissector will overwrite it.Anders Broman1-0/+3
svn path=/trunk/; revision=52604
2013-10-14Try to pptimize heuristics slightly.Anders Broman7-47/+62
svn path=/trunk/; revision=52603
2013-10-14Add dissection of NCM/MBIM data traffic based on data interface class ↵Pascal Quantin2-2/+30
protocol code svn path=/trunk/; revision=52602
2013-10-14Look for QtWidgets in the right directory.Gerald Combs1-6/+7
svn path=/trunk/; revision=52601
2013-10-14PacketList and ProtoTree need access to MainWindow at initializationGerald Combs3-6/+6
time in order to fill in their respective context menus. R52386 broke that. Fix it and add comments about handling reparenting. Fixes bug 9265. svn path=/trunk/; revision=52600
2013-10-14do some range checks when reading vwr filesMartin Kaiser1-14/+14
don't assign the output of pntoh24() to a gint16 unfortunately, vwr detection does not work reliably and many pdf files are recognized as vwr - this commit should prevent wireshark from crashing when it tries to load the USB 2.0 spec as pdf ;-) svn path=/trunk/; revision=52599
2013-10-14Make pkgconfig work - sort of:Jörg Mayer2-9/+12
- fix a typo - Add the library dirs and not just the libraries. This would help if the paths that are now returned were actually correct. svn path=/trunk/; revision=52598
2013-10-14As reported by Didier Gautheron on -dev ↵Pascal Quantin1-1/+1
(http://www.wireshark.org/lists/wireshark-dev/201310/msg00159.html) : Since r49923, TCP flags are no more displayed in info column when tree is NULL svn path=/trunk/; revision=52597
2013-10-14TLS server key exchange misses sig and hash algorithm for TLS 1.2. Bug 9208 ↵Michael Mann1-6/+80
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9208). 1. Fix ECDH server key exchange for TLS 1.2 2. Fix RSA server key exchange for TLS 1.2 From Hauke Mehrtens svn path=/trunk/; revision=52596
2013-10-14DTLS server key exchange misses sig and hash algorithm for TLS 1.2. Bug ↵Michael Mann1-6/+80
9208 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9208) 1. Fix ECDH server key exchange for DTLS 1.2 2. Fix RSA server key exchange for DTLS 1.2 From Hauke Mehrtens svn path=/trunk/; revision=52595
2013-10-13DRX: start to show state prior to and after current PDU.Martin Mathieson1-71/+96
svn path=/trunk/; revision=52594
2013-10-13As requested by Zoltán Lajos Kis, split the openflow dissector int one file ↵Anders Broman4-422/+628
per protocol version. svn path=/trunk/; revision=52593