summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2015-01-15Modify the errorcode defenition to suit ANSI MAP, this is (probably) OK asAndersBroman2-7/+49
ANSI MAP is currently the only user of ANSI TCAP. Bug: 6112 Change-Id: I49f89c862ddc8351091a9a939415e4ba6e7603f5 Reviewed-on: https://code.wireshark.org/review/6546 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-01-15ZigBee: don't use packet_scope outside of dissectionEvan Huus1-14/+26
The decode_* functions defined here are called post-dissection for formatting labels, so don't have access to packet scope. Just use and free manual memory. Introduced in gbdfabe59. Bug: 10855 Change-Id: I9b0085b1f7779ae6fbd12482c44d8f611cdbb49f Reviewed-on: https://code.wireshark.org/review/6545 Reviewed-by: Evan Huus <eapache@gmail.com>
2015-01-15rsvp: fix typoEvan Huus1-1/+1
caught by test suite as: Duplicate field detected in call to proto_register_field_array: rsvp.call_attributes is already registered Change-Id: Ibf4ead3026b9930fb8f6ab07f0a5a4c299cedc35 Reviewed-on: https://code.wireshark.org/review/6544 Reviewed-by: Evan Huus <eapache@gmail.com>
2015-01-15Netflow: Fix spelling of 'latitude'Martin Mathieson1-2/+2
Change-Id: Iaae40f4a191e458645263c8d7a114392cd063707 Reviewed-on: https://code.wireshark.org/review/6543 Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2015-01-15Update to libnghttp2 0.7.1Alexis La Goutte14-234/+622
Change-Id: Ib8d40586a3b95674447819f77eaaa69376dce6fd Reviewed-on: https://code.wireshark.org/review/6411 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-01-15RSVP: Add support of GMPLS Support for Metro Ethernet Forum and G.8011 (RFC ↵Miltos Patsiouras2-4/+350
6004) This document describes a method for controlling two specific types of Ethernet switching via Generalized Multi-Protocol Label Switching (GMPLS). This document supports the types of switching corresponding to the Ethernet services that have been defined in the context of the Metro Ethernet Forum (MEF) and International Telecommunication Union (ITU) G.8011. Specifically, switching in support of Ethernet private line and Ethernet virtual private line services are covered. Support for MEF- and ITU-defined parameters is also cover Bug: 7841 Change-Id: I12e12d01d497bd0e9703efcf6bd8ad100805bccc Change-Id: I180c095652604bc025ab81171dd8a042e0930f08 Reviewed-on: https://code.wireshark.org/review/5323 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-01-15CAPWAP: Add a IEE802.11 Message Element Type (RFC5416)Alexis La Goutte3-6/+76
* IEEE 802.11 Information Element (1029) Add add_tagged_field to packet-ieee80211.h (will be used by other dissector) Change-Id: Icd13be416ccc47fb2309b9962e9a47c339885d1e Reviewed-on: https://code.wireshark.org/review/6524 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-01-15Fix cmake-cflagsGraham Bloice1-3/+0
The flags that are deleted are already supplied by the CMake generator. Change-Id: Ifafc2343ac0c5d365a39f4a181b23f54c65bce74 Reviewed-on: https://code.wireshark.org/review/6538 Petri-Dish: Graham Bloice <graham.bloice@trihedral.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
2015-01-15CAPWAP: Add some IEE802.11 Message Element Type (RFC5416)Alexis La Goutte1-3/+288
* IEEE 802.11 OFDM Control (1033) * IEEE 802.11 Update WLAN (1044) Change-Id: I702de1d649b1dc2af1de83ee21152c6a18f42dfc Reviewed-on: https://code.wireshark.org/review/6509 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-01-15CAPWAP: Add a new Message Element Type (RFC5415)Alexis La Goutte1-0/+56
* Delete Station (18) Change-Id: I33afa96d183b8ff22725d2e00dcfeccea3fdfa04 Reviewed-on: https://code.wireshark.org/review/6508 Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-01-15mate_util: fix parameter ... not found in the function declaration ↵Alexis La Goutte1-3/+3
[-Wdocumentation] Change-Id: I66af53ee06866b45339814b5fa949551c0dd45c1 Reviewed-on: https://code.wireshark.org/review/6535 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-01-15Fix the compile: Use the new (double) variable.Jeff Morriss1-1/+1
Change-Id: I38a9b0f55e9f19fe7f4f09f5eec2817dd822c6d0 Reviewed-on: https://code.wireshark.org/review/6542 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
2015-01-15Fix a crash in the GTK+ RTP Streams dialog.Gerald Combs1-2/+9
Make sure we copy guint, gdouble, and gchar * data to variables of the correct type. Fixes a crash when trying to copy CSV data (we were trying to stuff a gdouble into a char *). Change-Id: I3cbcc48216a078f85f13860d14707f309b9820d7 Reviewed-on: https://code.wireshark.org/review/6541 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-01-15Fix indentation.Gerald Combs1-35/+35
Change-Id: I089d18d6dde56c04d75f7c991511728a0a66f699 Reviewed-on: https://code.wireshark.org/review/6540 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-01-14CMake: Look for FOP and HHC only when needed.Gerald Combs2-26/+33
FOP is only required for generating PDF output and HHC is only needed for CHM output. Don't look for them unconditionally. Change-Id: I7bec7d061c9e9e8b99431cab873e8c719469552c Reviewed-on: https://code.wireshark.org/review/6539 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-01-14CMake: Update windeployqt discovery.Gerald Combs1-6/+7
Update the comments and add a URL. Use HINTS, which is more correct according to the documentation. Change-Id: I82a7e2790dfa0b398e2b534f9f45851f55bdc0d2 Reviewed-on: https://code.wireshark.org/review/6536 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-01-14CMake: Copy Qt DLLs to the target directory.Gerald Combs1-0/+24
Add a "copy_qt_dlls" target similar to "copy_cli_dlls". Wireshark.exe must exist before windeployqt can be run, so we can't create a PRE_BUILD target. Add copy_qt_dlls to the default target instead. Change-Id: If85d89478472b10b31229413465955fe98b0ef02 Reviewed-on: https://code.wireshark.org/review/6529 Petri-Dish: Gerald Combs <gerald@wireshark.org> Reviewed-by: Graham Bloice <graham.bloice@trihedral.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-01-14CMake: Copy wireshark-gtk dependent DLLs to the target directory.Gerald Combs3-2/+168
Add a "copy_gtk_dlls" target similar to "copy_cli_dlls". Change-Id: Id1df1d0ec00c46fccec90c4b8c0c8a2d2a14766a Reviewed-on: https://code.wireshark.org/review/6527 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Graham Bloice <graham.bloice@trihedral.com> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-01-14[E212]Modify dissect_e212_mcc_mnc() to take E212 number type as anAndersBroman31-74/+74
argument. While at it remove deprecated APIs Change-Id: Ib1a7e9d7aeba6379fb4492816a0ac602e67493c6 Reviewed-on: https://code.wireshark.org/review/6534 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-01-14Minor Development Guide updatesGraham Bloice2-13/+14
Corrected info about paths to built executable. Cross referenced empty debugger sections to the section with info. Change-Id: I4366825990f1a5286c7292c9f00e540160c1b5d0 Reviewed-on: https://code.wireshark.org/review/6520 Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
2015-01-14HTTP: allocate header_name in packet scope instead of file scopePascal Quantin1-4/+2
While we are at it, factorize the copy of value string Change-Id: I2a16155641b8bd8623baf51f787a5f450e7b3803 Reviewed-on: https://code.wireshark.org/review/6530 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-01-13Consistently use the "g_string_free returns a C string pointer" idiom.Guy Harris25-112/+63
g_string_free(str, FALSE) frees the GString container but not the underlying g_malloc()ed string; instead, it returns a pointer to the g_malloc()ed string. Fix those places that didn't already get the string pointer from g_string_free() to do so rather than manually extracting the string themselves. And fix one place that didn't even need to use a string - it was just scanning a C string without even modifying it. Change-Id: Ibbf4872bf5b9935b9907f539b6edb1013f3053a5 Reviewed-on: https://code.wireshark.org/review/6532 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-01-13uat_load() and uat_save() return a success indication; use it.Guy Harris6-36/+31
Instead of always ignoring the return value, always check it, and only report an error if it returns FALSE. (Alternative: have it return NULL on success and a pointer to a g_malloc()ed string on failure.) Fix a comment while we're at it. Change-Id: Icb72c9f47775b6552e3eb4fe5ddcc85482bfb5fb Reviewed-on: https://code.wireshark.org/review/6528 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-01-13MAC LTE: upgrade dissector to v12.4.0Pascal Quantin5-110/+555
Change-Id: Ieb5395a6ae7a1d7625fe645d0caf14008993d3d9 Reviewed-on: https://code.wireshark.org/review/6521 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-01-13UAT error string pointers should not be const pointers.Guy Harris37-75/+80
UAT error strings are usually allocated by g_strdup() or g_strdup_printf(), and must ultimately be freed by the caller. Make the pointer-to-error-string-pointer arguments to various functions be "char **", not "const char **". Fix cases that finds where a raw string was being used, as that won't work if you try to free it; g_strdup() it instead. Add a missing free of an error string. Remove some no-longer-necessary casts. Remove some unnecessary g_strdup()s (the string being handed to it was already g_malloc()ated). Change some variable declarations to match. Put in XXX comments for some cases where the error string is just freed, without being shown to the user. Change-Id: I40297746a2ef729c56763baeddbb0842386fa0d0 Reviewed-on: https://code.wireshark.org/review/6525 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-01-13CMake: Copy libwireshark dependent DLLs to the target directory.Gerald Combs13-30/+363
Add a "copy_cli_dlls" target which copies the DLLs required to run our command line programs to the run directory. Fix the spelling of "KERBEROS". Start filling in variables so that we can populate config.nsh. Change-Id: I9b3ed912dfbffecbf09f2893efa2c9d82e709521 Reviewed-on: https://code.wireshark.org/review/6513 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-01-13[GPRS CDR]Fix faulty ASN1 modificationAndersBroman2-2/+7
Should be: egsnPDPRecord [70] EGSNPDPRecordV750 Change-Id: I4b03524c09b6ce603cf4783144d588c8839a16e6 Reviewed-on: https://code.wireshark.org/review/6523 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-01-13[GPRS CDR] Handle Rel 7 CDRsAndersBroman3-193/+718
Change-Id: I09833a326e486273c3eacaceba0963fe88e0dac6 Reviewed-on: https://code.wireshark.org/review/6522 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-01-13When allocating address structures, use wmem_new0().Guy Harris3-8/+8
For structures used as the data in an address, use wmem_new(), so that structure padding is zeroed out; the comparison code for addresses compares all bytes of the structure for addresses that are structures, and the hashing code for hash tables using addresses as keys hash all the bytes, so we have to make sure that, for addresses that are the same, *all* bytes are the same. Change-Id: I995fd26cc2f20edb5a599f95562b720561708e57 Reviewed-on: https://code.wireshark.org/review/6517 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-01-13Do bounds checking when decompressing WCP packets.Guy Harris1-34/+82
Extract the data offset and count only once, and make sure we don't run past the end of the data we've copied from the packet; have decompressed_entry() just do the decompression, rather than also fetching the data offset and count. Add some comments while we're at it. Bug: 10844 Change-Id: I2dc2f9594422ffa8f15fd5c57c9dac2e30e363f4 Reviewed-on: https://code.wireshark.org/review/6514 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-01-13Fix ASCIIDOC detection broken by commit ae2888aeb2b418c9f62Jörg Mayer1-1/+1
Change-Id: I36cd42a9040e8f8ab2b11ff4211a1298663909a2 Reviewed-on: https://code.wireshark.org/review/6512 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2015-01-12Fix casting compiler warningMichael Mann1-1/+1
Change-Id: I179706042168cb4fd1bfb5f9c573f302d9d62fa0 Reviewed-on: https://code.wireshark.org/review/6506 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-01-12Remove ep_strbuf codeEvan Huus4-199/+0
Thanks to Michael's work, it is now totally unused. Change-Id: I67b5f7c69535a08f96f449c36c429e2548f4ea11 Reviewed-on: https://code.wireshark.org/review/6505 Petri-Dish: Evan Huus <eapache@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Evan Huus <eapache@gmail.com>
2015-01-12Error out if the user requests the SBC library but it's not found.Jeff Morriss1-3/+6
Change-Id: I7c152420703d0d37c7b29d3c8f535b17180e020a Reviewed-on: https://code.wireshark.org/review/6455 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
2015-01-12Remove emem APIs from UAT functionality.Michael Mann24-160/+276
Change-Id: I009c09f25d170e5c9aaaef713eaacb3252817856 Reviewed-on: https://code.wireshark.org/review/6460 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Evan Huus <eapache@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-01-12[GPRS CDR] Add expert info for unknown record types.AndersBroman3-5/+38
Change-Id: Ib485f435b6c423b06c7c31f2cf681d01261bfc15 Reviewed-on: https://code.wireshark.org/review/6504 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-01-12Fix Cygwin pathGraham Bloice2-2/+2
Fix the Cygwin path added for tests so that Cygwin comes after the existing path and that the correct link command is found for exntest. Same change to runa2x.sh to be consistent. Change-Id: I177a5e7d17a0077b0e8ca7d264d7e725a5312e24 Reviewed-on: https://code.wireshark.org/review/6503 Petri-Dish: Graham Bloice <graham.bloice@trihedral.com> Reviewed-by: Graham Bloice <graham.bloice@trihedral.com> Tested-by: Graham Bloice <graham.bloice@trihedral.com>
2015-01-12Fix Cygwin path in runa2x.shGraham Bloice1-1/+4
As I don't have Cygwin on the path, the uname -o call failed. The method used here seems to work reliably without needing Cygwin on the path. Change-Id: I206db542b5e89895a43c48626e2d14fff380fc8f Reviewed-on: https://code.wireshark.org/review/6497 Petri-Dish: Graham Bloice <graham.bloice@trihedral.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
2015-01-12Make running the tests a little easier on WindowsGraham Bloice1-3/+8
1. Set the igncr option a little differently, this is the preferred way according to the latest Cygwin bash update announcement (See https://sourceware.org/ml/cygwin-announce/2014-10/msg00015.html, Sect 4a) The previous way didn't work for me. 2. Ensure /usr/bin is on the path if running under Cygwin. I really don't want Cygwin on my normal paths, the build process adds if required, so this change makes the test scripts do the same. Change-Id: I0f4da1fa87802bf0a4039bb5a91e577fae506d79 Reviewed-on: https://code.wireshark.org/review/6243 Tested-by: Graham Bloice <graham.bloice@trihedral.com> Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Graham Bloice <graham.bloice@trihedral.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
2015-01-12[E212] Make it possible to use different filters for MCC and MNC in LAIAndersBroman7-21/+82
RAI and SAI. Change-Id: I2abcc868899b8752f66347b3a0fe190670c3ce3f Reviewed-on: https://code.wireshark.org/review/6447 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-01-12msg_rng_rsp (Wimax): fix Copy-paste error (CID 11158604)Alexis La Goutte1-1/+1
Change-Id: I134d8178d741d741404963a89f60e1d1bfd9a2dd Reviewed-on: https://code.wireshark.org/review/6473 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-01-12ISIS: Add code and length for SubTLV Extended IS ReachabilityAlexis La Goutte1-25/+85
* remove some proto_tree_add_text call Change-Id: I18bc26cc95934e77b19d24edbb417af4c895d53e Reviewed-on: https://code.wireshark.org/review/6468 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-01-12Add DJI UAV Drone Control Protocol to the list of new protocols.Jeff Morriss2-20/+20
(This change also brings NEWS up to date with release-notes.asciidoc) Change-Id: Ie61c27901947210ddf95bbb1bb8c36e489bc0c8c Reviewed-on: https://code.wireshark.org/review/6456 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-01-11Use the GTK+ 2 name for VoidSymbol.Guy Harris1-1/+1
We can use the GTK+ 2 GDK_xxx names with GTK+ 2 or 3; apparently, some versions of GTK+ 2 don't support the GDK_KEY_xxx names. Change-Id: I52b14a7f2273f2af2b914c3646eb33d21673057e Reviewed-on: https://code.wireshark.org/review/6498 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-01-11Fix CMake generation and use of Windows .rc filesGraham Bloice44-72/+390
CMake now generates local copies of .rc files for all the Windows components and uses the files in the build of the components. The .rc.in files that include an icon were modified to allow the icon path to be set by CMake. The path is removed for nmake builds. Updated build architecture detection, required for wireshark.manifest.in Change-Id: I7b1ff43050e9b0efb861d1041636fb4aef49a4f8 Reviewed-on: https://code.wireshark.org/review/6482 Petri-Dish: Graham Bloice <graham.bloice@trihedral.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
2015-01-11Revert "Lemon: Update lemon tools"Pascal Quantin9-730/+586
This reverts commit 5855dd8d538eb81d4825961b1bf0d583bf96f751. This Lemon update fails to compile on OSX and triggers asserts on other platforms Change-Id: I12a8a2bf32db31e5a9b0cb1a67a39724e30f3e91 Reviewed-on: https://code.wireshark.org/review/6496 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-01-11Fix some more regressions introduced in gecaa1f8Pascal Quantin2-36/+33
Convert one other set of static variables to pinfo scoped memory while we are at it Change-Id: If550b76ef6a4dd2707d79de8579ac439d16dce79 Reviewed-on: https://code.wireshark.org/review/6490 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-01-11Lemon: Update lemon toolsAlexis La Goutte9-586/+730
Fix warning: declaration shadows a variable in the global scope [-Wshadow] Add include <config.h> Fix warning: unused parameter 'argc' [-Wunused-parameter] (using _U_) Fix implicit conversion loses integer precision Fix comparison of integers of different signs: 'size_t' (aka 'unsigned long') and 'int' [-Wsign-compare] Fix function declaration isn’t a prototype [-Wstrict-prototypes] Fix warning: old-style function definition [-Wold-style-definition] Fix trailing whitespace Fix use -T for template for epan\Makefile.nmake, epan\dfilter\Makefile.nmake, plugins\mate\Makefile.nmake, plugins\tpg\Makefile.nmake and cmake/modules/UseLemon.cmake Fix -Wmissing-prototypes Remove unused function (acttab_free) Add basename the filename with only filename (no path...) Change-Id: Ia79f61e29f828575df61cc89134c6c553044e86d Reviewed-on: https://code.wireshark.org/review/3976 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-01-11gtk: fix crash on Broadway GDK backendPeter Wu1-26/+34
The Broadway GDK backend does never sets event->string. This results in a crash when filter_string_te_key_pressed_cb tries to read its contents. Since the documentation marks reading the string as deprecated, try to handle the character conversion here. It is based on _gdk_x11_event_translate_keyboard_string (from gtk+), but without trying to interpret Escape as '\033', and without trying to convert control characters (example: Ctrl + 1). A buffer of 6 bytes is used to hold a UTF-8 code point (there is no zero terminator, so 7 bytes as found in the original implementation is unnecessary). As g_locale_from_utf8 returns dynamically allocated memory, change the control flow to have a single exit point where pointers are freed as needed. Reproduce with gtk3: $ broadwayd :5 $ GDK_BACKEND=broadway BROADWAY_DISPLAY=:5 wireshark-gtk (now open http://localhost:8085/ and start typing in the display filter) Keys tested: e € (AltGr + 5) ü (AltGr + ", u) In the X11 backend, these still get displayed correctly. In the broadway backend however, the accents are missing due to a bug in the broadway implementation. Change-Id: Ic1f0ee2b87cd573023ee8e966f06489b3b744dcf Reviewed-on: https://code.wireshark.org/review/5832 Reviewed-by: Balint Reczey <balint@balintreczey.hu>
2015-01-11CMake: Try to fix Cygwin a2x discovery.Gerald Combs1-9/+13
Change-Id: I46ddd10ab533ff7114aa6a4241a9a261da19329c Reviewed-on: https://code.wireshark.org/review/6487 Petri-Dish: Graham Bloice <graham.bloice@trihedral.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>