summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2016-11-05travis: move osx first.Dario Lombardo1-1/+1
Change-Id: I08f65a6b5bcc78c4a74ed9f1488bca07cc6a1fd5 Reviewed-on: https://code.wireshark.org/review/18670 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-11-04bthci_acl: Always show data itemStig Bjørlykke1-4/+13
Always add the Data (Fragment) item, also for the last frame. Also add link to "Reassembled in #" for all except the last frame. The reassembly logic should be rewritten to use reassemble.h functions to be able to show the fragments frame list, fragment count and reassembled length items. Change-Id: Ib0e17711e182178d0b7ea0fd6903a9144adb757d Reviewed-on: https://code.wireshark.org/review/18659 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2016-11-04Bluetooth: HCI: LE: address review comments from review/18661.Sharvil Nanavati1-4/+4
Change-Id: Ibb97970e38d98f3564eb57995f3f31bebe88cc13 Reviewed-on: https://code.wireshark.org/review/18674 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2016-11-04debian-setup: remove libssh-gcrypt-dev from trusty.Dario Lombardo1-2/+2
Change-Id: I62080885a0f9a99ee02ecae8e67caefcefdea0e4 Reviewed-on: https://code.wireshark.org/review/18660 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Balint Reczey <balint@balintreczey.hu> Reviewed-by: Dario Lombardo <lomato@gmail.com>
2016-11-04Bluetooth: HCI: Add missing Core4's cmd/evt identifiesMichal Labedzki2-5/+221
Add a lof of Command Opcodes. Implement trivial Event: "Inquiry Response Notification" and "Get MWS Transport Layer Configuration" Change-Id: I4ca13878e2f972caae4320e9c0149dc3d75c45a5 Reviewed-on: https://code.wireshark.org/review/18668 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2016-11-04Qt/Bluetooth: Split LE Meta EventsMichal Labedzki4-6/+177
Add 3rd level subtree in Event->LE Meta, because of existance of "Subevent" which is in similar thing to Event or Opcode in CommandComplete. Change-Id: Ib732ab417c5141251736b608de2e4e64b702c20a Reviewed-on: https://code.wireshark.org/review/18667 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2016-11-04Bluetooth: HCI: LE: Dissect all LE FeaturesMichal Labedzki1-22/+79
The implementation is up to Core 4 specification. Change-Id: I3fc3f06f8ec6bdd488cff109bdbca275cd0f0121 Reviewed-on: https://code.wireshark.org/review/18666 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2016-11-04Bluetooth: HCI: LE: Implement missing Meta EventsMichal Labedzki2-1/+106
1. LE Remote Connection Parameter Request 2. LE Data Length Change 3. LE Read Local P-256 Public Key Complete 4. LE Generate DHKey Complete 5. LE Enhanced Connection Complete (implies more meta-info present) Change-Id: I4aac5b66808cd15cc5b6825429b2bff848aa88b4 Reviewed-on: https://code.wireshark.org/review/18665 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2016-11-04Bluetooth: Update Assigned Numbers: CompanyIDsMichal Labedzki1-5/+164
It comes from: https://www.bluetooth.com/specifications/assigned-numbers/Company-Identifiers To meet Wireshark requirements make them ASCII in case of some vendors. Change-Id: I66b8ce5a1bc6af03fae6efa18e594d83b586be38 Reviewed-on: https://code.wireshark.org/review/18664 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2016-11-04Implement dissector for the LE Enhanced Connection Complete event.Sharvil Nanavati1-0/+89
BLE connections that use this event cannot be fully decoded since the connection handle is unknown to Wireshark. Change-Id: I56eb6fc7c918b235fb1d68d89b6f1f2847e648e1 Reviewed-on: https://code.wireshark.org/review/18661 Reviewed-by: Sharvil Nanavati <sharvil@playground.global> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2016-11-03USB Audio: Fix dissection of unit descriptors missing the iFeature fieldAlexis La Goutte1-4/+6
Issue reported by Vladimir Vysotsky Bug: 13085 Change-Id: Ibdc1bf662f852818777cfb44fa19d798972390ca Reviewed-on: https://code.wireshark.org/review/18651 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-11-03autotools: propagate git version info to distribution tarballPeter Wu2-8/+25
Store the git describe output in the distribution tarball (make dist) and ensure that this version is always used for builds from this tarball. This will prevent the useless "Git Rev Unknown from unknown" output in tar-based builds. It will also prevent git from being invoked in tarball builds. Remove the git branch name since the commit ID (and git tag) in the git describe output is sufficient to identify the source tree. (In SVN, a revision ID had to be paired with a branch name to identify the source tree, in git this is no longer the case.) Change-Id: Iffe142b6efd81e857802eb604d6310cfd301d207 Reviewed-on: https://code.wireshark.org/review/18415 Reviewed-by: João Valverde <j@v6e.pt> Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Dario Lombardo <lomato@gmail.com>
2016-11-03wsutil: add initializer (found by clang ccc).Dario Lombardo1-1/+1
Warning: wireshark/wsutil/strtoi.c:113:1: warning: The left operand of '<' is a garbage value DEFINE_WS_STRTOI_BITS(32) ^~~~~~~~~~~~~~~~~~~~~~~~~ wireshark/wsutil/strtoi.c:83:12: note: expanded from macro 'DEFINE_WS_STRTOI_BITS' if (val < 0) \ ~~~ ^ wireshark/wsutil/strtoi.c:114:1: warning: The left operand of '<' is a garbage value DEFINE_WS_STRTOI_BITS(16) ^~~~~~~~~~~~~~~~~~~~~~~~~ wireshark/wsutil/strtoi.c:83:12: note: expanded from macro 'DEFINE_WS_STRTOI_BITS' if (val < 0) \ ~~~ ^ wireshark/wsutil/strtoi.c:115:1: warning: The left operand of '<' is a garbage value DEFINE_WS_STRTOI_BITS(8) ^~~~~~~~~~~~~~~~~~~~~~~~ wireshark/wsutil/strtoi.c:83:12: note: expanded from macro 'DEFINE_WS_STRTOI_BITS' if (val < 0) \ ~~~ ^ 3 warnings generated. Change-Id: I9eef0f2c0d4500531655a8b43509205a1f4e0684 Reviewed-on: https://code.wireshark.org/review/18640 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-11-03Fragmentation reassembly as in PPP MP (RFC 1990/2686)John A. Thacker5-37/+592
Add support for defragmentation of fragments that use the defragmentation scheme of PPP MP (RFC 1990). Instead of getting "sequence_number, fragment_number, last" as in other protocols, PPP MP provides a single sequence number that is effectively "seqnum + fragnum", though it provides flags for both the first and last fragment of a reassembly. See Appendix A of RFC 4623 (PWE3 Fragmentation and Reassembly) for a list of protocols that use this style, including PPP MP (RFC 1990), PWE3 MPLS (RFC 4385), L2TPv2 (RFC 2661), L2TPv3 (RFC 3931), ATM, and Frame Relay. Also add support for the Multi-class Extension to Multilink PPP (RFC 2686), which uses some of the previously reserved bits as classes that distinguish otherwise identical sequence numbers. Bug: 12548 Change-Id: Ic2ce3c50e61ab2eb50e4d92fd353ca4d2a48fe18 Reviewed-on: https://code.wireshark.org/review/16327 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-11-03packet-bthci_cmd.c: Fix typos found by lintian.Michael Mann1-2/+2
Change-Id: I7fd66fadd1cc42951745710ef06613ef098c572d Reviewed-on: https://code.wireshark.org/review/18641 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-11-03Fix lintian found spelling error "identifer" -> "identifier"Michael Mann3-4/+4
Change-Id: I78281ce097e36df546338a5dacb03a11bedd2b24 Reviewed-on: https://code.wireshark.org/review/18642 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-11-03Fix lintian found spelling error "occurence" -> "occurrence"Michael Mann3-3/+3
Change-Id: I4fcff029ec15a1627dde0d311b063a249f0e0c0a Reviewed-on: https://code.wireshark.org/review/18643 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-11-03Fix lintian found spelling error "occured" -> "occurred"Michael Mann3-6/+6
Change-Id: I6010669b880b772ba4a22f13ba03fe48b438e8b7 Reviewed-on: https://code.wireshark.org/review/18644 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-11-03Fix lintian found spelling error "splitted" -> "split"Michael Mann3-7/+7
Change-Id: I4b00ef460ae1792cd6f14856493f7a58ab8e0b9a Reviewed-on: https://code.wireshark.org/review/18645 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-11-03Fix lintian found spelling error "Reciever" -> "Receiver"Michael Mann1-1/+1
Change-Id: I51a0c5a7eb69e5ba06dc01ee3be269f61cb02cf4 Reviewed-on: https://code.wireshark.org/review/18646 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-11-03Fix lintian found "grammar" error "allow to" -> "allowed to"Michael Mann1-2/+2
Change-Id: I4dd0e42df00ab27073b55cfce7da173b0e9dab00 Reviewed-on: https://code.wireshark.org/review/18647 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-11-03RTS_FLAG_NONE is a flags field value, but it's not a flag bit.Guy Harris1-5/+7
It's the *absence* of flag bits, so you can't test whether it's set; don't have a field for it. This gets rid of a dissector assertion. Add some more URLs for information about DCE RPC and MS-RPC. Change-Id: I53e8f11692c66e16ae2ec7fd4ba8eb90b0673da4 Reviewed-on: https://code.wireshark.org/review/18648 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-11-02proto: Decode negative values in a bitmask fieldThomas Wiens1-12/+114
Allows to use negative values (FT_INT) in a bitmask field. If a field type greater or equal (FT_(U)INT40) is used then also a 64 bit value string and 64 bit format function must be used. Change-Id: Ib86d45bee73a71a784068ab717d35810c6f48017 Reviewed-on: https://code.wireshark.org/review/18601 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-11-02[PER] Use tvb_new_octet_aligned().Anders1-39/+32
Change-Id: Ib29f3cb5b670b4e6e5432922a160f2eb4b780aae Reviewed-on: https://code.wireshark.org/review/18473 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-11-02btl2cap: Initialize reassembly valuesStig Bjørlykke1-8/+2
Values in psm_data structure used in reassembly must be initialized to zero to ensure that the reassembly logic works. Change-Id: I47c636dde60f28a8dcd9a366664fd23019a12323 Reviewed-on: https://code.wireshark.org/review/18633 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-11-02sshdump: use g_shell_quote in the right way.Dario Lombardo1-1/+1
Change-Id: I3f71dabe92d3b00192f36fc57ebb7673b2327620 Reviewed-on: https://code.wireshark.org/review/18623 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2016-11-02Bugfix dissection of DCP-ETSIJulian Cable1-21/+12
Fix root cause in dissect_af Bug: 12252 Change-Id: Ia20fc7bad39e80062e177b4ddd7c7bb87accf328 Reviewed-on: https://code.wireshark.org/review/14644 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-11-02TLS(1.3): Add new AlertAlexis La Goutte1-0/+3
Change-Id: Ice365bf3ca2198b3d81994a5670ac50add3e53dc Reviewed-on: https://code.wireshark.org/review/18620 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-11-02opa-mad: Fix several issues with the SA and SM parse functionsAdam Goldman1-266/+197
Add support for SA(PortGroupTableRecord). Fixed parse errors in SA(CableInfoRecord), SA(BufferControlTable), SA(PathRecord), SA(PortInfo), & SM/SA(SMInfo). Moved SA(FabricInfoRecord) to be in SA Sections. Remove the attribute modifier 'ALL' bit being incorrectly used in SM/SA. Add support for the valid case when SA returns with zero records and a none zero MAD status. Change-Id: I9bdc87d113be045132a78ecf5c8b4ffa3ac29900 Signed-off-by: Adam Goldman <adam.goldman@intel.com> Reviewed-on: https://code.wireshark.org/review/18629 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-11-02ieee802.15.4: fix small typoRémy Léone1-1/+1
Change-Id: I23c58ef5cbf116402d25089bae3d83168b8af974 Reviewed-on: https://code.wireshark.org/review/18632 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-11-02Update .mailmapAlexis La Goutte2-6/+10
Change-Id: I9962ced39ce3fd31cff446a99ba1c0b6ebfb1bbf Reviewed-on: https://code.wireshark.org/review/18596 Reviewed-by: Erik de Jong <erikdejong@gmail.com> Reviewed-by: Anish Bhatt <anish@gatech.edu> Reviewed-by: Francisco Javier Sánchez-Roselly <franciscojavier.sanchezroselly@ujaen.es> Reviewed-by: Mikael Kanstrup <mikael.kanstrup@gmail.com> Reviewed-by: Franklin Mathieu <snaipe@diacritic.io> Reviewed-by: Boris Bochkaryov <Boris-Bochkaryov@yandex.ru> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-11-02make-version.pl: fix --print-vcs outputPeter Wu1-13/+17
Detect earlier whether to write VCSVERSION to version.h such that the --vcs-version output matches the contents of version.h. Change-Id: I5c05087679bb7861cd5884426b39fa362bf23a16 Fixes: v2.1.0rc0-2770-geeded81 ("Add option to disable version.h") Reviewed-on: https://code.wireshark.org/review/18599 Reviewed-by: João Valverde <j@v6e.pt> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-11-02Openflow (v4/v5): Add vOXM vlan mask fieldAlexis La Goutte2-0/+20
Bug: 12979 Change-Id: I7f0e806081704dfeaf40ce1e4e41271ffd5e3023 Reviewed-on: https://code.wireshark.org/review/18618 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-11-02FIX: fix spelling typo found by lintianAlexis La Goutte5-6/+6
Change-Id: I3616de3ecd7ca52f2da4af13f35967eeed61414e Reviewed-on: https://code.wireshark.org/review/18613 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-11-02btatt: fix spelling typo found by lintianAlexis La Goutte1-8/+8
Change-Id: I3fdc71e927bdb0d5408db46656c23b23dc31489a Reviewed-on: https://code.wireshark.org/review/18621 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2016-11-02SNA: fix dissection of GDS VariablesPascal Quantin1-11/+26
Decode the header as specified in http://www.retrocomputing.net/info/doc/GA27-3136-20_SNA_Formats.pdf chapter 13. Note that the Information field is not decoded yet. Bug: 13084 Change-Id: Iaaee344ef0b2805906a3eeae1134479abf9d403e Reviewed-on: https://code.wireshark.org/review/18616 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-11-02Packaging: Add dependencies for lz4 and snappy packagesBenoît Canet5-4/+35
Do it for Debian-like, RPM-based, and MacOS (via Homebrew) systems. Signed-off-by: Benoît Canet <benoit@scylladb.com> Signed-off-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Change-Id: I52802301815243021c039da6a27af6c534792439 Reviewed-on: https://code.wireshark.org/review/18272 Reviewed-by: Benoît Canet <benoit@scylladb.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com> Reviewed-by: Dario Lombardo <lomato@gmail.com>
2016-11-02Qt: add "search authors" feature.Dario Lombardo3-11/+39
Add a search field in the authors tab. The list of authors has became huge and it's very hard to find someone in it. Having a fast way to search yourself or your friends would be fun. Change-Id: I0c6a5e8d5893d6f7b5a3258e63bdc91969f53d31 Reviewed-on: https://code.wireshark.org/review/18594 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Dario Lombardo <lomato@gmail.com>
2016-11-02pre-commit: fix indentAlexis La Goutte1-1/+1
Change-Id: I50291be3fd275cde8af42c45c17e52345d1c6215 Reviewed-on: https://code.wireshark.org/review/18619 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-11-02Fix some errors.Guy Harris1-49/+7
Th link throughput and latency objects are just 32-bit integers; process them as such and, as they're bytes-per-second and microsecond values, respectively, show them as decimal, rather than as hex, as most of us have 10, not 16, fingers. The ETX metric object is a 16-bit integer; process it as such, and show it in decimal as well. Attach an expert info representing an error to the item in error. Change-Id: I57dfac0127d263724cc6940a0457d63e17616b64 Reviewed-on: https://code.wireshark.org/review/18617 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-11-02Add snappy compression library setupJoerg Mayer1-0/+52
Change-Id: I060d3056dc386f44aec703ddd0fe024866a51fcf Reviewed-on: https://code.wireshark.org/review/18611 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2016-11-02Validate the Diameter XML files in the pre-commit script.Jeff Morriss2-7/+17
Validation requires xmllint but will pass (with a complaint) if the committer does not have xmllint installed. Change-Id: I336a1c8ad8e1f98805a284d8c4736810b1a9c54e Reviewed-on: https://code.wireshark.org/review/18609 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-11-02opa-mad: Fixed malformed SA(FabricInfoRecord) reserved fieldAdam Goldman1-2/+2
Change-Id: I1b20a49008e41728cb10cd11765833a762f66505 Reviewed-on: https://code.wireshark.org/review/18603 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-11-02Add a few more T6a/T6b and charging AVPs.Jeff Morriss2-1/+136
Fix a mistake in a comment. Change-Id: Ibb12ff3036fb42fe5e3955c67c7c9989f8ffca63 Reviewed-on: https://code.wireshark.org/review/18610 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-11-02Move Base32_encode from packet-fc00.c to wsutil (as ws_base32_decode)Michael Mann6-45/+146
There could be some reuse out of it, so but it with the rest of the general utilities. Change-Id: I404c135b933660a82678510b9ca2701985c5632a Reviewed-on: https://code.wireshark.org/review/18589 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-11-02packet-infiniband: Fixed IP based connections & other minor fixesParav Pandit2-67/+133
1. Fixed setting right address type instead of AT_IB for RoCE and RRoCE depending on address type given by pinfo where address type would be IPv4 or IPV6. Fail to do so was resulting into infiniband dissector adding conversation info based on AT_IB type vs payload dissectors dissecting based on pinfo. Fixing this allows to add/search based on right address type. (Tested for Infiniband and RRoCE) 2. Added support to pass already parsed CM attribute id from infiniand to other mad private data dissectors so that right dissection of private data can be done based on CM attribute id (message type). Moved CM attribute id definitions to header file so that private data dissectors based on CM attribute id can reuse these values without duplicate defines. (Tested for Infiniband and RRoCE) 3. Added direction client to server/server to client, (active/passive) to conversation_data for payload dissectors which cannot dissect only based on payload content without knowing the direction. (Tested for RRoCE) 4. Fixed IP CM to claim all 92 bytes of private data (including consumer private data), instead of just 36 bytes of header because its part of IP CM private data. (Tested for Infiniband and RRoCE) 5. Fixed MAD header to claim all 232 (256-24) bytes of data as it belongs to it in the tree. (Tested for Infiniband and RRoCE) 6. Fixed getting ip version by performing AND operation first to extract IP version field. (Tested for RRoCE-IPV4 and Infiniband) Change-Id: I37daca6a089784b61c25e10cdc8f3cf028ca8c58 Tested-by: paravpandit@yahoo.com Reviewed-on: https://code.wireshark.org/review/18573 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Petri-Dish: Anders Broman <a.broman58@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-11-02Small fixes for JSON outputPascal Quantin1-4/+6
- reinitialize the variable used to insert comma between packets when performing a new export - ensure that escaped ASCII characters are code on 4 digits characters Change-Id: Ib557da4843f6b98f793b60e417260ebb27a38b99 Ping-Bug: 13073 Reviewed-on: https://code.wireshark.org/review/18598 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-11-02gtp: fix and improve user location informationJoakim Karlsson1-69/+93
* Fixed RAI which was broken * Improved CGI and SAI Change-Id: I1807b628ef54e2f3e94551c26301f1376bef0914 Reviewed-on: https://code.wireshark.org/review/18604 Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-11-02Add lz4 setup.Joerg Mayer1-0/+52
Change-Id: If3b51e719a0a745eac0862f882b912e1d0f72587 Reviewed-on: https://code.wireshark.org/review/18608 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2016-11-02gtp: correction of octet14 in QoSProfileJoakim Karlsson1-10/+20
* Added Spare4 * Corrected order Change-Id: I93384452d73bd519784b8c11ab5671797d16fc99 Reviewed-on: https://code.wireshark.org/review/18606 Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>