summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2009-07-03From: Tobias Witek: Fix processing of radius 'vendor specific attributes'Bill Meier2-3/+12
In the RADIUS dissector, the function radius_register_avp_dissector() registers vendors that are not already present in the dictionary hash-table. As far as I can see, there are two problems with this: 1. The function does not set the number of type/length octets and the has_flags variable for that AVP, which is required to correctly decode AVP/VSA values 2. In some situations, the function is called _before_ radius_load_dictionary() is called (for example for the vendor 3GPP (ID: 10415)) Therefore, all vendor entries that are created by calling radius_register_avp_dissector() leave their type_octets and length_octets un-initialized, which causes incorrect decoding. [Result: Radius dissector displays messages such as: "Malformed Packet: RADIUS" and "Error/Malformed: Malformed Packet(Exception occurred)"] The attached patch fixes this problem by assuming that the dictionary knows the 'ground truth' about the type/length octet and the has_flags information and allows it to overwrite these values even for vendors that have already been loaded. Also: (from Bill Meier): set the type/length octet and the has_flags variables to default "standard" values (1,1,FALSE) in radius_register_avp_dissector(). Fixes Bug #3651 (and Bug #3635). https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3651 https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3635 svn path=/trunk/; revision=28937
2009-07-03Fix:Anders Broman3-3/+19
packet-ndmp.c:562: warning: unused parameter 'pinfo' svn path=/trunk/; revision=28936
2009-07-03From Chris Costa:Anders Broman1-40/+366
NDMP fragmentation fix. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3395 svn path=/trunk/; revision=28935
2009-07-03Make the compiler on Mac OS X happy...Michael Tüxen2-13/+13
svn path=/trunk/; revision=28934
2009-07-03update to the latest PROFINET draftsUlf Lamping2-42/+243
(defragmentation of RT fragments "FRAG-PDU" is still not implemented) svn path=/trunk/; revision=28932
2009-07-03From Kovarththanan Rajaratnam: Fixes for bug #3536Bill Meier2-31/+34
(plus some additional changes by me). Handle BASE_RANGE_STRING display types properly We always treat header field info strings as value_string's undiscriminated. However, if the header field info display is marked as BASE_RANGE_STRING, we need to treat them as range_string's. This wasn't properly handled in the filter expression dialog and in the filter toolbar which would cause a crash upon referencing any fields marked as BASE_RANGE_STRING. svn path=/trunk/; revision=28931
2009-07-03Try to allocate enough memory on all platforms.Gerald Combs1-6/+6
svn path=/trunk/; revision=28930
2009-07-02Get it compiling with -DNEW_PACKET_LIST on Mac OS X.Michael Tüxen2-2/+2
svn path=/trunk/; revision=28929
2009-07-02Allow the new packet list's columns to be moved backStephen Fisher1-0/+1
and forth while the packet list is open without having to go into the preferences. The new column ordering is not saved for next time though. Perhaps it should be. svn path=/trunk/; revision=28928
2009-07-02From Kovarththanan Rajaratnam via bug 3567:Gerald Combs1-16/+4
The template cache contains pointers that are session-scope (only freed in netflow_reinit()) but still we use g_malloc(). This patch changes that so we now use se_alloc(). With this patch I'm able to reproduce the crash ("Per-session memory corrupted"). svn path=/trunk/; revision=28927
2009-07-02Update documentation links.Gerald Combs1-1/+4
svn path=/trunk/; revision=28926
2009-07-02Don't dump out the raw link-layer type when noting thatGuy Harris1-2/+5
KHciLoggerDatalinkTypeBCSP and KHciLoggerDatalinkTypeH5 aren't supported - just explicitly say "BSCP" or "H5". For unknown link-layer types, say "unknown or unsupported", as other Wiretap modules do. svn path=/trunk/; revision=28925
2009-07-02Patch from Alex Badea for Bug 3645.Michael Tüxen1-2/+2
This fix will be included in Wireshark 1.2.1. svn path=/trunk/; revision=28924
2009-07-02mkstemp cleanups.Gerald Combs2-6/+0
svn path=/trunk/; revision=28923
2009-07-02This time with the comment...Anders Broman1-2/+4
svn path=/trunk/; revision=28922
2009-07-02Don't resort the list for every row, the list will be in packet order any ↵Anders Broman1-1/+1
way. And "clicking" on the column titles will resort the list. svn path=/trunk/; revision=28921
2009-07-02Pull mkstemp() into tempfile.c. That's the only place we use it now, andGerald Combs10-149/+177
it's arguably the only place we _should_ use it. Add create_tempdir() to tempfile.c and use it to create a temp directory for IP maps. This should fix bug 3530. (This still doesn't work on IE 8 / Vista here. IE gives an access denied error in OpenLayers.js, but this is a separate issue). svn path=/trunk/; revision=28920
2009-07-02From Radek Vokál:Anders Broman2-9/+367
Support for new NFSv4 features. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3258 svn path=/trunk/; revision=28919
2009-07-02Move updating menus with new recent values to a point after we have createdStig Bjørlykke1-1/+3
the new packet list, because we relay on the columns for time values. This fixes bug 3640. svn path=/trunk/; revision=28918
2009-07-02From Albert Chin:Stig Bjørlykke2-2/+2
Small patch to make it compile on AIX. svn path=/trunk/; revision=28917
2009-07-02Fix the build.Gerald Combs1-1/+1
svn path=/trunk/; revision=28916
2009-07-01Updates to create_tempfile:Gerald Combs11-121/+94
- Use g_get_tmp_dir, just like get_tempfile_path. - Don't make the caller worry about the path buffer length. svn path=/trunk/; revision=28915
2009-07-01Fix a couple of labels.Gerald Combs1-4/+4
svn path=/trunk/; revision=28914
2009-07-01Added error value tables.Stig Bjørlykke1-6/+68
svn path=/trunk/; revision=28913
2009-07-01Add a couple of IPFIX labels where they differ from Netflow.Gerald Combs1-4/+18
svn path=/trunk/; revision=28912
2009-07-01Try to fix fuzzing errors in bug 3636. When dissecting an optionsGerald Combs1-16/+33
template, differentiate between Netflow v9 and IPFIX, which require different interpretations. Add other minor fixes and comments. svn path=/trunk/; revision=28911
2009-07-01Thou shalt not call assert() in dissectors.Guy Harris1-9/+9
svn path=/trunk/; revision=28910
2009-07-01Realy make the new packet list compile under Windows...Anders Broman4-5/+4
svn path=/trunk/; revision=28909
2009-07-01Fix a key entry bug in the decryption key dialog. Remove some unused /Gerald Combs4-147/+15
unnecessary functions. Clean up code in a couple of places. svn path=/trunk/; revision=28908
2009-07-01Make the new packet list compile on Windows.Anders Broman5-15/+14
svn path=/trunk/; revision=28907
2009-07-01Sligtly modify Stig's fix, I forgot the makefile change :-(Anders Broman1-1/+4
svn path=/trunk/; revision=28906
2009-07-01Try to fix HAVE_NEW_PACKET_LIST handling.Stig Bjørlykke2-0/+2
svn path=/trunk/; revision=28905
2009-07-01Added NEW_PACKET_LIST guard for new_packet_list.hStig Bjørlykke1-0/+2
svn path=/trunk/; revision=28904
2009-07-01Make it possible to configure use of NEW_PACKET_LIST and fixAnders Broman3-0/+8
one compile error. It still fails in file.c trying to include gtk/gtk.h in new_packet_list.h svn path=/trunk/; revision=28903
2009-07-01Added support for Simulcrypt EMMG <-> MUX,Stig Bjørlykke1-270/+550
and generic support for other interfaces. svn path=/trunk/; revision=28902
2009-07-01- Put ISMP.EDP into the protocol column to make it clearerJörg Mayer1-11/+20
that filtering on edp is not going to help - Make it possible to filter on ismp.edp - In case of edp fill info column svn path=/trunk/; revision=28901
2009-06-30Replace one assert() with DISSECTOR_ASSET(), so we don't crash, and getGuy Harris1-2/+2
rid of another, as the pointer in question is non-null in all calls (if somebody adds another call with a null pointer, it'll crash when dereferencing the pointer in any case). svn path=/trunk/; revision=28900
2009-06-30Don't crash if a null pointer is passed, just skip the appending of theGuy Harris1-3/+5
items. svn path=/trunk/; revision=28899
2009-06-30Get rid of assert() call; either the pointer will never be null, inGuy Harris1-1/+0
which case it won't crash, or it will be null, in which case that just trades one crash for another, and we should fix the crash. svn path=/trunk/; revision=28898
2009-06-30Add some length checks. Fixes bug 3567.Gerald Combs1-4/+22
svn path=/trunk/; revision=28897
2009-06-30Add assert and assert_perror to the 'abort' list.Gerald Combs1-0/+2
svn path=/trunk/; revision=28896
2009-06-30From: Benjamin Roch: Enhancements and small fixes for packet-tte.c dissector;Bill Meier1-35/+42
Also: a few minor mostly formatting changes by me. svn path=/trunk/; revision=28895
2009-06-30Fix typo.Guy Harris1-1/+1
svn path=/trunk/; revision=28894
2009-06-30Fix typo.Guy Harris1-1/+1
svn path=/trunk/; revision=28893
2009-06-30Introduce experimental new feature: GTK2 tree view based packet listStephen Fisher24-12/+1275
To use the GTK2 based packet list, define NEW_PACKET_LIST when compiling. To do this with gcc, set the environment variable CPPFLAGS to "-DNEW_PACKET_LIST" and re-run configure. Many features do not yet work. This work began with prototypes by Ulf quite a while back. I've put quite a bit of work into this so far and as discussed with a few of the core team members at Sharkfest09 and it was decided that it would be best to commit what I have so far to allow others to help work on this. svn path=/trunk/; revision=28892
2009-06-30packet-radius: Fix exception CLEANUP handling when malformed attribute ↵Bill Meier1-12/+15
list/pair seen; Fixes crash reported in Bug #3578. [https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3578] Essentially: CLEANUP_CALL_AND_POP wasn't being executed for certain error exits from dissect_attribute_pairs() thus leaving a CLEANUP entry on the exception stack. Also: vsa_buffer_table wasn't being destroyed if an exception occurred in dissect_attribute_pairs. svn path=/trunk/; revision=28891
2009-06-30Always register to tcp.port to be able to decode as.Stig Bjørlykke1-6/+2
svn path=/trunk/; revision=28890
2009-06-30Changed check for having multiple ldap PDU's in one frame.Stig Bjørlykke2-57/+53
The previous check is incorrect when the first ldap frame in the capture is selected and the filter is changed, or selecting "Follow TCP Stream". Also removed check_col(). svn path=/trunk/; revision=28889
2009-06-30Cleanup protocol name for ldap.Stig Bjørlykke2-2/+2
svn path=/trunk/; revision=28888
2009-06-30Put in missing newline at the end.Guy Harris1-1/+1
svn path=/trunk/; revision=28887
generated by cgit v1.2.1 (git 2.18.0) at 2024-07-01 19:13:18 +0000