summaryrefslogtreecommitdiff
path: root/asn1/h248/packet-h248-template.c
AgeCommit message (Collapse)AuthorFilesLines
2015-02-18H.248: fix dissection of ServiceChangeReason for version 1Pascal Quantin1-1/+1
My understanding of RFC 3015 is that the encoding of this field was not different in version 1 compared to newer releases Bug: 10879 Change-Id: Iaa81679388860c0df4adc673ca6e56aff6f4591c Reviewed-on: https://code.wireshark.org/review/7195 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-12-23asn1 generated dissectors: cleanup #include usageBill Meier1-2/+2
Change-Id: I36b2731d67f9345d2fd0c23800bba7d2be94c387 Reviewed-on: https://code.wireshark.org/review/6008 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-11-17H248: Fix Dereference of null pointer found by Clang analyzerAlexis La Goutte1-17/+19
Also fix some indent issue Change-Id: I262bdddd031fec6a0f91b7172bb2d67be3c33000 Reviewed-on: https://code.wireshark.org/review/5370 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-10-29Don't include ctype.h and replace isascii() with _ascii_isprint().AndersBroman1-1/+0
Remove deprecated APIs while at it. Change-Id: I002ed4a696782caaeeb70a3e4ced4ae81f3d5372 Reviewed-on: https://code.wireshark.org/review/4983 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-08-09Eliminate (almost all) proto_tree_add_text calls from ASN.1 dissectors.Michael Mann1-3/+8
This mostly involved adding expert info capabilities to many of the dissectors so that they could correctly flag error conditions. Only remaining proto_tree_add_text calls are in H248.cnf, which has a convoluted way of using hf_ data to make its tree. Change-Id: I6412150c2ec1977d7fa38f3f0ed416680bdfb141 Reviewed-on: https://code.wireshark.org/review/3500 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-20batch of tvb-length conversionsEvan Huus1-6/+6
Change-Id: I5e40df8af6841e3dad71c41d7e43c7971611b15f Reviewed-on: https://code.wireshark.org/review/2473 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-06-19Revert "Update ASN.1 source files with the API changes done in g021e7af"Pascal Quantin1-6/+6
This reverts commit e308e7c4de81c2ff7159e444b865ac59de4faa2b. Change-Id: I079616d63f643f79f1bc03ef5fdf724f36df4071 Reviewed-on: https://code.wireshark.org/review/2435 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-06-18Update ASN.1 source files with the API changes done in g021e7afPascal Quantin1-6/+6
Change-Id: I52ecfccbce423206242e3cf99401a8c9e1655d88 Reviewed-on: https://code.wireshark.org/review/2385 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-06-07tvb_new_subset -> tvb_new_subset_length when length parameters are equal.Michael Mann1-3/+3
tvb_new_subset -> tvb_new_subset_remaining it appears that's what the intention is. Change-Id: I2334bbf3f10475b3c22391392fc8b6864454de2d Reviewed-on: https://code.wireshark.org/review/1999 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-02-26Remove trailing whitespace from asn1 .cnf & template.[hc] files. Regenerate ↵Bill Meier1-4/+4
dissectors. Change-Id: I0e779b2ac2f608356649c5bbfca438141070dea4 Reviewed-on: https://code.wireshark.org/review/412 Reviewed-by: Bill Meier <wmeier@newsguy.com> Tested-by: Bill Meier <wmeier@newsguy.com>
2014-02-22Fix Called function pointer is null (null dereference) found by ClangAlexis La Goutte1-3/+2
../../asn1/h248/packet-h248-template.c:1222:31: warning: Value stored to 'prop' is never read if (!prop->dissector) prop = &no_param; Change-Id: I6d380fbb5fef9dc548385b0b470aea1cb3c34df1 Reviewed-on: https://code.wireshark.org/review/301 Reviewed-by: Evan Huus <eapache@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-02-18Remove $Id$ from the ASN.1 dissectors and regenerate them.Jeff Morriss1-2/+0
Change-Id: Ie476c6f82f318188b41ed922b92c6fec119ea954 Reviewed-on: https://code.wireshark.org/review/244 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com> Tested-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
2014-01-14Don't make claims of constness that can't be guaranteed in terms the CGuy Harris1-1/+1
compiler can verify. svn path=/trunk/; revision=54792
2013-12-17Make local functions static. Include *.h when needed.Anders Broman1-2/+4
svn path=/trunk/; revision=54201
2013-11-10Add missing includes in order to remove exceptions.h from proto.h (next commit).Jakub Zawadzki1-0/+1
svn path=/trunk/; revision=53230
2013-09-05Get rid of a duplicated filter name.Anders Broman1-6/+0
svn path=/trunk/; revision=51792
2013-09-01More dissectors to wmem. There are no more dissectors using se_tree now, just aEvan Huus1-8/+8
few other places. svn path=/trunk/; revision=51622
2013-08-04Convert proto_item_set_expert_flags into filterable items.Michael Mann1-5/+18
svn path=/trunk/; revision=51140
2013-07-06Use epan-scoped memory for h248 packages. Fixes another ~24KB of leaks.Evan Huus1-3/+3
svn path=/trunk/; revision=50414
2013-06-19Apparently one of our major global headers must include emem.h, because I justEvan Huus1-12/+12
found a bunch more asn1 dissectors using emem without ever directly including the header. Convert those to wmem as well, which involves add a number of #include directives since dissectors do *not* automatically pull in the wmem headers. svn path=/trunk/; revision=50066
2013-06-03Convert ASN.1 dissectors to use filterable expert info.Michael Mann1-1/+9
NOTE: Kerberos ASN.1 template was updated, but not generated to source. svn path=/trunk/; revision=49707
2013-03-29Rename value string (and similar) functions to use a consistent pattern. ThisEvan Huus1-8/+8
was done using textual search+replace, not anything syntax-aware, so presumably it got most comments as well (except where there were typos). Use a consistent coding style, and make proper use of the WS_DLL_* defines. Group the functions appropriately in the header. I ended up getting rid of most of the explanatory comments since many of them duplicated what was in the value_string.c file (and were out of sync with the recent updates I made to those in r48633). Presumably most of the comments should be in the .h file not the .c file, but there's enough churn ahead that it's not worth fixing yet. Part of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8467 svn path=/trunk/; revision=48634
2013-03-19From beroset:Anders Broman1-5/+4
remove C++ incompatibilities https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 svn path=/trunk/; revision=48429
2013-02-26its ==> it's & it's ==> its as needed.Bill Meier1-2/+2
svn path=/trunk/; revision=47892
2013-02-20Clean up white space - get rid of 4-space tabs.Guy Harris1-166/+176
Reformat the hf[] array to be consistent, and get rid of some bogus blurbs (probably copy-and-pasteos). svn path=/trunk/; revision=47759
2013-02-02Hack: disguise '/*' in text strings to prevent checkAPIs & etc seeing 'start ↵Bill Meier1-1/+1
of comment' within a text string. svn path=/trunk/; revision=47446
2013-01-19Use epan-scoped memory to clean up another 1Kb+ of valgrindEvan Huus1-3/+4
sorta-false-positive leaks. svn path=/trunk/; revision=47170
2012-12-13From John Batty via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8087 :Pascal Quantin1-1/+1
H.248 MEGACO PkgName property is poorly formatted svn path=/trunk/; revision=46526
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-3/+1
svn path=/trunk/; revision=45015
2012-07-11Revert part of revision 43107 which broke sub dissection ofAnders Broman1-32/+38
Signal and events as a new tvb wasn't created. |BASE_EXT_STRING also removed. svn path=/trunk/; revision=43661
2012-06-28Update Free Software Foundation address.Jakub Zawadzki1-1/+1
(COPYING will be updated in next commit) svn path=/trunk/; revision=43536
2012-06-05from Alex Lindberg:Anders Broman1-154/+208
Update to packet-h248.c and associated h248 dissecorts. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7332 svn path=/trunk/; revision=43107
2012-05-07Get rid of remaining Booleans-as-encoding-arguments inGuy Harris1-3/+13
proto_tree_add_item() calls. svn path=/trunk/; revision=42488
2012-03-13H.248 Annex E dissector does not properly dissect event parametersAnders Broman1-0/+28
(Update the h.248 dissector's package registration to support v1 packets.) Applying part of the patch from Alex Lindberg in bug https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6915 by hand. Fixes bug https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4842 svn path=/trunk/; revision=41526
2012-02-03Create a list of MTP Service Indicator macros and use them.Jeff Morriss1-4/+2
svn path=/trunk/; revision=40828
2011-11-14[-Wunused-but-set-variable]Anders Broman1-2/+2
svn path=/trunk/; revision=39829
2011-11-12fix [-Wunused-but-set-variable]Anders Broman1-14/+3
svn path=/trunk/; revision=39803
2011-10-21For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.Bill Meier1-1/+1
Also: remove trailing whitespace for a number of files. svn path=/trunk/; revision=39503
2010-12-20Rename the routines that handle dissector tables with unsigned integerGuy Harris1-5/+5
keys to have _uint in their names, to match the routines that handle dissector tables with string keys. (Using _port can confuse people into thinking they're intended solely for use with TCP/UDP/etc. ports when, in fact, they work better for things such as Ethernet types, where the binding of particular values to particular protocols are a lot stronger.) svn path=/trunk/; revision=35224
2010-11-15Use value_string_ext fcns to access certain value_string arrays;Bill Meier1-1088/+1101
Whitespace cleanup. svn path=/trunk/; revision=34882
2010-11-15Update package_name_vals[] value_string array:Bill Meier1-6/+24
- Add new entries based on: http://www.iana.org/assignments/megaco-h248 last updated 2010-10-01; - Fix a typo (incorrect value for an entry); - Switch values between two entries to match the IANA list; - Switch two entries so list is in ascending order by value. svn path=/trunk/; revision=34881
2010-01-21From Alex Lindberg:Anders Broman1-0/+2
resolves all h248V1 differences and provides dissection of V1 instances of Packets, Events, Signals, and Properties. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3999 svn path=/trunk/; revision=31597
2009-09-28Only include config.h in C files, to avoid multiple inclusion.Stig Bjørlykke1-0/+4
svn path=/trunk/; revision=30182
2009-09-10From Alex Lindberg:Anders Broman1-0/+16
Add H248V1 suport. (H248 dissector fails on poorly formed AuditReply packet from Media Gateway) https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3953 svn path=/trunk/; revision=29835
2009-08-21Sanitize epan includesKovarththanan Rajaratnam1-1/+1
svn path=/trunk/; revision=29500
2009-08-09Don't guard col_set_str (COL_PROTOCOL) with col_checkKovarththanan Rajaratnam1-2/+1
svn path=/trunk/; revision=29340
2009-06-27From yin sun:Anders Broman1-1/+1
h248 term wildcard enhancement svn path=/trunk/; revision=28861
2009-06-23From Kovarththanan Rajaratnam:Stig Bjørlykke1-16/+16
Clean up header field info in asn1/*-template.c files. From me: Fixed a few typos in the patch. svn path=/trunk/; revision=28817
2009-03-31Update value strings.Anders Broman1-1/+83
svn path=/trunk/; revision=27916
2008-12-17Fix some typos and spelling (mostly in text strings)Bill Meier1-1/+1
svn path=/trunk/; revision=27037
generated by cgit v1.2.1 (git 2.18.0) at 2024-07-02 11:30:01 +0000