summaryrefslogtreecommitdiff
path: root/asn1/ldap
AgeCommit message (Collapse)AuthorFilesLines
2013-05-07Some moreJörg Mayer1-0/+31
svn path=/trunk/; revision=49203
2013-05-05Just whitespace changesJörg Mayer1-2/+3
svn path=/trunk/; revision=49167
2013-04-23Stub cmake support for generating the asn1 dissectors.Jörg Mayer1-0/+23
It doesn't do anything yet, it is just to make svn status readable again. svn path=/trunk/; revision=49007
2013-03-21From beroset:Bill Meier1-1/+1
remove C++ incompatibilities https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 attachments #10423,#10424 svn path=/trunk/; revision=48450
2013-03-01Export libwireshark symbols using WS_DLL_PUBLIC defineBalint Reczey1-0/+2
Also remove old WS_VAR_IMPORT define and related Makefile magic everywhere in the project. svn path=/trunk/; revision=47992
2013-02-28The LDAP dissector uses register_frame_end_routine(), so it needs toGuy Harris1-0/+1
include packet-frame.h. svn path=/trunk/; revision=47928
2013-02-27Move show_exception() and show_reported_bounds_error() toGuy Harris1-1/+1
epan/show_exception.c, as it's used outside epan/dissectors/packet-frame.c. Update their callers to include <epan/show_exception.h> to get their declaration. Add a CATCH_NONFATAL_ERRORS macro that catches all exceptions that, if there's more stuff in the packet to dissect after the dissector call that threw the exception, doesn't mean you shouldn't go ahead and dissect that stuff. Use it in all those cases, including ones where BoundsError was inappropriately being caught (you want those passed up to the top level, so that the packet is reported as having been cut short in the capture process). Add a CATCH_BOUNDS_ERRORS macro that catches all exceptions that correspond to running past the end of the data for a tvbuff; use it rather than explicitly catching those exceptions individually, and rather than just catching all exceptions (the only place that DissectorError should be caught, for example, is at the top level, so dissector bugs show up in the protocol tree). Don't catch and then immediately rethrow exceptions without doing anything else; just let the exceptions go up to the final catcher. Use show_exception() to report non-fatal errors, rather than doing it yourself. If a dissector is called from Lua, catch all non-fatal errors and use show_exception() to report them rather than catching only ReportedBoundsError and adding a proto_malformed item. Don't catch exceptions when constructing a trailer tvbuff in packet-ieee8023.c - just construct it after the payload has been dissected, and let whatever exceptions that throws be handled at the top level. Avoid some TRY/CATCH/ENDTRY cases by using checks such as tvb_bytes_exist() before even looking in the tvbuff. svn path=/trunk/; revision=47924
2013-02-26Fix spelling/typos found using a list of commonly misspelled words.Bill Meier1-2/+2
The misspellings were mostly in comments but some were in text strings visible to the user. svn path=/trunk/; revision=47899
2013-02-26its ==> it's & it's ==> its as needed.Bill Meier1-1/+1
svn path=/trunk/; revision=47892
2013-02-19How can I get a new tvbuff that starts at an offset within a givenGuy Harris1-1/+1
tvbuff and runs to the end of the tvbuff? Let me count the ways.... Replace a bunch of different ways of doing that (some incorrect, in that they're not properly handling tvbuffs where the captured and reported lengths are different) with tvb_new_subset_remaining(). svn path=/trunk/; revision=47751
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-3/+1
svn path=/trunk/; revision=45015
2012-09-03MT: move global frame_end_routines to packet_info.Jakub Zawadzki1-1/+1
svn path=/trunk/; revision=44748
2012-07-08UATs could be put into "categories". The categories were defined onlyGuy Harris1-1/+3
implicitly by the #define name and string they were defined to; not all UATs neatly fit into any of the categories, so some of them were put into categories that weren't obviously correct for them, and one - the display filter macro UAT - wasn't put into any category at all (which caused crashes when editing them, as the GUI code that handled UAT changes from a dialog assumed the category field was non-null). The category was, in practice, used only to decide, in the aforementioned GUI code, whether the packet summary pane needed to be updated or not. It also offered no option of "don't update the packet summary pane *and* don't redissect anything", which is what would be appropriate for the display filter macro UAT. Replace the category with a set of fields indicating what the UAT affects; we currently offer "dissection", which applies to most UATs (any UAT in libwireshark presumably affects dissection at a minimum) and "the set of named fields that exist". Changing any UAT that affects dissection requires a redissection; changing any UAT that affects the set of named fields that exist requires a redissection *and* rebuilding the packet summary pane. Perhaps we also need "filtering", so that if you change a display filter macro, we re-filter, in case the display is currently filtered with a display filter that uses a macro that changed. svn path=/trunk/; revision=43603
2012-06-28Update Free Software Foundation address.Jakub Zawadzki5-5/+5
(COPYING will be updated in next commit) svn path=/trunk/; revision=43536
2012-06-04Get rid of a couple of warnings.Anders Broman1-5/+5
svn path=/trunk/; revision=43064
2012-06-04Get rid of a couple of warnings.Anders Broman2-263/+263
svn path=/trunk/; revision=43057
2012-05-28Sometimes you might have plaintext LDAP for a SASL LDAP connection if the ↵Ronnie Sahlberg1-0/+6
handshake never occured. Observed with exchange in some configurations. From Matthieu Patou <mat@matws.net> svn path=/trunk/; revision=42875
2012-05-08Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-3/+1
svn path=/trunk/; revision=42514
2012-05-08Get rid of remaining Booleans-as-encoding-arguments inGuy Harris2-3/+3
proto_tree_add_item() calls. Update the RFC number for LDAP. svn path=/trunk/; revision=42493
2012-05-03Fix Coverity CID 280809 (formerly CID 809): Uninitialized scalar variable.Chris Maynard1-0/+1
svn path=/trunk/; revision=42399
2012-04-10Fix #7056 + Remove mechanism global, unused variable.Jakub Zawadzki1-1/+22
svn path=/trunk/; revision=42008
2012-04-10Propagate ↵Anders Broman1-0/+1
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=42005 to template file. svn path=/trunk/; revision=42006
2012-03-30Adjusted UAT name.Stig Bjørlykke1-1/+1
svn path=/trunk/; revision=41844
2012-03-30Added support for configuring custom LDAP AttributeValue types.Stig Bjørlykke2-4/+169
svn path=/trunk/; revision=41841
2012-03-29Don't try to convert AttributeValue to string if having a ldap_name dissector.Stig Bjørlykke2-16/+12
Prefix the converted printable string correctly with 'AttributeValue: '. svn path=/trunk/; revision=41823
2012-03-02Remove now unused variables.Anders Broman1-2/+1
svn path=/trunk/; revision=41319
2012-03-02Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte2-4/+3
svn path=/trunk/; revision=41298
2011-11-20Get rid of Warnings.Anders Broman2-31/+31
svn path=/trunk/; revision=39954
2011-10-10Build the ASN.1 dissectors directly into epan/dissectors (rather than buildingJeff Morriss1-4/+0
them and then copying them over). The "all" target to builds these dissectors now (instead of "generate_files" and/or "copy_files"). asn2wrs's "-O" option now means "the dissector goes in this directory" (rather than "all output goes in this directory"); it also means that the "-s" (single output file) option is now required. Fix things up so that it's possible to build all of the ASN.1 dissectors in one shot. Fix building of conformance files when doing out-of-source-tree builds. Unfortunately "make all" in the asn1 directory always builds something--I think because of circular depedencies. svn path=/trunk/; revision=39333
2011-10-10Convert 'encoding' parameter of certain proto_tree_add_item() calls in asn1/*:Bill Meier1-2/+2
Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as the encoding parameter for proto_tree_add_item() calls which directly reference an item in hf[] which has a type of: FT_BOOLEAN FT_IPv4 FT_EUI64 FT_GUID FT_UINT_STRING Also: For type FT_IPv6 use ENC_NA. (This was missed in SVN #39260) svn path=/trunk/; revision=39332
2011-10-06Convert 'encoding' parameter of certain proto_tree_add_item() calls in asn1 ↵Bill Meier1-6/+6
dissectors: Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as the encoding parameter for proto_tree_add_item() calls which directly reference an item in hf[] which has a type of: FT_UINT8 FT_UINT16 FT_UINT24 FT_UINT32 FT_UINT64 FT_INT8 FT_INT16 FT_INT24 FT_INT32 FT_INT64 FT_FLOAT FT_DOUBLE svn path=/trunk/; revision=39294
2011-04-21From Stefan Metzmacher and Gregor Beck via ↵Jeff Morriss1-1/+30
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5850 : The smallest LDAP PDU is 7 bytes, not 4. svn path=/trunk/; revision=36777
2011-03-14Properly initialize our filter counters.Gerald Combs1-0/+4
svn path=/trunk/; revision=36190
2011-03-01If we encounter an excessively long filter string or one with too manyGerald Combs2-0/+17
elements, add an expert item and throw a ReportedBoundsError. We may want to handle this more cleanly in the future but this avoids allocating a huge amount of memory. svn path=/trunk/; revision=36101
2011-02-23Split get_dns_name() into get_dns_name() and expand_dns_name().Gerald Combs2-57/+13
In dissect_ms_compressed_string() dissect_mscldap_string() simply call expand_dns_name() instead of using duplicate (and insecure) code. This *might* break CLDAP and SMB dissection. If that's the case we should probably revert get_dns_name() and simplify expand_dns_name(). Fixes infinite recursion errors found by joernchen of Phenoelit. svn path=/trunk/; revision=36029
2011-02-10Declare ett's as gint, not guint.Chris Maynard1-1/+1
svn path=/trunk/; revision=35902
2011-01-11ldap.cnf:782: warning: ISO C90 forbids mixed declarations and codeAnders Broman1-1/+1
svn path=/trunk/; revision=35476
2011-01-11From Matthieu Patou <mat@samba.org>Ronnie Sahlberg2-5/+53
Dissect LDAP DirSyncFlags to show the bits of this bitmap. svn path=/trunk/; revision=35474
2011-01-06More misc. CLDAP improvements for Active Directory including updatingStephen Fisher1-32/+44
field names and adding descriptions, changing the Domain GUID in the "LDAP ping" response to a FT_GUID instead of FT_BYTES, etc. svn path=/trunk/; revision=35407
2011-01-06More minor cleanup/fixes for MS Active Directory's use of CLDAP.Stephen Fisher1-20/+13
svn path=/trunk/; revision=35404
2011-01-06Minor corrections to NtVer dissection for NETLOGON_NT_VERSION Options BitsStephen Fisher1-66/+69
in MSCLDAP packets per Microsoft's MS-ADTS specification, section 7.3.1.1, revision 26 (11/19/2010). Also re-format code a bit. svn path=/trunk/; revision=35403
2010-12-20Rename the routines that handle dissector tables with unsigned integerGuy Harris1-6/+6
keys to have _uint in their names, to match the routines that handle dissector tables with string keys. (Using _port can confuse people into thinking they're intended solely for use with TCP/UDP/etc. ports when, in fact, they work better for things such as Ethernet types, where the binding of particular values to particular protocols are a lot stronger.) svn path=/trunk/; revision=35224
2010-12-06Make some prefs callback functions static. (These modules don't use ↵Jeff Morriss1-2/+4
proto_reg_handoff_*() as their prefs callback.) svn path=/trunk/; revision=35138
2010-09-21The CLDAP attribute value on a CLDAP reply is no longer being decodedAnders Broman1-1/+1
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5239 It got broken in Revision 33390 I think, if attr_type is unset at this point it should be set in the calling function. http://anonsvn.wireshark.org/viewvc/trunk/asn1/ldap/ldap.cnf?r1=33388&r2=33390 svn path=/trunk/; revision=34176
2010-07-01Initialize more variables.Gerald Combs1-2/+2
svn path=/trunk/; revision=33392
2010-06-30Initialize a variable.Gerald Combs1-0/+2
svn path=/trunk/; revision=33390
2010-06-30Initialize a variable.Gerald Combs1-0/+1
svn path=/trunk/; revision=33388
2010-06-27Initialize attributedesc_string in a couple of places so that weGerald Combs2-9/+7
don't end up trying to use an invalid pointer. svn path=/trunk/; revision=33341
2010-05-13Use find_or_create_conversation() in some ASN.1 dissectorsJeff Morriss1-16/+4
svn path=/trunk/; revision=32791
2010-04-06#include <stdio.h> not needed.Bill Meier1-1/+0
svn path=/trunk/; revision=32405