summaryrefslogtreecommitdiff
path: root/asn1/snmp
AgeCommit message (Collapse)AuthorFilesLines
2012-10-09From Bill Parker:Anders Broman1-3/+3
Explicitly declare/cast 'unsigned <variable>' as 'unsigned int <variable>' https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7810 svn path=/trunk/; revision=45418
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-3/+1
svn path=/trunk/; revision=45015
2012-09-10Initial commit to support yet another method of passing data between dissectors.Jakub Zawadzki1-1/+1
Add new parameter 'data' to heur_dissector_t and new_dissector_t, for now it's always NULL svn path=/trunk/; revision=44860
2012-09-10Propage changes done in generated dissectors to asn1/Jakub Zawadzki1-8/+6
svn path=/trunk/; revision=44845
2012-08-01Fix Coverity CID 280019 (formerly 19): "Logically dead code" that abroman ↵Chris Maynard1-1/+1
previously commited a fix for in r17532, but forgot to also commit a change to asn1/snmp/packet-snmp-template.c as well, so the change was apparently inadvertently reverted the next time that packet-snmp.c was regenerated. svn path=/trunk/; revision=44179
2012-07-21Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7508 :Pascal Quantin1-0/+1
Display snmp.contextName as FT_STRING svn path=/trunk/; revision=43883
2012-07-13tvb_length_remaining() can return -1, so don't assign its return value to an ↵Chris Maynard1-2/+2
unsigned integer. Fixes Coverity CID's 280233 and 280234. svn path=/trunk/; revision=43697
2012-07-10Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7438 :Pascal Quantin1-2/+3
Do not call tvb_ensure_length_remaining on an empty tvb svn path=/trunk/; revision=43648
2012-07-08UATs could be put into "categories". The categories were defined onlyGuy Harris1-2/+2
implicitly by the #define name and string they were defined to; not all UATs neatly fit into any of the categories, so some of them were put into categories that weren't obviously correct for them, and one - the display filter macro UAT - wasn't put into any category at all (which caused crashes when editing them, as the GUI code that handled UAT changes from a dialog assumed the category field was non-null). The category was, in practice, used only to decide, in the aforementioned GUI code, whether the packet summary pane needed to be updated or not. It also offered no option of "don't update the packet summary pane *and* don't redissect anything", which is what would be appropriate for the display filter macro UAT. Replace the category with a set of fields indicating what the UAT affects; we currently offer "dissection", which applies to most UATs (any UAT in libwireshark presumably affects dissection at a minimum) and "the set of named fields that exist". Changing any UAT that affects dissection requires a redissection; changing any UAT that affects the set of named fields that exist requires a redissection *and* rebuilding the packet summary pane. Perhaps we also need "filtering", so that if you change a display filter macro, we re-filter, in case the display is currently filtered with a display filter that uses a macro that changed. svn path=/trunk/; revision=43603
2012-06-28Update Free Software Foundation address.Jakub Zawadzki5-5/+5
(COPYING will be updated in next commit) svn path=/trunk/; revision=43536
2012-06-09Do not use BASE_NONE for FT_*INT* types.Chris Maynard1-1/+1
svn path=/trunk/; revision=43179
2012-06-04Get rid of a couple of warnings.Anders Broman1-34/+34
svn path=/trunk/; revision=43065
2012-05-24tvb_length_remaining() can return a negative number, so be sure to handle ↵Chris Maynard1-1/+13
it. Fixes Coverity CID's 280233-280235. svn path=/trunk/; revision=42839
2012-05-24Fix bug #7283Jakub Zawadzki1-1/+2
When Engine ID is 128 we should only break when we know the enterprise id. svn path=/trunk/; revision=42825
2012-05-11Get rid of remaining Booleans-as-encoding-arguments inGuy Harris1-4/+4
proto_tree_add_item() calls. svn path=/trunk/; revision=42556
2012-04-25From Evan Huus:pascal1-2/+3
Fix Integer32 length field detection https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7192 svn path=/trunk/; revision=42241
2012-01-18#include <epan/crypt/crypt-*.h> => #include <epan/crypt/*.h>Chris Maynard1-2/+2
svn path=/trunk/; revision=40570
2011-11-20Get rid of Warnings.Anders Broman1-16/+16
svn path=/trunk/; revision=39954
2011-11-14Do some more length checking to avoid a dissector bug error. Should fixGuy Harris1-2/+36
bug 6564. svn path=/trunk/; revision=39831
2011-10-29Added support for big integer64 values.Stig Bjørlykke1-1/+9
This fixes bug 6295. svn path=/trunk/; revision=39666
2011-10-21For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.Bill Meier1-1/+1
Also: remove trailing whitespace for a number of files. svn path=/trunk/; revision=39503
2011-10-20Use ENC_NA as proto_tree_add_item() encoding arg for FT_ETHER hf[] field type.Bill Meier1-1/+1
svn path=/trunk/; revision=39491
2011-10-15Convert asn1 template files proto_tree_add_item() 'encoding' arg for field ↵Bill Meier1-1/+1
types FT_STRING as follows: 1. If there's no character encoding (ENC_ASCII, ...) specified then use ENC_ASCII. 2. Always use ENC_NA (replacing any existing True/1/FALSE/0 /ENC_BIG_ENDIAN/ENC_LITTLE_ENDIAN). svn path=/trunk/; revision=39428
2011-10-10Build the ASN.1 dissectors directly into epan/dissectors (rather than buildingJeff Morriss1-4/+0
them and then copying them over). The "all" target to builds these dissectors now (instead of "generate_files" and/or "copy_files"). asn2wrs's "-O" option now means "the dissector goes in this directory" (rather than "all output goes in this directory"); it also means that the "-s" (single output file) option is now required. Fix things up so that it's possible to build all of the ASN.1 dissectors in one shot. Fix building of conformance files when doing out-of-source-tree builds. Unfortunately "make all" in the asn1 directory always builds something--I think because of circular depedencies. svn path=/trunk/; revision=39333
2011-10-10Convert 'encoding' parameter of certain proto_tree_add_item() calls in asn1/*:Bill Meier1-1/+1
Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as the encoding parameter for proto_tree_add_item() calls which directly reference an item in hf[] which has a type of: FT_BOOLEAN FT_IPv4 FT_EUI64 FT_GUID FT_UINT_STRING Also: For type FT_IPv6 use ENC_NA. (This was missed in SVN #39260) svn path=/trunk/; revision=39332
2011-10-05Use ENC_NA as encoding for proto_tree_add_item() calls which directly ↵Bill Meier1-6/+6
reference an hf item (in hf[] with types: FT_NONE FT_BYTES FT_IPV6 FT_IPXNET FT_OID Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|1|0|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN svn path=/trunk/; revision=39263
2011-09-23Change the case of "sNMPv2-Trap" to match RFC 3416. Reported by Qiyao.Gerald Combs1-1/+1
svn path=/trunk/; revision=39114
2011-08-02From Paul Stath via bug 5731: The check for engineID length should only ↵Chris Maynard1-1/+1
occur if the engineID has a non-zero length. Reference: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5731 svn path=/trunk/; revision=38303
2011-07-19Use correct encoding for proto_tree_add_item().Stig Bjørlykke1-17/+17
svn path=/trunk/; revision=38107
2011-06-05From Sean Van Gorder:Anders Broman1-1/+1
When Wireshark attempts to read an SNMP packet with a variable-bindings item with an OID containing an index string which includes an entry of type "Unsigned32", Wireshark will stop dissecting the packet at this index entry and end with the error: [Dissector bug, protocol SNMP: proto.c:2761: failed assertion "DISSECTOR_ASSERT_NOT_REACHED"] https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5883 svn path=/trunk/; revision=37558
2011-04-21Fix Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-1/+1
svn path=/trunk/; revision=36771
2011-04-21Fix Dead Store (Dead nested assignment) Warning found by Clang Alexis La Goutte1-1/+1
svn path=/trunk/; revision=36760
2011-04-13Rollback r36614 and change dissect_SMUX_PDUs_PDU() to use previouslyStephen Fisher1-2/+3
unused smux_tree instead of tree. Per suggestion from Stig on -dev. svn path=/trunk/; revision=36624
2011-04-12Fix Coverity 524: NEGATIVE_RETURNSStephen Fisher1-2/+2
Coverity sees that two calls to tvb_length_remaining() with an offset of 0 may return -1 (for an "out of bounds" condition), which would lead to an assignment of -1 to an unsigned variable and then passing it to functions further down that cannot accept negative values. Use tvb_ensure_length_remaining() to throw an exception in a case of out of bounds access (though unlikely with an offset of 0) instead of tvb_length_remaining(), which would return -1. svn path=/trunk/; revision=36615
2011-04-12Fix Coverity 1047: UNUSED_VALUE in dissect_smuxStephen Fisher1-2/+1
svn path=/trunk/; revision=36614
2011-04-12Corrected switch-case flow.Stig Bjørlykke1-1/+1
Coverity 1184. svn path=/trunk/; revision=36579
2011-04-07Use a unique variable name. Fixes Coverity CID 593.Gerald Combs1-4/+4
svn path=/trunk/; revision=36512
2011-03-25From Didier via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3055 :Jeff Morriss1-1/+9
Apply rev 25869 to most of the rest of the TCP-desegmenting dissectors. (The SSL dissector was already updated in one of two spots with bug 4535/rev 32456.) A couple of the patches had to be manually applied. From me: Fix the comments to match the change (including in the TCP and SSL dissectors.) svn path=/trunk/; revision=36332
2011-01-20Allow for expert items to be actually attached somewhere.Jaap Keuter1-9/+12
svn path=/trunk/; revision=35594
2010-12-30Only chop the last character (new line) from the error message.Stig Bjørlykke1-1/+1
svn path=/trunk/; revision=35310
2010-12-29Fix a buffer overflow in the engineId preferences. Fixes bug 5530.Gerald Combs1-11/+15
svn path=/trunk/; revision=35298
2010-12-20Rename the routines that handle dissector tables with unsigned integerGuy Harris1-10/+10
keys to have _uint in their names, to match the routines that handle dissector tables with string keys. (Using _port can confuse people into thinking they're intended solely for use with TCP/UDP/etc. ports when, in fact, they work better for things such as Ethernet types, where the binding of particular values to particular protocols are a lot stronger.) svn path=/trunk/; revision=35224
2010-12-06Fix various typos and spelling errors.Bill Meier1-1/+1
svn path=/trunk/; revision=35126
2010-10-29One more:Stig Bjørlykke1-1/+1
Make the third argument to a UAT copy callback a size_t. svn path=/trunk/; revision=34696
2010-10-29Make the third argument to a UAT copy callback a size_t.Stig Bjørlykke1-1/+1
svn path=/trunk/; revision=34695
2010-10-14From Fulko Hew via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4615 :Jeff Morriss1-134/+194
The attached patch adds the missing decoded fields by moving the proto_tree_add_item() call so that it is no longer within an error handler and will be called under normal circumstances (as well as error conditions. From me: Apply the change to the ASN.1 source. Also some white space indentation cleanup. svn path=/trunk/; revision=34505
2010-09-17Copy the rev 34143 changes to packet-snmp.c over to the asn1 source.Jeff Morriss1-13/+13
hf_snmp_engineid_enterprise is now a BASE_EXT_STRING, not BASE_RANGE_STRING. This fixes the fuzz failure in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5233 svn path=/trunk/; revision=34151
2010-08-02Mark encryptedData as unused, to avoid warnings when not HAVE_LIBGCRYPT.Stig Bjørlykke1-2/+2
svn path=/trunk/; revision=33691
2010-08-02Added missing include <string.h>.Stig Bjørlykke1-0/+1
svn path=/trunk/; revision=33690
2010-07-02oid_encoded2string() returns a const char *; don't assign it to a charGuy Harris1-2/+4
*. Don't declare variables in the middle of a block; not all the compilers we use support that. svn path=/trunk/; revision=33409
generated by cgit v1.2.1 (git 2.18.0) at 2024-07-05 15:50:02 +0000