summaryrefslogtreecommitdiff
path: root/asn1
AgeCommit message (Collapse)AuthorFilesLines
2016-02-07SNMP: Fix warning [-Wunused-function]João Valverde1-1/+1
Add SNMP to clean dissectors also. Change-Id: Ifc4d5a03c13f864bd9219294028323761cd19368 Reviewed-on: https://code.wireshark.org/review/13786 Petri-Dish: João Valverde <j@v6e.pt> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2016-02-07Add free_address_wmem() and other extensions to address APIJoão Valverde4-16/+16
Try to improve 'address' API (to be easier/safer) and also avoid some constness warnings by not overloading the 'data' pointer to store malloc'ed buffers (use private pointer for that instead). Change-Id: I7456516b12c67620ceadac447907c12f5905bd49 Reviewed-on: https://code.wireshark.org/review/13463 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2016-02-06TCAP: fix indent and add modelines (use 2 spaces)Alexis La Goutte2-124/+150
Change-Id: I3ac35f3dd6514469bdcabd0acd67970077d5c364 Reviewed-on: https://code.wireshark.org/review/13793 Reviewed-by: João Valverde <j@v6e.pt>
2016-02-06asn1: Cleanup space usageStig Bjørlykke6-52/+46
Fix space issues in some ASN.1 dissectors. Change-Id: I4ceccfbe9a13c93fc91821d1bfe4b7d6bb39c435 Reviewed-on: https://code.wireshark.org/review/13791 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-02-06TCAP: Fix dissect_tcap_ERROR() unused warning [-Wunused-function]João Valverde1-1/+1
Change-Id: I0d9511ed9cb93446766d510b97fdefe56a86a826 Reviewed-on: https://code.wireshark.org/review/13787 Petri-Dish: João Valverde <j@v6e.pt> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-02-06Remove unbalanced comment markerJoão Valverde1-1/+1
Change-Id: I21faa3f454974ee4a167ff8709a8f7ecead8a7cd Reviewed-on: https://code.wireshark.org/review/13785 Reviewed-by: João Valverde <j@v6e.pt>
2016-02-05RTSE and PRES relies on the TCP conversation to do reassembly, switch toAndersBroman2-5/+18
the new interface. Change-Id: I4f818d55416d3b1d09b46015d83f3acc5a9e71cc Reviewed-on: https://code.wireshark.org/review/13744 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-02-04Fix asn2wrs warnings [-Wredundant-decls]João Valverde1-1/+0
Change-Id: Iced801f17c56618eaaf1bb7c85d68ecdebd633a1 Reviewed-on: https://code.wireshark.org/review/13705 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-02-04ASN1: fix misspelling (found by Lintian)Alexis La Goutte9-11/+19
Extention -> Extension Change-Id: I10278ce21da805b2b86cac6e2b14e921acf15544 Reviewed-on: https://code.wireshark.org/review/13052 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-02-03Sync ASN.1 templates and generated code (spelling fixes)João Valverde4-6/+6
Change-Id: Ib6ed980ecf5d5418349946c8da26f81fe1c02dd1 Reviewed-on: https://code.wireshark.org/review/13701 Reviewed-by: João Valverde <j@v6e.pt>
2016-02-03LCSAP: Sync ASN.1 template and add missing bracesJoão Valverde1-10/+9
Change-Id: Iaddfa41e71ea28dd935bf777214764381928baa5 Reviewed-on: https://code.wireshark.org/review/13700 Reviewed-by: João Valverde <j@v6e.pt>
2016-02-03M3AP: fix dissection of IPAddress fieldPascal Quantin2-4/+30
Bug: 12070 Change-Id: Ib516cc3ea7e00a6c4fe1661b9c78b0f6c6a25da6 Reviewed-on: https://code.wireshark.org/review/13689 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-02-02[GSM MAP] Update to V13.2.0 (2015-12)AndersBroman24-391/+485
Change-Id: I2cc8b1c4094f2781c7674a22836ec8de4e24ca0d Reviewed-on: https://code.wireshark.org/review/13665 Petri-Dish: Anders Broman <a.broman58@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-02-01LTE RRC: add system info modification for eDRX UEs in info columnPascal Quantin2-0/+7
Change-Id: I8041bf74c37665f1fd70f0d8c39157e09f79d96c Reviewed-on: https://code.wireshark.org/review/13638 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-01-31RLC LTE: upgrade dissector to v13.0.0Pascal Quantin1-0/+16
Change-Id: Ibe4586925ffe49f5aaab72956c40e123855a1a1e Reviewed-on: https://code.wireshark.org/review/13620 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-01-31LCSAP: fix indent (use 2 spaces and add modelines)Alexis La Goutte2-132/+138
Change-Id: I2aa1a2d0e20cca6c979d51135e7fe9ea7a084847 Reviewed-on: https://code.wireshark.org/review/13609 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-01-29gsm_map: decode SRISM v1 and v2 resultLuke Mewburn2-1/+26
Fix decoding of sendRoutingInfoForSM (SRISM) application contexts version 1 and version 2. Use a (slightly modified) version of the ASN.1 from ETS 300 599: December 2000 (GSM 09.02 version 4.19.1), clause 14.7.6 which has LocationInfoWithLMSI that is incompatible with application context version 3 in 3GPP TS 29.002 version 3.20.0 Release 1999, clause 17.7.6. Bug: 9622 Ping-Bug: 9704 Change-Id: Icc9a0a1743a6eb4c907f4cab3fb2137db139ad74 Reviewed-on: https://code.wireshark.org/review/13572 Petri-Dish: Anders Broman <a.broman58@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-01-28LCSAP: improve dissectionPascal Quantin2-6/+36
- add PLMN info in a subtree - dissect Horizontal Accuracy - dissect Vertical Accuracy - dissect IMSI Bug: 12054 Change-Id: Ic069d78f23fcf956e4aa5eb19f4d39af0f529757 Reviewed-on: https://code.wireshark.org/review/13585 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-01-28correctly decode GSM_MAP invoke SRISMv1Luke Mewburn2-3/+3
The decoding of application context version 1 SendRoutingInfoForSM (SRISM) invokes (added in bug 9704) had issues: - The ASN.1 for RoutingInfoForSM-ArgV1 in GSMMAP.asn lacked teleserviceCode and the extension marker. ETSI ETS 300 599 (GSM 09.02 version 4.19.1) clause 14.7.6 has teleserviceCode and the extension marker, but not cug-Interlock. Clause C.6.4 mentions that cug-Interlock has been deleted, but it's retained here for decoding backwards compat. - The test for which application_context_version to decode as didn't work when that value was 0 (i.e. missing). Ping-Bug: 9704 Change-Id: I8a8170d959347a47413cfd9876022e9182256452 Reviewed-on: https://code.wireshark.org/review/13571 Petri-Dish: Anders Broman <a.broman58@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-01-26PDCP LTE: upgrade dissector to v13.0.0Pascal Quantin1-0/+8
Change-Id: Iae4a38ac7b80978d1ad02168e79c0fe0bffd8d2e Reviewed-on: https://code.wireshark.org/review/13549 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-01-25Move the proto data stuff out of frame_data.[ch].Guy Harris6-0/+6
It's not tied to the frame_data structure any more, so it belongs by itself. Clean up some #includes while we're at it; in particular, frame_data.h doesn't use anything related to tvbuffs, so don't have it gratuitiously include tvbuff.h. Change-Id: Ic32922d4a3840bac47007c5d4c546b8842245e0c Reviewed-on: https://code.wireshark.org/review/13518 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-01-24Add the packet number to the packet_info structure, and use it.Guy Harris22-165/+165
That removes most of the uses of the frame number field in the frame_data structure. Change-Id: Ie22e4533e87f8360d7c0a61ca6ffb796cc233f22 Reviewed-on: https://code.wireshark.org/review/13509 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-01-23Fix template files to refer directly to pinfo->abs_ts.Guy Harris5-23/+23
Change-Id: I10ac1ee42ba17d3faf3d76f9d4d7fe8cba8043bc Reviewed-on: https://code.wireshark.org/review/13500 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-01-20X509AF: reset algorithm_id global variable when closing a filePascal Quantin1-0/+7
Change-Id: I59a6e5e482f4f11ab446e9839cc7a0c67742dab3 Reviewed-on: https://code.wireshark.org/review/13424 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-01-19X509AF: make a local copy of algorithm_id in file scope for later usePascal Quantin2-2/+8
Bug: 12002 Change-Id: Iff48863c1954f76d6fc34150d315d15295dc1f5c Reviewed-on: https://code.wireshark.org/review/13406 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-01-15LTE RRC: upgrade dissector to v13.0.0Pascal Quantin7-50/+1662
Change-Id: Ie41471f79191097c491d58949c4e90b314cade04 Reviewed-on: https://code.wireshark.org/review/13300 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-01-14ranap: Sync with asn1 sourceStig Bjørlykke1-1/+1
Change-Id: I3b16427f43603bc665385b5c59d6e278797a2b96 Reviewed-on: https://code.wireshark.org/review/13285 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2016-01-14Rename new_dissector_t to dissector_t.Guy Harris12-33/+33
There are no longer any "old" dissectors, so "new_" is redundant. Change-Id: I5fee51228c2a8562166f5991e1f30c2c697e45c8 Reviewed-on: https://code.wireshark.org/review/13273 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-01-13RRC: follow-up of g588955dPascal Quantin7-621/+622
Change-Id: I46d23e57441f5776a63776adc8cbf7fedffad49c Reviewed-on: https://code.wireshark.org/review/13264 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-01-13[RRC] Update to V13.1.0 (2015-12)AndersBroman6-629/+2017
Change-Id: Ic9c19bf7f8ee4233ac1150bc372b3693502d986d Reviewed-on: https://code.wireshark.org/review/13261 Petri-Dish: Anders Broman <a.broman58@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-01-10LPP: upgrade dissector to v13.0.0Pascal Quantin4-22/+510
Change-Id: I0b01e48eae8be010175fb7f3aa1208957b871f06 Reviewed-on: https://code.wireshark.org/review/13174 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-01-08Fix a lot of typos and misspellingsmoshekaplan9-14/+14
Change-Id: I8512cfa1d424f82a873a0e0e1d22c7b075fdd7f3 Reviewed-on: https://code.wireshark.org/review/13069 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-01-06[S1AP] Update to version V13.1.0 (2015-12)AndersBroman8-107/+807
Change-Id: I48080dd6839d3cb02b6ea3717d69b56dbf3e59d8 Reviewed-on: https://code.wireshark.org/review/13077 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-01-05INAP: fix indent (use 2spaces and modelines)Alexis La Goutte1-59/+69
Change-Id: I4d54b851e3bd316e10edea29d1d7e311be338c71 Reviewed-on: https://code.wireshark.org/review/13054 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-01-04C12.22: fix compilation without LibgcryptPascal Quantin1-1/+3
Change-Id: I9ef842b4ed543cfbd199e49496bc01a09f71404b Reviewed-on: https://code.wireshark.org/review/13039 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-01-02Get rid of an unnecessary level of indirection.Guy Harris1-27/+25
Instead of an array of pointers to preference values, have an array of preference values. Clean up some white space while we're at it. Change-Id: Iaa2cf6bcc2a271a5c2645ddbb2dbddba311b413d Reviewed-on: https://code.wireshark.org/review/13002 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-01-02Use #defines for the values for the facility_encoding preference.Guy Harris1-4/+6
Change-Id: I496782308e2f2e9605f2256d7a482d50b086e49c Reviewed-on: https://code.wireshark.org/review/13001 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-01-01ifdef out the decryption code and preferences if LIBGCRYPT isn't defined.Guy Harris1-22/+22
Change-Id: Idf4f1e461d3bc6e85f2760488ad566a4cd70c5ea Reviewed-on: https://code.wireshark.org/review/12999 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-01-01Clean up response matching type preference.Guy Harris1-9/+14
Add #defines for all the value types and use them. Make the preference static, as it's not used outside this module. Change-Id: I3ed715701f77d5ea6cc45c8f978d6e2da7b38671 Reviewed-on: https://code.wireshark.org/review/12988 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-01-01Clean up response matching type preference.Guy Harris1-9/+12
Add #defines for all the value types and use them. Make the preference static, as it's not used outside this module. Change-Id: Ibd04274b4160d18a55b10f47ce866ac97a76309e Reviewed-on: https://code.wireshark.org/review/12987 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-12-29Rename new_stat_tap_ui to stat_tap_table_ui.Guy Harris4-12/+12
A "new" statistics tap UI is a statistics tap UI where the statistics are maintained as tables and common code handles the tables; what matters is the tables, not that it's "new". Change-Id: I7a0e63cfac98c24cd5e7dce973b9a0cc5b6a03ba Reviewed-on: https://code.wireshark.org/review/12897 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-12-29There's no "old" stat_tap_table, so remove "new_" from the name.Guy Harris4-17/+17
Change-Id: I1a0349d5d9d47210a97ff7a99fb358e59fd70e72 Reviewed-on: https://code.wireshark.org/review/12896 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-12-28Don't cast away constness for the key in g_hash_table_lookup().Guy Harris1-1/+1
Change-Id: Ibd5cf8947028d90a734de629e3c4202af9d0514b Reviewed-on: https://code.wireshark.org/review/12887 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-12-16ldap: Add inetOrgPerson from RFC2798.Stig Bjørlykke1-0/+3
Change-Id: I3e2e3143f66db62c416fd7031d290e2a5b21fa93 Reviewed-on: https://code.wireshark.org/review/12677 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-15T.38: don't register for TCP and UDP ports 6004.Jeff Morriss1-44/+22
T.38 normally picks up its port number dynamically from signalling, port 6004 isn't registered to T.38, and anyway port 6004 is now (correctly) registered to X11. (For the cases where the signaling is missing there's still Decode-As.) Change-Id: I53d8aa27ed1b042dd60bbdb0df2bd89254f1f001 Reviewed-on: https://code.wireshark.org/review/12640 Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-12-13ULP: prettify dissectionPascal Quantin2-4/+951
Bug: 11039 Change-Id: I1d39367818a0039bc3100cd464baa6268c8863dd Reviewed-on: https://code.wireshark.org/review/12603 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-12-13NBAP : Verify conversation proto data exists before trying to access itAnish Bhatt1-3/+6
Bug 11841 Change-Id: Ic0dea6491a68a042ddc0f2dbee19739e4568b18c Reviewed-on: https://code.wireshark.org/review/12576 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-11ULP: register dissector for application/vnd.omaloc-supl-init mediaPascal Quantin1-0/+1
Bug: 11875 Change-Id: Ifb6cdd424ef0062bebb4c4e67ad603461042f111 Reviewed-on: https://code.wireshark.org/review/12538 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-12-10Convert ASN.1 dissectors to remove "new" from "new-style" dissector function ↵Michael Mann107-220/+220
names that were generated from asn2wrs.py This includes: 1. new_create_dissector_handle -> create_dissector_handle 2. new_register_dissector -> register_dissector 3. new_register_ber_oid_dissector -> register_ber_oid_dissector 4. new_register_ber_syntax_dissector -> register_ber_syntax_dissector Also remove PDU_NEW, SYNTAX_NEW and REGISTER_NEW as there is no need for the distinction anymore. Change-Id: I82c7de7c8ffeeab3259d1b55bb4afc5f6a1e0329 Reviewed-on: https://code.wireshark.org/review/12491 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-09"new" dissector API -> dissector API for ASN.1 dissectors.Michael Mann80-155/+155
Change-Id: I7b794cba2feda2cae40411e2b1cb9fb091d08220 Reviewed-on: https://code.wireshark.org/review/12480 Reviewed-by: Michael Mann <mmann78@netscape.net>