summaryrefslogtreecommitdiff
path: root/epan/dissectors/packet-bacapp.c
AgeCommit message (Collapse)AuthorFilesLines
2013-11-09Include <epan/to_str.h> only when needed.Jakub Zawadzki1-0/+1
svn path=/trunk/; revision=53189
2013-10-23#if 0 numerous "unused const variables" (mostly value-string-arrays);Bill Meier1-2/+6
Also; fix a few "set but not used" warnings. svn path=/trunk/; revision=52780
2013-10-22Remove instances of unused 'data_handle' (and of one other handle).Bill Meier1-7/+0
svn path=/trunk/; revision=52767
2013-10-13Minor whitespace changesBill Meier1-907/+907
svn path=/trunk/; revision=52590
2013-09-22emem -> wmem conversion:Pascal Quantin1-1/+1
- ep_tvb_get_bits() -> wmem_packet_tvb_get_bits() - tvb_g_memdup()/ep_tvb_memdup() -> tvb_memdup() - tvb_fake_unicode()/tvb_get_ephemeral_faked_unicode() -> tvb_get_faked_unicode() - tvb_get_g_string()/tvb_get_ephemeral_string()/tvb_get_seasonal_string() -> tvb_get_string() - tvb_get_g_unicode_string()/tvb_get_ephemeral_unicode_string() -> tvb_get_unicode_string() - tvb_get_ephemeral_string_enc() -> tvb_get_string_enc() - update docs accordingly svn path=/trunk/; revision=52172
2013-09-17Reference 'BACnetVendorIdentifiers' value_string usingBill Meier1-2/+3
an extended value string. svn path=/trunk/; revision=52124
2013-09-17Update 'BACnetVendorIdentifiers' value strings fromBill Meier1-209/+370
BACnet vendor ID list dated September 16, 2013. http://www.bacnet.org/VendorID/BACnet%20Vendor%20IDs.htm svn path=/trunk/; revision=52119
2013-09-13Add comment where the vendor ids come fromJörg Mayer1-0/+4
svn path=/trunk/; revision=52014
2013-09-12Convert a few more dissectors to wmemPascal Quantin1-52/+63
svn path=/trunk/; revision=51991
2013-09-09expert_add_info_format_text -> expert_add_info_formatMichael Mann1-2/+2
svn path=/trunk/; revision=51852
2013-08-10Fix (-W)documentation error found by ClangAlexis La Goutte1-512/+509
packet-bacapp.c:78:13: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation] * @param tvb ~~~~~~~~~^ packet-bacapp.c:79:15: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation] * @param pinfo ~~~~~~~~~~~^ packet-bacapp.c:80:14: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation] * @param tree ~~~~~~~~~~^ packet-bacapp.c:100:13: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation] * @param tvb ~~~~~~~~~^ packet-bacapp.c:101:15: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation] * @param pinfo ~~~~~~~~~~~^ packet-bacapp.c:102:14: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation] * @param tree ~~~~~~~~~~^ packet-bacapp.c:103:16: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation] * @param offset ~~~~~~~~~~~~^ packet-bacapp.c:110:13: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation] * @param tvb ~~~~~~~~~^ packet-bacapp.c:111:15: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation] * @param pinfo ~~~~~~~~~~~^ packet-bacapp.c:112:14: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation] * @param tree ~~~~~~~~~~^ packet-bacapp.c:113:16: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation] * @param offset ~~~~~~~~~~~~^ packet-bacapp.c:130:13: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation] * @param tvb ~~~~~~~~~^ packet-bacapp.c:131:15: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation] * @param pinfo ~~~~~~~~~~~^ packet-bacapp.c:132:14: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation] * @param tree ~~~~~~~~~~^ packet-bacapp.c:133:16: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation] * @param offset ~~~~~~~~~~~~^ packet-bacapp.c:146:13: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation] * @param tvb ~~~~~~~~~^ packet-bacapp.c:147:15: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation] * @param pinfo ~~~~~~~~~~~^ packet-bacapp.c:148:14: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation] * @param tree ~~~~~~~~~~^ packet-bacapp.c:149:16: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation] * @param offset ~~~~~~~~~~~~^ packet-bacapp.c:251:15: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation] * @param label ~~~~~~~~~~~^ packet-bacapp.c:263:15: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation] * @param label ~~~~~~~~~~~^ packet-bacapp.c:275:15: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation] * @param label ~~~~~~~~~~~^ packet-bacapp.c:288:15: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation] * @param label ~~~~~~~~~~~^ packet-bacapp.c:300:15: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation] * @param label ~~~~~~~~~~~^ packet-bacapp.c:325:24: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation] * @param service_choice ~~~~~~~~~~~~~~~~~~~~^ packet-bacapp.c:338:24: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation] * @param service_choice ~~~~~~~~~~~~~~~~~~~~^ packet-bacapp.c:521:15: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation] * @param label ~~~~~~~~~~~^ packet-bacapp.c:522:13: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation] * @param src ~~~~~~~~~^ packet-bacapp.c:521:11: error: parameter 'label' not found in the function declaration [-Werror,-Wdocumentation] * @param label ^~~~~ packet-bacapp.c:522:11: error: parameter 'src' not found in the function declaration [-Werror,-Wdocumentation] * @param src ^~~ packet-bacapp.c:654:11: error: parameter 'tree' not found in the function declaration [-Werror,-Wdocumentation] * @param tree the tree to append this item to ^~~~ packet-bacapp.c:654:11: note: did you mean 'subtree'? * @param tree the tree to append this item to ^~~~ subtree packet-bacapp.c:723:11: error: parameter 'tree' not found in the function declaration [-Werror,-Wdocumentation] * @param tree the tree to append this item to ^~~~ packet-bacapp.c:723:11: note: did you mean 'subtree'? * @param tree the tree to append this item to ^~~~ subtree packet-bacapp.c:749:11: error: parameter 'tree' not found in the function declaration [-Werror,-Wdocumentation] * @param tree the tree to append this item to ^~~~ packet-bacapp.c:749:11: note: did you mean 'subtree'? * @param tree the tree to append this item to ^~~~ subtree packet-bacapp.c:1076:24: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation] * @param service_choice ~~~~~~~~~~~~~~~~~~~~^ packet-bacapp.c:1266:17: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation] * @param service ~~~~~~~~~~~~~^ packet-bacapp.c:1337:4: error: unknown command tag name 'pram'; did you mean 'param'? [-Werror,-Wdocumentation] * @pram pinfo ^~~~~ param packet-bacapp.c:1337:14: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation] * @pram pinfo ~~~~^ packet-bacapp.c:1366:15: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation] * @param label ~~~~~~~~~~~^ svn path=/trunk/; revision=51261
2013-07-17Remove fragment_data, add fragment_head, fragment_item - for now alias it to ↵Jakub Zawadzki1-1/+1
the same structure. This is begin of work to split fragment head and fragments items. svn path=/trunk/; revision=50708
2013-07-03expert_add_info_format_text + proto_tree_add_text = ↵Michael Mann1-8/+4
proto_tree_add_expert_format, where applicable. svn path=/trunk/; revision=50377
2013-06-30Batch of filterable expert infos.Michael Mann1-4/+14
Also added a note about deprecating expert_add_info_format svn path=/trunk/; revision=50270
2013-03-22Don't wire into the reassembly code the notion that reassemblies shouldGuy Harris1-8/+8
be done on flows from one address to another; reassembly for protocols running atop TCP should be done on flows from one TCP endpoint to another. We do this by: adding "reassembly table" as a data structure; associating hash tables for both in-progress reassemblies and completed reassemblies with that data structure (currently, not all reassemblies use the latter; they might keep completed reassemblies in the first table); having functions to create and destroy keys in that table; offering standard routines for doing address-based and address-and-port-based flow processing, so that dissectors not needing their own specialized flow processing can just use them. This fixes some mis-reassemblies of NIS YPSERV YPALL responses (where the second YPALL response is processed as if it were a continuation of a previous response between different endpoints, even though said response is already reassembled), and also allows the DCE RPC-specific stuff to be moved out of epan/reassembly.c into the DCE RPC dissector. svn path=/trunk/; revision=48491
2013-03-12- [-Wmissing-prototypes]Anders Broman1-4/+4
- explicit casts. svn path=/trunk/; revision=48265
2013-02-21Fix indent (Tab => 4 Spaces) Remove whitespace And Modelines infoAlexis La Goutte1-52/+65
svn path=/trunk/; revision=47800
2013-02-21Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-7/+1
svn path=/trunk/; revision=47799
2013-02-15From Lori Tribble via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8331Evan Huus1-1/+1
Fix UCS-2 string decoding for strings longer than 127 characters. svn path=/trunk/; revision=47675
2013-02-09From Lori Tribble via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8306Evan Huus1-1/+6
Fix decoding the Loop Object Setpoint-Reference property in BACapp packets. svn path=/trunk/; revision=47577
2013-01-10From "schlephorst":Anders Broman1-10/+146
BACnet dissect new tags in NotificationParameters. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8181 svn path=/trunk/; revision=47011
2013-01-10From "schlephorst":Anders Broman1-5/+251
BACnet dissect new tags in EventParameters. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8181 svn path=/trunk/; revision=47010
2012-12-26Fix a bunch of warnings.Guy Harris1-1/+1
Cast away some implicit 64-bit-to-32-bit conversion errors due to use of sizeof. Cast away some implicit 64-bit-to-32-bit conversion errors due to use of strtol() and strtoul(). Change some data types to avoid those implicit conversion warnings. When assigning a constant to a float, make sure the constant isn't a double, by appending "f" to the constant. Constify a bunch of variables, parameters, and return values to eliminate warnings due to strings being given const qualifiers. Cast away those warnings in some cases where an API we don't control forces us to do so. Enable a bunch of additional warnings by default. Note why at least some of the other warnings aren't enabled. randpkt.c and text2pcap.c are used to build programs, so they don't need to be in EXTRA_DIST. If the user specifies --enable-warnings-as-errors, add -Werror *even if the user specified --enable-extra-gcc-flags; assume they know what they're doing and are willing to have the compile fail due to the extra GCC warnings being treated as errors. svn path=/trunk/; revision=46748
2012-12-02Remove unneeded variable initializers.Evan Huus1-7/+6
svn path=/trunk/; revision=46328
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-3/+1
svn path=/trunk/; revision=45017
2012-09-07From Robert Bullen via ↵Jeff Morriss1-0/+2
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7683 : The reassembled fragments tree in the Packet Details view is awesome, but it lacks one thing: a field that exposes the reassembled data. tcp.data already exists for exposing a single TCP segment's payload as a byte array. It would be handy to have something similar for a single application layer PDU when TCP segment reassembly is involved. I propose tcp.reassembled.data, named and placed after the already existing field tcp.reassembled.length. My primary use case for this feature is outputting tcp.reassembled.data with tshark for further processing with a script. The attached patch implements this very feature. Because the reassembled fragment tree code is general purpose, i.e. not specific to just TCP, any dissector that relies upon it can add a similar field very cheaply. In that vein I've also implemented ip.reassembled.data and ipv6.reassembled.data, which expose reassembled fragment data as a single byte stream for IPv4 and IPv6, respectively. All other protocols that use the reassembly code have been left alone, other than inserting NULL into their initializer lists for the newly introduced struct field reassemble.h:fragment_items.hf_reassembled_data. svn path=/trunk/; revision=44802
2012-08-10Use val_to_str_const() where appropriate;Bill Meier1-46/+52
Also (for a few files): - create/use some extended value strings; - remove unneeded #include files; - remove unneeded variable initialization; - re-order fcns slightly so prefs_reg_handoff...() at end, etc svn path=/trunk/; revision=44438
2012-08-02From Lori Tribble via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7556 :Jeff Morriss1-11/+12
The BACnet GetEnrollmentSummary-ACK has an optional parameter Notification Class. The Wireshark decoding does not correctly decode when this parameter is missing. The fix is to verify the context exists before attempting to decode this parameter. From me: replace the few remaining tabs in the file with spaces. svn path=/trunk/; revision=44207
2012-07-20From Lori Tribble:Bill Meier1-3/+4
Attached is a patch which corrects the string construction issue in the PropertyStates method. This patch also corrects a spelling error for 'utcTimeSyncronization' and adds decode support for this property. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6475#c8 svn path=/trunk/; revision=43868
2012-06-28Update FSF address - part II.Jakub Zawadzki1-1/+1
svn path=/trunk/; revision=43538
2012-06-12Fix: code under 'if(tree)' (in)directly calls ↵Bill Meier1-34/+31
sub-dissector/col_...()/expert...() fcns svn path=/trunk/; revision=43226
2012-05-29From Evan Huus:Anders Broman1-2/+13
Fix to BACapp item length causes Buildbot crash output: randpkt-2011-04-13-1899.pcap https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5825 https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7296 svn path=/trunk/; revision=42893
2012-04-28Fix dead initialization warning reported by clang.Chris Maynard1-1/+1
svn path=/trunk/; revision=42323
2012-04-23From Evan Huus:Anders Broman1-558/+590
Another case where a ridiculously large length field was causing a loop counter to overflow. Had to pass pinfo all over the place to add expert info, but the meat of the fix is on line 4960 (after patch applied). https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7121 svn path=/trunk/; revision=42203
2012-04-13Remove doubled semicolons and semicolons outside function.Jakub Zawadzki1-1/+1
svn path=/trunk/; revision=42053
2012-04-05val is unitinialized when fUnsigned32 return false.Jakub Zawadzki1-4/+2
svn path=/trunk/; revision=41961
2012-03-21From Martin Kaiser via ↵Jeff Morriss1-0/+1
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6977 : The attached (trivial) patch adds some missing breaks in switch-case blocks. This fixes coverity defects #445, #446, #1316 and #1380. svn path=/trunk/; revision=41727
2012-02-21Always test tvb_reported_length_remaining() return val for '> 0' instead of ↵Bill Meier1-7369/+7365
'!=0' Also: Whitespace cleanup. svn path=/trunk/; revision=41094
2011-11-09Fix some [-Wunused-but-set-variable] warnings;Bill Meier1-23/+23
Trailing whitespace cleanup. svn path=/trunk/; revision=39771
2011-10-30Fixed some coding errors:Stig Bjørlykke1-2/+2
packet-bacapp.c:6154: error: stray '\250' in program packet-bacapp.c:7137: warning: cast to pointer from integer of different size svn path=/trunk/; revision=39680
2011-10-30Fix unused variable warnings.Anders Broman1-13/+11
svn path=/trunk/; revision=39679
2011-10-30From Lori Tribble:Anders Broman1-63/+652
I found many new properties in BACnet that were not decoded correctly in Wireshark. I have attached a patch that adds decoding to the following properties: Fixed the following properties to decode: In the Accumulator Object: scale (187) prescale (185) logging-record (184) In Access Door Object: door-members (228) masked-alarm-values (234) In the Pulse Converter Object: input-reference (181) In the Group Object: list-of-group-members (53) In the Event Enrollment Object: object-property-reference (78) In the Command Object: action (2) In the Trend Log Multiple object: log-buffer (131) In the Event Log Object: log-buffer (131) In the Structured View object: subordinate-list (211) Added decoding for the following enumeration type properties: Logging-type (197) event-state (36) reliability (103) notify-type (208) door-status (231) lock-status (233) secured-status (235) maintenance-required (158) program-state (92) program-change (90) reason-for-halt (100) mode (160) silenced (163) operation-expected (161) tracking-value (164) file-access-method (41) The above fixes also fixed the log-buffer decoding of the old trend log recorded as Wireshark bug: #6458 I believe this patch also fixes bug: #6235. But the original bug did not contain a capture file so I am not positive my capture represents the originators issue. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6475 svn path=/trunk/; revision=39676
2011-10-21For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.Bill Meier1-3/+3
Also: remove trailing whitespace for a number of files. svn path=/trunk/; revision=39503
2011-10-10 Convert 'encoding' parameter of certain proto_tree_add_item() calls in ↵Bill Meier1-1/+1
non-autogenerated epan/dissectors: Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as the encoding parameter for proto_tree_add_item() calls which directly reference an item in hf[] which has a type of: FT_BOOLEAN FT_IPv4 FT_EUI64 FT_GUID FT_UINT_STRING Also: For type FT_ITv6 use ENC_NA. (This was missed in SVN #39260) svn path=/trunk/; revision=39328
2011-10-06Convert 'encoding' parameter of certain proto_tree_add_item() calls in ↵Bill Meier1-11/+11
non-autogenerated epan/dissectors: Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as the encoding parameter for proto_tree_add_item() calls which directly reference an item in hf[] which has a type of: FT_UINT8 FT_UINT16 FT_UINT24 FT_UINT32 FT_UINT64 FT_INT8 FT_INT16 FT_INT24 FT_INT32 FT_INT64 FT_FLOAT FT_DOUBLE svn path=/trunk/; revision=39288
2011-09-12From Danny Breton: Property name time-synchronization-interval(204) is ↵Bill Meier1-1/+1
incorrectly shown as time-synchronization-recipents. See: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6336 svn path=/trunk/; revision=38977
2011-09-07From Lori Tribble:Anders Broman1-0/+7
Fix problem with the decoding of the exception schedule. It was eating one too many closing tags before exiting and causing the rest of the information to fail to decode correctly. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6178 svn path=/trunk/; revision=38919
2011-09-07From Lori Tribble:Anders Broman1-64/+204
Fixes log-status and status-flags plus other BACnet decoding bugs This patch fixes the log-status and status-flag decoding issues described in this bug report. This patch also fixes the following items: 1) date-list decoding 2) time-synchronization-recipients decoding 3) decoding of UTF-8 character strings (when using character set 0) 4) event-parameter decoding https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5120 svn path=/trunk/; revision=38914
2011-08-23"fix":Anders Broman1-3/+3
Error: Found non-ASCII characters on line 4135 of packet-bacapp.c Error: Found non-ASCII characters on line 4163 of packet-bacapp.c Error: Found non-ASCII characters on line 4198 of packet-bacapp.c svn path=/trunk/; revision=38681
2011-08-23From Steve Karg:Anders Broman1-3/+352
BACnet Dissector latest enumerations for properties, states, error codes, and vendor ids. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6249 svn path=/trunk/; revision=38678
generated by cgit v1.2.1 (git 2.18.0) at 2024-07-13 13:06:56 +0000